Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-17 Thread Duo Zhang
The release note is also ready now. Any other concerns? Thanks. 张铎(Duo Zhang) 于2019年6月17日周一 下午6:31写道: > HBASE-22590 has been resolved and HBASE-21512 has been rebased. Still need > one more vote... > > 张铎(Duo Zhang) 于2019年6月15日周六 下午9:06写道: > >> When filling the release note, I found that I'd

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-17 Thread Duo Zhang
HBASE-22590 has been resolved and HBASE-21512 has been rebased. Still need one more vote... 张铎(Duo Zhang) 于2019年6月15日周六 下午9:06写道: > When filling the release note, I found that I'd better do some works on > master first, such as removing the deprecated methods in Table interface, > so the

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-15 Thread Duo Zhang
When filling the release note, I found that I'd better do some works on master first, such as removing the deprecated methods in Table interface, so the release note will be clean. And also I seem to forget changing the javadoc for some methods in the Admin interface since their behavior have been

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-14 Thread Duo Zhang
HBASE-22577 is almost there. But I think I still need one more +1 here so I can merge HBASE-21512 back... 张铎(Duo Zhang) 于2019年6月14日周五 下午4:54写道: > After applying HBASE-22577 the performance is good enough now. And the > YCSB workloada also shows that there are no big differences on performance.

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-14 Thread Duo Zhang
After applying HBASE-22577 the performance is good enough now. And the YCSB workloada also shows that there are no big differences on performance. Please see the comments on HBASE-22564 for more details. Will get HBASE-22577 in soon, and resolve the pending issues such as HBASE-22237. Any other

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-13 Thread Duo Zhang
It’s hadoop-2.8.5. But I do not think it makes much difference, we just use the same server setup, only different clients implementation. Sakthi 于2019年6月14日 周五10:18写道: > Duo, > > What version on Hadoop did you use in the 5 node cluster for your > comparisons? For what it's worth, I would also

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-13 Thread Sakthi
Duo, What version on Hadoop did you use in the 5 node cluster for your comparisons? For what it's worth, I would also like to try out the PE/LTT comparison of both the clients. Or, if any other form of comparison would be helpful then I'm open for suggestions and would like to give it a try.

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-13 Thread Duo Zhang
It will be transparent, mostly, the interface is still kept. There are some incompatible behaviors, for example, now admin.split will wait till the split is actually done, while in the old time it will return immediately after we send the request to master. Jean-Marc Spaggiari 于2019年6月13日

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-13 Thread Jean-Marc Spaggiari
Hi, Is this going to change the way the client should be called? Or it will be mostly transparent replacement? Thanks, JMS Le jeu. 13 juin 2019 à 02:13, 张铎(Duo Zhang) a écrit : > Josh Elser 于2019年6月12日周三 下午10:00写道: > > > Nice perf results! > > > >

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-13 Thread Duo Zhang
Josh Elser 于2019年6月12日周三 下午10:00写道: > Nice perf results! > > https://issues.apache.org/jira/browse/HBASE-22237 looks like it's also > good to be resolved, given > > https://builds.apache.org/job/HBASE%20Nightly/job/HBASE-21512/279/testReport/ > (TestLogLevel will be fixed on your rebase/merge).

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-12 Thread Josh Elser
Nice perf results! https://issues.apache.org/jira/browse/HBASE-22237 looks like it's also good to be resolved, given https://builds.apache.org/job/HBASE%20Nightly/job/HBASE-21512/279/testReport/ (TestLogLevel will be fixed on your rebase/merge). Poking through the PR, it looks like the big

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-11 Thread Duo Zhang
Filed https://issues.apache.org/jira/browse/HBASE-22564 张铎(Duo Zhang) 于2019年6月11日周二 下午3:53写道: > Let me do a YCSB test about the performance. > > Stack 于2019年6月11日周二 下午1:15写道: > >> +1 on merge from me. >> >> It removes the complicated multi-threaded edifice we'd built client-side >> to >> fake

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-11 Thread Duo Zhang
Let me do a YCSB test about the performance. Stack 于2019年6月11日周二 下午1:15写道: > +1 on merge from me. > > It removes the complicated multi-threaded edifice we'd built client-side to > fake an async behavior replacing it with an actual async implementation. > Users will immediately notice a radical

Re: [VOTE] Merge branch HBASE-21512 back to master

2019-06-10 Thread Stack
+1 on merge from me. It removes the complicated multi-threaded edifice we'd built client-side to fake an async behavior replacing it with an actual async implementation. Users will immediately notice a radical plummet in working thread count on the client side. For the cleanup of old idioms

[VOTE] Merge branch HBASE-21512 back to master

2019-06-10 Thread Duo Zhang
https://issues.apache.org/jira/browse/HBASE-21512 "Reimplement sync client based on async client" The jira title tells everything. This is what I promised when I first introduced the async client in HBase, about three years ago, that the sync client can be implemented on top of the async client,