Re: Disable HBase System tables

2015-04-13 Thread Stephen Jiang
thanks, Anoop, if you can port the HBASE-10619 to branch-1, that would be good. Thanks Stephen On Sat, Apr 4, 2015 at 12:38 AM, Anoop John anoop.hb...@gmail.com wrote: My bad.. Copied wrong Jira id.. It is *HBASE-10619* -Anoop- On Sat, Apr 4, 2015 at 1:07 PM, Anoop John

Re: Disable HBase System tables

2015-04-04 Thread Anoop John
My bad.. Copied wrong Jira id.. It is *HBASE-10619* -Anoop- On Sat, Apr 4, 2015 at 1:07 PM, Anoop John anoop.hb...@gmail.com wrote: HBASE-13158 speaks abt this.. Sorry I missed this completely. I will work on a new patch for this. -Anoop- On Sat, Apr 4, 2015 at 12:28 AM, Jerry He

Re: Disable HBase System tables

2015-04-04 Thread Anoop John
HBASE-13158 speaks abt this.. Sorry I missed this completely. I will work on a new patch for this. -Anoop- On Sat, Apr 4, 2015 at 12:28 AM, Jerry He jerry...@gmail.com wrote: The acl table and label tables are currently guarded in the AccessController or VisibilityController. As Srikanth

Re: Disable HBase System tables

2015-04-03 Thread Jerry He
The acl table and label tables are currently guarded in the AccessController or VisibilityController. As Srikanth mentioned, it is related to HBASE-13336. Should we avoid duplicate checking and make the logic/responsibility clear? The problem probably also exist for the delete/alter/modify table

Re: Disable HBase System tables

2015-04-03 Thread Stephen Jiang
yes, my proposed change is that do the 'tableName.isSystemTable ()' check, instead of 'tableName.equals(TableName.META_TABLE_NAME)' - this check would include all tables inside the hbase namespace. Thanks Stephen By the way, we should rename the 'hbase' namespace to 'system' namespace to make it

Re: Disable HBase System tables

2015-04-02 Thread Enis Söztutar
makes sense. On Thu, Apr 2, 2015 at 3:52 PM, Stephen Jiang syuanjiang...@gmail.com wrote: In disable table, we specifically check whether it is a META table; if a table is a META table, we disallow the table disable. However, I think other system tables should have the same treatment (is it

Disable HBase System tables

2015-04-02 Thread Stephen Jiang
In disable table, we specifically check whether it is a META table; if a table is a META table, we disallow the table disable. However, I think other system tables should have the same treatment (is it possible that a namespace table is disable and the system is still functional without issue?).

Re: Disable HBase System tables

2015-04-02 Thread Srikanth Srungarapu
Nice idea. Related: HBASE-13336. On Thu, Apr 2, 2015 at 5:02 PM, Ted Yu yuzhih...@gmail.com wrote: +1 On Apr 2, 2015, at 4:57 PM, Enis Söztutar e...@apache.org wrote: makes sense. On Thu, Apr 2, 2015 at 3:52 PM, Stephen Jiang syuanjiang...@gmail.com wrote: In disable table,

Re: Disable HBase System tables

2015-04-02 Thread Sean Busbey
+1 disabling the visibility label table is going to be a bad time. Maybe just disallow for the whole hbase namespace? -- Sean On Apr 2, 2015 5:54 PM, Stephen Jiang syuanjiang...@gmail.com wrote: In disable table, we specifically check whether it is a META table; if a table is a META table,

Re: Disable HBase System tables

2015-04-02 Thread Ted Yu
+1 On Apr 2, 2015, at 4:57 PM, Enis Söztutar e...@apache.org wrote: makes sense. On Thu, Apr 2, 2015 at 3:52 PM, Stephen Jiang syuanjiang...@gmail.com wrote: In disable table, we specifically check whether it is a META table; if a table is a META table, we disallow the table