Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread lars hofhansl
apache.org; lars hofhansl Sent: Thursday, March 14, 2013 10:46 AM Subject: Re: Is it feasible to delete qualified tombstones during minor compaction? Actually, major compaction still doesn't look at memstore so the window for reappearing puts is still there, it's just small. I am +1 on

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread Sergey Shelukhin
ey is working on striped compactions where will be able (hopefully) to > limit where we have to look for affected to something smaller than > "everything". > > -- Lars > > > > > From: Ted Yu > To: dev@hbase.apache.org >

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread lars hofhansl
Sent: Thursday, March 14, 2013 9:41 AM Subject: Re: Is it feasible to delete qualified tombstones during minor compaction? That is correct. On Thu, Mar 14, 2013 at 9:28 AM, ramkrishna vasudevan < ramkrishna.s.vasude...@gmail.com> wrote: > So seeing the final patch it means that whateve

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread Ted Yu
That is correct. On Thu, Mar 14, 2013 at 9:28 AM, ramkrishna vasudevan < ramkrishna.s.vasude...@gmail.com> wrote: > So seeing the final patch it means that whatever Liang has asked for is not > available right? > > Regards > Ram > > On Thu, Mar 14, 2013 at 9:55 PM, Ted Yu wrote: > > > The issue

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread ramkrishna vasudevan
So seeing the final patch it means that whatever Liang has asked for is not available right? Regards Ram On Thu, Mar 14, 2013 at 9:55 PM, Ted Yu wrote: > The issue was HBASE-7902 > > The final patch was just mostly renaming: > > - Collections.singletonList(memstoreScanner), > ScanType.

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread Ted Yu
The issue was HBASE-7902 The final patch was just mostly renaming: - Collections.singletonList(memstoreScanner), ScanType.MINOR_COMPACT, + Collections.singletonList(memstoreScanner), ScanType.COMPACT_RETAIN_DELETES, Cheers On Thu, Mar 14, 2013 at 9:22 AM, Anoop John wrote: >

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread Anoop John
Hi I have seen some issue raised by Sergey regarding removing Delete markers during minor compaction. Not remembering the issue id and details :( -Anoop- On Thu, Mar 14, 2013 at 3:11 PM, 谢良 wrote: > Currently, all tombstones only get cleaned up with major compactions. I > guess the or

Re: Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread ramkrishna vasudevan
You can try this out using CP, particularly if you use 0.94 and above. Regards Ram On Thu, Mar 14, 2013 at 3:11 PM, 谢良 wrote: > Currently, all tombstones only get cleaned up with major compactions. I > guess the original > design probably considered that we need to ensure whether there are othe

Is it feasible to delete qualified tombstones during minor compaction?

2013-03-14 Thread 谢良
Currently, all tombstones only get cleaned up with major compactions. I guess the original design probably considered that we need to ensure whether there are other versions of the deleted key in other storefiles which are not included in minor compaction? If that's true, i have a thought, maybe