Re: JDK version issue during doing 1.7.0 release

2021-04-21 Thread Reid Chan
Thanks Andrew! Let me try the 1st first which seems the easiest, 2nd seems much works but worth a try if I fail in the 1st. The 3rd should be the final compromise. -- Best Regards, R.C On Wed, Apr 21, 2021 at 12:34 AM Andrew Purtell wrote: > In my opinion we have a few reasonable

Re: JDK version issue during doing 1.7.0 release

2021-04-20 Thread Andrew Purtell
In my opinion we have a few reasonable options, especially considering this is the last release from branch-1. 1. Make the hbase-thrift module's activation contingent of compilation with a Java 8+ JDK. Here's an example of how to do that: https://github.com/apache/hbase/pull/251 (

Re: JDK version issue during doing 1.7.0 release

2021-04-20 Thread Duo Zhang
Is it possible to patch the old thrift which supports JDK7? Stack 于2021年4月20日周二 上午2:28写道: > I'm w/ Peter -- release 1.7 w/ jdk7 & old thrift and then call it a day. > Thanks, > S > > On Mon, Apr 19, 2021 at 9:07 AM Reid Chan wrote: > > > Bring this up again. > > > > There are two straight

Re: JDK version issue during doing 1.7.0 release

2021-04-19 Thread Stack
I'm w/ Peter -- release 1.7 w/ jdk7 & old thrift and then call it a day. Thanks, S On Mon, Apr 19, 2021 at 9:07 AM Reid Chan wrote: > Bring this up again. > > There are two straight forward solutions: one is as Peter mentioned, the > other is released with JDK 8. I think the choice is about

Re: JDK version issue during doing 1.7.0 release

2021-04-19 Thread Reid Chan
Bring this up again. There are two straight forward solutions: one is as Peter mentioned, the other is released with JDK 8. I think the choice is about which weighs more. Better if we have a more tricky workaround. Not sure if it needs a [VOTE] thread or not, please let me know. --- Best

Re: JDK version issue during doing 1.7.0 release

2021-04-14 Thread Peter Somogyi
I'm +1 on maintaining JDK7 compatibility and releasing 1.7.0 with the older Thrift version. Peter On Wed, Apr 14, 2021 at 5:01 AM Nick Dimiduk wrote: > hbase-thrift is itself optional though. It’s “just” a gateway, not a core > service. Agree, where it’s used, it’s critical for those users.

Re: JDK version issue during doing 1.7.0 release

2021-04-13 Thread Nick Dimiduk
hbase-thrift is itself optional though. It’s “just” a gateway, not a core service. Agree, where it’s used, it’s critical for those users. But it’s not in the critical path for all users. Maybe it’s easier to bend on this than the minimum JDK version? Just a thought... On Tue, Apr 13, 2021 at

Re: JDK version issue during doing 1.7.0 release

2021-04-13 Thread Reid Chan
Is JDK 7 a hard restriction in this case? Could we compromise here to use JDK 8? -- Best Regards, R.C On Tue, Apr 13, 2021 at 3:35 PM Reid Chan wrote: > Hi team and community: > > This is the error message when I tried to make a release 1.7.0: > > [INFO] Restricted to JDK 1.7 yet >

Re: JDK version issue during doing 1.7.0 release

2021-04-13 Thread Duo Zhang
The hbase-thrift module depends on thrift, it can not be optional... Nick Dimiduk 于2021年4月14日周三 上午8:44写道: > Oh. Bad. > > Can we mark the Thrift dependency optional, mark the ANNOUNCEMENT with a > big fat notice, and let users proceed at their own risk? > > On Tue, Apr 13, 2021 at 2:05 PM

Re: JDK version issue during doing 1.7.0 release

2021-04-13 Thread Nick Dimiduk
Oh. Bad. Can we mark the Thrift dependency optional, mark the ANNOUNCEMENT with a big fat notice, and let users proceed at their own risk? On Tue, Apr 13, 2021 at 2:05 PM Geoffrey Jacoby wrote: > It appears that both thrift 0.12 (which HBase 1.6 uses) and Thrift 0.13 > (which HBase 1.7 is

Re: JDK version issue during doing 1.7.0 release

2021-04-13 Thread Geoffrey Jacoby
It appears that both thrift 0.12 (which HBase 1.6 uses) and Thrift 0.13 (which HBase 1.7 is targeted for and that Reid is having trouble building for JDK 7) have CVEs attached to them, which is why later branches are using Thrift 0.14.1. (See CVE-2019-0205 [1] for Thrift 0.12, and CVE-2020-13949

JDK version issue during doing 1.7.0 release

2021-04-13 Thread Reid Chan
Hi team and community: This is the error message when I tried to make a release 1.7.0: [INFO] Restricted to JDK 1.7 yet org.apache.thrift:libthrift:jar:0.13.0:compile contains org/apache/thrift/TNonblockingMultiFetchClient.class targeted to JDK 1.8 HBase has unsupported dependencies. HBase