Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-17 Thread Nick Dimiduk
No invitation necessary, the connection details are here, https://github.com/open-telemetry/community#discussions On Tue, Nov 16, 2021 at 7:35 PM 张铎(Duo Zhang) wrote: > Thanks Nick. This is also my understanding if I read your email > correctly... > > And could you please invite me into the

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-16 Thread Duo Zhang
Thanks Nick. This is also my understanding if I read your email correctly... And could you please invite me into the OTEL slack channel? Thanks. Nick Dimiduk 于2021年11月17日周三 上午1:45写道: > > From conversations I've had over on the otel slack, it seems that all we > really need to do is make sure

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-16 Thread Nick Dimiduk
>From conversations I've had over on the otel slack, it seems that all we really need to do is make sure that there's a "current" span when handing flow control over to user code. On Mon, Nov 15, 2021 at 6:15 PM Andrew Purtell wrote: > If the exposure is for/within coprocessors, I think that

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-15 Thread Andrew Purtell
If the exposure is for/within coprocessors, I think that usage falls under the same exception we make for LimitedPrivate and other things that are necessary for server internal extension but are not public API either. On Tue, Nov 9, 2021 at 4:04 PM Nick Dimiduk wrote: > Let me find some

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-09 Thread Nick Dimiduk
Let me find some clarification on what/how might be exposed. On Tue, Nov 9, 2021 at 3:34 PM 张铎(Duo Zhang) wrote: > What does ‘expose’ actually mean here? > > I think a typical usage is that, users create a span and a scope, and in > the scope they call our client API, and our client API will

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-09 Thread Duo Zhang
What does ‘expose’ actually mean here? I think a typical usage is that, users create a span and a scope, and in the scope they call our client API, and our client API will make use of the Span in the current scope? So at least we need to let users know they have to use otel if they want to trace

Re: [DISCUSS] Introducing OpenTelemerty into our public API

2021-11-09 Thread Sean Busbey
If it was akin to slf4j, that integration has been relatively smooth for downstream. log4j effectively being in our public api through configuration formats has been a maintenance nightmare. These would effectively be in our java binary API though, right? Would we gain any meaningful isolation