---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/
---
(Updated 2010-06-13 00:49:50.977413)
Review request for hbase, Todd Lipcon and
On 2010-06-10 08:53:41, Jonathan Gray wrote:
src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 1079
http://review.hbase.org/r/98/diff/5/?file=943#file943line1079
I guess these are static because of how HTables all share a single HCM
per conf. The setting of
On 2010-06-10 08:53:41, Jonathan Gray wrote:
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java, line 109
http://review.hbase.org/r/98/diff/5/?file=944#file944line109
Hmm, wouldn't that be Math.min then? If rowLimit = 5 and
scanner.caching = 100, we want to only do 5?
On 09/06/10 15:56, tsuna wrote:
Oh, I see. But that's because the regionCachePrefetchEnabled method
was unnecessarily changing the Map. If the read-only methods like
this one weren't modifying any data structure (and they don't need
to), this problem wouldn't exist.
Yep, exactly. None of the
On 2010-06-07 14:23:42, stack wrote:
src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java, line 96
http://review.hbase.org/r/98/diff/5/?file=944#file944line96
getRowOrBefore is an expensive call. Are we sure we are not calling
this too often?
I agree it is an expensive
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/
---
(Updated 2010-06-09 15:50:59.084657)
Review request for hbase, Todd Lipcon and
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/#review165
---
Looking good! Just a few notes.
On Fri, May 28, 2010 at 8:21 PM, Paul Cowan co...@aconex.com wrote:
Changing this class to use ConcurrentHashMap, and completely removing
synchronization, won't work, as it's written. The lazy-loading in
regionCachePreFetchEnabled() (get - if null, put) won't work correctly with
a
On Tue, Jun 8, 2010 at 5:59 PM, Paul Cowan co...@aconex.com wrote:
No problem. With that change, there would be a potential race condition:
Thread 1 Thread 2
-- -
enter regionCachePrefetchEnabled
call
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/#review144
---
Ship it!
I think this good to go. Seem my comments below. See what you
On 2010-05-31 21:52:12, Todd Lipcon wrote:
src/main/java/org/apache/hadoop/hbase/client/HTable.java, line 1075
http://review.hbase.org/r/98/diff/4/?file=872#file872line1075
I feel like it would be cleaner to have the following methods be
non-static, so they don't need any
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/
---
(Updated 2010-06-02 01:13:42.272750)
Review request for hbase.
Changes
---
1.
On 2010-05-28 15:05:08, Ryan Rawson wrote:
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java, line
1604
http://review.hbase.org/r/98/diff/3/?file=741#file741line1604
What does this method actually do? If its a predicate start it with
'is'. Also precaching
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/
---
(Updated 2010-05-31 19:49:20.012863)
Review request for hbase.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/98/#review93
---
src/main/java/org/apache/hadoop/hbase/client/HConnection.java
On 2010-05-28 14:13:14, Benoit Sigoure wrote:
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java, line
306
http://review.hbase.org/r/98/diff/3/?file=741#file741line306
Please use a concurrent collection and remove the synchronized blocks.
For guidance, see
16 matches
Mail list logo
