Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-03 Thread Ted Yu
Nicolas: Your earlier comment on metrics that make a feature more palatable is very good. Can you take a look at and see if there is more information you want to gather ?

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-03 Thread Andrew Purtell
: Stack st...@duboce.net To: dev@hbase.apache.org Sent: Wednesday, November 2, 2011 8:17 PM Subject: Re: patch maturity and HBase release Was: HBASE-4120 table level priority On Wed, Nov 2, 2011 at 5:12 PM, Nicolas Spiegelberg nspiegelb...@fb.com wrote: I agree with Todd's sentiments

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-03 Thread Roman Shaposhnik
On Wed, Nov 2, 2011 at 8:11 PM, Stack st...@duboce.net wrote: On Wed, Nov 2, 2011 at 5:31 PM, Roman Shaposhnik r...@apache.org wrote: As I mentioned before, I'd love to expand on that. But so far I haven't heard anybody willing to contribute to:  

patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Ted Yu
Thanks for the reminder Stack. I got a little sidetracked after working at 3AM this morning :-) As Stack has demonstrated through adding unit tests for HBASE-4298, feature patches would get accepted faster if committers are willing to nurture them. There is usually considerable amount of work

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Ted Yu
I agree with Todd's points. w.r.t. HBASE-4120 and multi-tenant HBase clusters, allow me to point to this discussion: https://issues.apache.org/jira/browse/HBASE-4329?focusedCommentId=13096986page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13096986 I think there are

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Nicolas Spiegelberg
I agree with Todd's sentiments on unnecessarily coupling feature priority with the availability of a patch. There's patches that we've developed internally, then threw away because we couldn't tie it to a production use case or thought a better design might be necessary. There's also patches

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Ted Dunning
Todd, I am curious what you mean here. How is adding a test suite better than annotating different tests in the TestNG or Junit 4 style? On Wed, Nov 2, 2011 at 5:25 PM, Todd Lipcon t...@cloudera.com wrote: Adding a system test suite would do us some good here. Accumulo has a very nice one

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Todd Lipcon
On Wed, Nov 2, 2011 at 5:31 PM, Ted Dunning tdunn...@maprtech.com wrote: Todd, I am curious what you mean here.  How is adding a test suite better than annotating different tests in the TestNG or Junit 4 style? By test suite I wasn't referring to an implementation style. I'm referring to a

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Ted Dunning
On Wed, Nov 2, 2011 at 5:33 PM, Todd Lipcon t...@cloudera.com wrote: On Wed, Nov 2, 2011 at 5:31 PM, Ted Dunning tdunn...@maprtech.com wrote: Todd, I am curious what you mean here. How is adding a test suite better than annotating different tests in the TestNG or Junit 4 style? By

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Roman Shaposhnik
On Wed, Nov 2, 2011 at 5:39 PM, Ted Dunning tdunn...@maprtech.com wrote: By test suite I wasn't referring to an implementation style. I'm referring to a testing style in which the tests would run against a real live deployed cluster, generate load, run for several hours/continuously, etc.

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Roman Shaposhnik
On Wed, Nov 2, 2011 at 5:25 PM, Todd Lipcon t...@cloudera.com wrote: Adding a system test suite would do us some good here. Accumulo has a very nice one which we could work on cloning (though the APIs are different we can borrow the test scenarios). Essentially, that's what I'm doing over

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Stack
On Wed, Nov 2, 2011 at 5:31 PM, Roman Shaposhnik r...@apache.org wrote: As I mentioned before, I'd love to expand on that. But so far I haven't heard anybody willing to contribute to:   https://svn.apache.org/repos/asf/incubator/bigtop/trunk/bigtop-tests/test-artifacts/hbase/ I'm

Re: patch maturity and HBase release Was: HBASE-4120 table level priority

2011-11-02 Thread Stack
On Wed, Nov 2, 2011 at 5:12 PM, Nicolas Spiegelberg nspiegelb...@fb.com wrote: I agree with Todd's sentiments on unnecessarily coupling feature priority with the availability of a patch.  There's patches that we've developed internally, then threw away because we couldn't tie it to a production