Re: question regarding code

2011-12-30 Thread Mikael Sitruk
>> Mikael.S > >>> > >>> > >>> On Thu, Dec 29, 2011 at 6:54 PM, lars hofhansl > >> wrote: > >>> > >>>> The only downside is that the ArrayList now is always created, even if > >> it > >>>> is not

Re: question regarding code

2011-12-30 Thread yuzhihong
gt;>> On Thu, Dec 29, 2011 at 6:54 PM, lars hofhansl >> wrote: >>> >>>> The only downside is that the ArrayList now is always created, even if >> it >>>> is not needed, thereby producing unnecessary garbage. >>>> I have not b

Re: question regarding code

2011-12-30 Thread Mikael Sitruk
ing how frequently we'll get here and find no relevant > >> regions, though. > >> > >> > >> -- Lars > >> > >> > >> - Original Message - > >> From: Harsh J > >> To: dev@hbase.apache.org

Re: question regarding code

2011-12-29 Thread Lars H
gt; >> - Original Message - >> From: Harsh J >> To: dev@hbase.apache.org >> Cc: >> Sent: Thursday, December 29, 2011 12:51 AM >> Subject: Re: question regarding code >> >> Yeah that'd work too. File a JIRA with the change? >> >>

Re: question regarding code

2011-12-29 Thread Lars H
equently we'll get here and find no relevant >> regions, though. >> >> >> -- Lars >> >> >> - Original Message - >> From: Harsh J >> To: dev@hbase.apache.org >> Cc: >> Sent: Thursday, December 29, 2011 12:51 AM >> Su

Re: question regarding code

2011-12-29 Thread Ted Yu
hough. > > > > > > -- Lars > > > > > > - Original Message - > > From: Harsh J > > To: dev@hbase.apache.org > > Cc: > > Sent: Thursday, December 29, 2011 12:51 AM > > Subject: Re: question regarding code > > >

Re: question regarding code

2011-12-29 Thread Harsh J
rsday, December 29, 2011 12:51 AM > Subject: Re: question regarding code > > Yeah that'd work too. File a JIRA with the change? > > On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > >> Hi all >> >> I have question on some code (taken from HLog

Re: question regarding code

2011-12-29 Thread Mikael Sitruk
nd find no relevant > regions, though. > > > -- Lars > > > - Original Message - > From: Harsh J > To: dev@hbase.apache.org > Cc: > Sent: Thursday, December 29, 2011 12:51 AM > Subject: Re: question regarding code > > Yeah that'd work too. File

Re: question regarding code

2011-12-29 Thread lars hofhansl
e.org Cc: Sent: Thursday, December 29, 2011 12:51 AM Subject: Re: question regarding code Yeah that'd work too. File a JIRA with the change? On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > Hi all > > I have question on some code (taken from HLog) see below &

Re: question regarding code

2011-12-29 Thread Mikael Sitruk
NP I'll fill it On Dec 29, 2011 10:52 AM, "Harsh J" wrote: > Yeah that'd work too. File a JIRA with the change? > > On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > > > Hi all > > > > I have question on some code (taken from HLog) see below > > > > > > static byte [][] findMemstoresWithEditsEq

Re: question regarding code

2011-12-29 Thread Harsh J
Yeah that'd work too. File a JIRA with the change? On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > Hi all > > I have question on some code (taken from HLog) see below > > > static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long > oldestWALseqid, > final Map regionsToSeqids

question regarding code

2011-12-29 Thread Mikael Sitruk
Hi all I have question on some code (taken from HLog) see below static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long oldestWALseqid, final Map regionsToSeqids) { // This method is static so it can be unit tested the easier. List regions = null; for (Map.Entry e