[GitHub] garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.

garydgregory commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module. URL: https://github.com/apache/httpcomponents-core/pull/105#discussion_r256618310 ## File path: pom.xml ## @@ -185,7 +185,15 @@ $

[GitHub] ok2c opened a new pull request #106: Immutable httpentities

ok2c opened a new pull request #106: Immutable httpentities URL: https://github.com/apache/httpcomponents-core/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ok2c commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.

ok2c commented on a change in pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module. URL: https://github.com/apache/httpcomponents-core/pull/105#discussion_r256602682 ## File path: pom.xml ## @@ -185,7 +185,15 @@ ${basedir

Re: Formal code reviews and PRs

Am 2019-02-13 um 17:08 schrieb Oleg Kalnichevski: Folks Since HttpComponents migration to GitBox I have been committing all my code changes to a feature branch and leaving them sit there for a day or two prior to merging them to a development branch (master or stable version branches). If there

[jira] [Created] (HTTPCORE-572) Move examples to the src/test folders for each module

Gary Gregory created HTTPCORE-572: - Summary: Move examples to the src/test folders for each module Key: HTTPCORE-572 URL: https://issues.apache.org/jira/browse/HTTPCORE-572 Project: HttpComponents Http

[GitHub] garydgregory opened a new pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module.

garydgregory opened a new pull request #105: [HTTPCORE-572] Move examples to the src/test folders for each module. URL: https://github.com/apache/httpcomponents-core/pull/105 This is an automated message from the Apache Git

[jira] [Commented] (HTTPCORE-572) Move examples to the src/test folders for each module

[ https://issues.apache.org/jira/browse/HTTPCORE-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767397#comment-16767397 ] ASF subversion and git services commented on HTTPCORE-572: -- Co

[jira] [Closed] (HTTPASYNC-148) ResponseContentEncoding not working with HttpAsyncClient

[ https://issues.apache.org/jira/browse/HTTPASYNC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siqi Li closed HTTPASYNC-148. - > ResponseContentEncoding not working with HttpAsyncClient > -

Formal code reviews and PRs

Folks Since HttpComponents migration to GitBox I have been committing all my code changes to a feature branch and leaving them sit there for a day or two prior to merging them to a development branch (master or stable version branches). If there is anyone interested in doing formal code reviews o

[GitHub] ok2c commented on a change in pull request #136: HTTPCLIENT-1968

ok2c commented on a change in pull request #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136#discussion_r256437720 ## File path: httpclient/src/main/java/org/apache/http/client/utils/URIUtils.java ## @@ -129,7 +129,8 @@ public static URI c

[GitHub] cstamas opened a new pull request #136: HTTPCLIENT-1968

cstamas opened a new pull request #136: HTTPCLIENT-1968 URL: https://github.com/apache/httpcomponents-client/pull/136 https://issues.apache.org/jira/browse/HTTPCLIENT-1968 Make the normalization optional (default == true) based on `RequestConfig` setting. All the legacy spots just ke

Re: Move Examples into a package in the test folder

I am trying to build the site to make sure I can, before I change anything and I noticed that on http://hc.apache.org/httpcomponents-core-5.0.x/project-info.html All of the links on the RHS menu under "Modules" are broken. Gary On Wed, Feb 13, 2019 at 7:59 AM Oleg Kalnichevski wrote: > On Wed

Re: Move Examples into a package in the test folder

On Wed, 2019-02-13 at 07:46 -0500, Gary Gregory wrote: > Hi All: > > I think it would be better if our examples lived in a .examples. > package > under the src/test folder. The advantages are: > > - Examples would always be compiled by Maven and IDEs > - Examples would end up living in the test

Move Examples into a package in the test folder

Hi All: I think it would be better if our examples lived in a .examples. package under the src/test folder. The advantages are: - Examples would always be compiled by Maven and IDEs - Examples would end up living in the test jar, which would be handy for testing certain use-cases. In my case, te

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767109#comment-16767109 ] Stas Gromov commented on HTTPCLIENT-1968: - It's not always possible to chang

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767112#comment-16767112 ] Stas Gromov commented on HTTPCLIENT-1968: - your rudeness is the stopper for

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767110#comment-16767110 ] Oleg Kalnichevski commented on HTTPCLIENT-1968: --- {quote}I can't do it

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767107#comment-16767107 ] Stas Gromov commented on HTTPCLIENT-1968: - I just want to make exactly what

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767100#comment-16767100 ] Oleg Kalnichevski commented on HTTPCLIENT-1968: --- {quote}which is compl

[jira] [Comment Edited] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767065#comment-16767065 ] Stas Gromov edited comment on HTTPCLIENT-1968 at 2/13/19 11:20 AM: ---

[jira] [Comment Edited] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767065#comment-16767065 ] Stas Gromov edited comment on HTTPCLIENT-1968 at 2/13/19 11:20 AM: ---

[jira] [Commented] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767065#comment-16767065 ] Stas Gromov commented on HTTPCLIENT-1968: - I'm in. I have troubles upgrading

[jira] [Comment Edited] (HTTPCLIENT-1968) Encoded forward slashes are not preserved when rewriting URI

[ https://issues.apache.org/jira/browse/HTTPCLIENT-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767065#comment-16767065 ] Stas Gromov edited comment on HTTPCLIENT-1968 at 2/13/19 11:18 AM: ---

Re: RFC 2616 Retry-After Support

Thank you for your kind reply Oleg. Based on the Apache Http Client site, it seems that HttpClient 5.0 is still in beta. What is a good way for me and/or my company to contribute towards moving the project forward? Thank you, Elijah On Tue, Feb 12, 2019 at 1:42 AM Oleg Kalnichevski wrote: > > O

Re: RFC 2616 Retry-After Support

On Tue, 2019-02-12 at 22:35 -0800, Elijah Zupancic wrote: > Thank you for your kind reply Oleg. > > Based on the Apache Http Client site, it seems that HttpClient 5.0 is > still in beta. We are not yet ready to freeze 5.0 APIs but otherwise what difference does that make? > What is a good wa

[jira] [Commented] (HTTPASYNC-148) ResponseContentEncoding not working with HttpAsyncClient

[ https://issues.apache.org/jira/browse/HTTPASYNC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766910#comment-16766910 ] Oleg Kalnichevski commented on HTTPASYNC-148: - [~slisaasquatch] There are