[VOTE] Release HttpClient 5.2-beta1 based on RC1

2022-06-03 Thread Oleg Kalnichevski
Please vote on releasing these packages as HttpClient 5.2-beta1. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 than -1 votes. Release notes:

[GitHub] [httpcomponents-core] carterkozak commented on a diff in pull request #349: (test) Add test for BasicFuture.failed and ComplexFuture.failed

2022-06-03 Thread GitBox
carterkozak commented on code in PR #349: URL: https://github.com/apache/httpcomponents-core/pull/349#discussion_r889001054 ## httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestComplexFuture.java: ## @@ -96,4 +96,11 @@ public void completed(final Object result) {

[GitHub] [httpcomponents-core] carterkozak commented on a diff in pull request #349: (test) Add test for BasicFuture.failed and ComplexFuture.failed

2022-06-03 Thread GitBox
carterkozak commented on code in PR #349: URL: https://github.com/apache/httpcomponents-core/pull/349#discussion_r889000388 ## httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestComplexFuture.java: ## @@ -96,4 +96,11 @@ public void completed(final Object result) {

[GitHub] [httpcomponents-core] lacinoire opened a new pull request, #349: (test) Add test for BasicFuture.failed and ComplexFuture.failed

2022-06-03 Thread GitBox
lacinoire opened a new pull request, #349: URL: https://github.com/apache/httpcomponents-core/pull/349 Hey  I want to contribute the following test: Test that `future.failed(new java.lang.Exception())` is false when `failed` is called with the parameter `exception = new