Re: [PR] fix: URIBuilder.getFirstQueryParam throws exception when query is emty [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c merged PR #449: URL: https://github.com/apache/httpcomponents-core/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
michael-o commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1863303032 > https://www.rfc-editor.org/rfc/rfc9110.html#section-4.2.4 is not about HTTP(s) URIs in general, but what should happen WRT userinfo in an HTTP message (be it in the target

Re: [PR] fix: URIBuilder.getFirstQueryParam throws exception when query is emty [httpcomponents-core]

2023-12-19 Thread via GitHub
skssxf commented on code in PR #449: URL: https://github.com/apache/httpcomponents-core/pull/449#discussion_r1431681897 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -967,7 +967,7 @@ public List getQueryParams() { * @since 5.2 */ pub

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
reschke commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1863101407 https://www.rfc-editor.org/rfc/rfc9110.html#section-4.2.4 is not about HTTP(s) URIs in general, but what should happen WRT userinfo in an HTTP message (be it in the target URI)

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1863020528 @arturobernalg @michael-o I propose this change-set be reverted so I could proceed with the `5.3-alpha1` release. We can revisit the issue in the course of `5.3-alpha2`. -- Thi

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
michael-o commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1862828439 Let me re-read 4.2.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
michael-o commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1862818751 Good question. @reschke to the rescue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] HTTPCORE-756 - Deprecation of userInfo in Compliance with RFC 9110 [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c commented on PR #418: URL: https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1862776884 @arturobernalg @michael-o As I suspected the complete removal of `userinfo` support turned out to be not such a good idea. Now HttpClient is unable to reject requests with URIs co

Re: [PR] Bump actions/setup-java from 3 to 4 [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c merged PR #446: URL: https://github.com/apache/httpcomponents-core/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] Bump github/codeql-action from 2 to 3 [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c merged PR #448: URL: https://github.com/apache/httpcomponents-core/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apac

Re: [PR] fix: URIBuilder.getFirstQueryParam throws exception when query is emty [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c commented on code in PR #449: URL: https://github.com/apache/httpcomponents-core/pull/449#discussion_r1431391449 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -967,7 +967,7 @@ public List getQueryParams() { * @since 5.2 */ publi

Re: [PR] fix: URIBuilder.getFirstQueryParam throws exception when query is emty [httpcomponents-core]

2023-12-19 Thread via GitHub
ok2c commented on code in PR #449: URL: https://github.com/apache/httpcomponents-core/pull/449#discussion_r1431391449 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -967,7 +967,7 @@ public List getQueryParams() { * @since 5.2 */ publi

[PR] fix: URIBuilder.getFirstQueryParam throws exception when query is emty [httpcomponents-core]

2023-12-19 Thread via GitHub
skssxf opened a new pull request, #449: URL: https://github.com/apache/httpcomponents-core/pull/449 Due to description of `URIBuilder.getFirstQueryParam()` it must return `null` if named parameter not found. When query is empty `this.queryParams == null` so calling `queryParams.stream()...`

[jira] [Comment Edited] (HTTPCLIENT-2313) NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled

2023-12-19 Thread Sven Haster (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798568#comment-17798568 ] Sven Haster edited comment on HTTPCLIENT-2313 at 12/19/23 12:41 PM: --

[jira] [Commented] (HTTPCLIENT-2313) NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled

2023-12-19 Thread Sven Haster (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798568#comment-17798568 ] Sven Haster commented on HTTPCLIENT-2313: - Kudo's for the quick response tim

[jira] [Resolved] (HTTPCLIENT-2313) NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled

2023-12-19 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-2313. --- Resolution: Fixed Fixed in 5.3.x Oleg > NPE NullPointerException in Po

[jira] [Updated] (HTTPCLIENT-2313) NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled

2023-12-19 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/HTTPCLIENT-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCLIENT-2313: -- Fix Version/s: 5.3.1 Priority: Trivial (was: Blocker) > NPE Null

Re: [PR] Add Zstd support to ContentCompressionExec. [httpcomponents-client]

2023-12-19 Thread via GitHub
ok2c closed pull request #498: Add Zstd support to ContentCompressionExec. URL: https://github.com/apache/httpcomponents-client/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Implement HappyEyeballsV2AsyncClientConnectionOperator [httpcomponents-client]

2023-12-19 Thread via GitHub
ok2c closed pull request #428: Implement HappyEyeballsV2AsyncClientConnectionOperator URL: https://github.com/apache/httpcomponents-client/pull/428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Created] (HTTPCLIENT-2313) NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled

2023-12-19 Thread Sven Haster (Jira)
Sven Haster created HTTPCLIENT-2313: --- Summary: NPE NullPointerException in PoolingHttpClientConnectionManager when debug logging is enabled Key: HTTPCLIENT-2313 URL: https://issues.apache.org/jira/browse/HTTPCLI