Github user ato closed the pull request at:
https://github.com/apache/httpcomponents-client/pull/107
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/71
@ok2c Yes that looks sufficient for my use case (handling and saving pushes
relative to the requests that triggered them). It's also definitely cleaner
than thr attempted approaches
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/71
@ok2c, I attempted a second try at this but struggled with the design. I
won't be able to get back to this for some time now due to other work
priorities that have come up. So if you
Github user ato closed the pull request at:
https://github.com/apache/httpcomponents-core/pull/71
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/71#discussion_r203669187
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractHttp2StreamMultiplexer.java
---
@@ -610,7 +612,7 @@ private void
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/71#discussion_r203645081
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractHttp2StreamMultiplexer.java
---
@@ -610,7 +612,7 @@ private void
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/71#discussion_r203638757
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientPushHttp2StreamHandler.java
---
@@ -99,16 +101,18 @@ public void
GitHub user ato opened a pull request:
https://github.com/apache/httpcomponents-core/pull/71
Implement propsed AsyncPushConsumer execution API
@ok2c I tried to implement the proposed API. Some comments below.
You can merge this pull request into a Git repository by running
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ok2x That looks perfect to me.
If the user calls client. execute() with a push consumer it would override
any registered via client.register() right? I don't think it'
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
Looks good. Thanks.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h
Github user ato closed the pull request at:
https://github.com/apache/httpcomponents-core/pull/70
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
Just realised getContext() can go too. One moment.
---
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ok2c Sorry, some other issues came up and I didn't get a chance to
progress this. I've removed the context chaining stuff.
Yes, I still want this. It sounds like you mig
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
Edit: Removed the context nonsense from the IdentityHashMap example. I hit
the comment button too soon. :-(
---
-
To
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
> @ato What if we passed the original request message (or its request URI)
instead of linking the contexts?
For my use case the request message is a means to an end. I want
GitHub user ato opened a pull request:
https://github.com/apache/httpcomponents-client/pull/107
AsyncPushConsumer now also accepts a HttpContext
These are the corresponding client changes for the core interface change in
apache/httpcomponents-core#70.
This patch is not
Github user ato commented on the issue:
https://github.com/apache/httpcomponents-core/pull/70
@ok2c Pull request updated to address review comments.
I'll send a pull request against httpcomponents-client for the
corresponding interface changes sh
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202547255
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/nio/AsyncPushConsumer.java ---
@@ -40,7 +41,7 @@
*/
public interface
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202547100
--- Diff:
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ClientHttp2StreamMultiplexer.java
---
@@ -83,10 +83,15 @@ public
Github user ato commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/70#discussion_r202546804
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/HttpCoreContext.java
---
@@ -155,4 +162,10 @@ public HttpResponse getResponse
GitHub user ato opened a pull request:
https://github.com/apache/httpcomponents-core/pull/70
Add the original request's context to the server pushed's context
This is to enable the push consumer to determine which request the server
sent the push in reply to when there ar
21 matches
Mail list logo
