Re: Re: Re: Formal code reviews and PRs

2019-02-14 Thread Oleg Kalnichevski
On Thu, 2019-02-14 at 16:27 +0100, Michael Osipov wrote: > > Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr > > Von: "Oleg Kalnichevski" > > An: "HttpComponents Project" > > Betreff: Re: Re: Formal code reviews and PRs > > > >

Re: Re: Re: Formal code reviews and PRs

2019-02-14 Thread Michael Osipov
> Gesendet: Donnerstag, 14. Februar 2019 um 16:21 Uhr > Von: "Oleg Kalnichevski" > An: "HttpComponents Project" > Betreff: Re: Re: Formal code reviews and PRs > > On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > > On Thu, 2019-02-14 a

Re: Re: Formal code reviews and PRs

2019-02-14 Thread Oleg Kalnichevski
On Thu, 2019-02-14 at 16:12 +0100, Michael Osipov wrote: > > On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > > That sounds nice. > > > > > > Can we agree to add trivial changes to master directly, for > > > example, > > > if I > > > want to Javadoc a previously undocumented method? > >

Re: Re: Formal code reviews and PRs

2019-02-14 Thread Michael Osipov
> On Thu, 2019-02-14 at 09:14 -0500, Gary Gregory wrote: > > That sounds nice. > > > > Can we agree to add trivial changes to master directly, for example, > > if I > > want to Javadoc a previously undocumented method? > > > > I disagree rather strongly, especially if we want to keep master bran

Re: Re: Formal code reviews and PRs

2019-02-14 Thread Michael Osipov
Absolutely! > Gesendet: Donnerstag, 14. Februar 2019 um 15:14 Uhr > Von: "Gary Gregory" > An: "HttpComponents Project" > Betreff: Re: Formal code reviews and PRs > > That sounds nice. > > Can we agree to add trivial changes to master directly, for example, if I > want to Javadoc a previously un