[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423959 @jerrypeng Thank you so much! I will do experiments with heron multithreading in the next weeks. I hope to have some results to shar

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423959 @jerrypeng Thank you so much! I will do experiments with heron multithreading in the next weeks. I hope to have some performance com

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390422873 @nlu90 just to be clear, with out this patch its not even possible to guarantee at-most once. An NPE will very likely to be thrown if y

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390423252 @bornej here is an example of a bolt that acks and emits from a different thread ``` public static class ExclamationBolt exten

[GitHub] jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
jerrypeng commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390422873 @nlu90 just to be clear, with out this patch its not even possible to guarantee at-most once. An NPE will very likely to be thrown if y

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390401048 Thank you very much, Is there any example of multi-threaded heron bolt/spout/topology out there? ---

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-19 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390401048 Thanks you very much, Is there any example of multi-threaded heron bolt/spout/topology out there? --

[GitHub] nwangtw commented on issue #2794: update container count to 2 in the example ExclamationTopology

2018-05-18 Thread GitBox
nwangtw commented on issue #2794: update container count to 2 in the example ExclamationTopology URL: https://github.com/apache/incubator-heron/pull/2794#issuecomment-390318771 lgtm. but I am curious about the reason to have this PR.

[GitHub] nwangtw commented on issue #2807: remove three other roundings in cpu calculation

2018-05-18 Thread GitBox
nwangtw commented on issue #2807: remove three other roundings in cpu calculation URL: https://github.com/apache/incubator-heron/pull/2807#issuecomment-390299897 It is more about "why there was a Math.rounding()". The rounding logic doesn't seem necessary if we assume cpu # can be le

[GitHub] nlu90 commented on issue #1093: heron package manager tool

2018-05-18 Thread GitBox
nlu90 commented on issue #1093: heron package manager tool URL: https://github.com/apache/incubator-heron/pull/1093#issuecomment-390290315 Will close this PR for it's opened too long ago and now we have the downloaders spi. T

[GitHub] nlu90 closed pull request #1093: heron package manager tool

2018-05-18 Thread GitBox
nlu90 closed pull request #1093: heron package manager tool URL: https://github.com/apache/incubator-heron/pull/1093 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

[GitHub] nlu90 commented on issue #2794: update container count to 2 in the example ExclamationTopology

2018-05-18 Thread GitBox
nlu90 commented on issue #2794: update container count to 2 in the example ExclamationTopology URL: https://github.com/apache/incubator-heron/pull/2794#issuecomment-390289767 @kramasamy @nwangtw @huijunw Any ideas on this PR?

[GitHub] nlu90 commented on issue #2807: remove three other roundings in cpu calculation

2018-05-18 Thread GitBox
nlu90 commented on issue #2807: remove three other roundings in cpu calculation URL: https://github.com/apache/incubator-heron/pull/2807#issuecomment-390288719 What's the background of removing this `Math.rounding()`? This is

[GitHub] nlu90 commented on issue #2850: Add SSL support for stream manager connections

2018-05-18 Thread GitBox
nlu90 commented on issue #2850: Add SSL support for stream manager connections URL: https://github.com/apache/incubator-heron/pull/2850#issuecomment-390287634 @ajorgensen seems several unit tests failed. Could you update it and for a further review?

[GitHub] nlu90 commented on issue #2691: Fix for localhost metrics manager

2018-05-18 Thread GitBox
nlu90 commented on issue #2691: Fix for localhost metrics manager URL: https://github.com/apache/incubator-heron/pull/2691#issuecomment-390286652 @jrcrawfo Ping for this PR, any updates? This is an automated message from the A

[GitHub] nlu90 closed pull request #2872: read merge instructions;

2018-05-18 Thread GitBox
nlu90 closed pull request #2872: read merge instructions; URL: https://github.com/apache/incubator-heron/pull/2872 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] nlu90 closed pull request #2902: Make MetricsManager.java a target so that it can be customized

2018-05-18 Thread GitBox
nlu90 closed pull request #2902: Make MetricsManager.java a target so that it can be customized URL: https://github.com/apache/incubator-heron/pull/2902 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] nlu90 commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-18 Thread GitBox
nlu90 commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390284998 @bornej It is possible to utilizing multithreads in Heron even without this patch. The only requirement is that you need to ack/fail the pro

[GitHub] bornej commented on issue #2692: Making emit, ack, and fail thread safe

2018-05-18 Thread GitBox
bornej commented on issue #2692: Making emit, ack, and fail thread safe URL: https://github.com/apache/incubator-heron/pull/2692#issuecomment-390241133 Hi, while investigating the possibility of using multi-threaded bolt/spouts, I stumbled upon this PR. I don't know if this is the ap

[GitHub] nlu90 closed pull request #2903: cleaning setup scripts for removed directories

2018-05-17 Thread GitBox
nlu90 closed pull request #2903: cleaning setup scripts for removed directories URL: https://github.com/apache/incubator-heron/pull/2903 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] nlu90 closed pull request #2901: Refactor CheckpointManager to move initialization code out of constru…

2018-05-17 Thread GitBox
nlu90 closed pull request #2901: Refactor CheckpointManager to move initialization code out of constru… URL: https://github.com/apache/incubator-heron/pull/2901 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] nlu90 opened a new pull request #2903: cleaning removed directory for setup scripts

2018-05-17 Thread GitBox
nlu90 opened a new pull request #2903: cleaning removed directory for setup scripts URL: https://github.com/apache/incubator-heron/pull/2903 Two directories are removed from the project but the paths are not updated accordingly in the setup scripts. And causing the following warning:

[GitHub] nlu90 closed pull request #2870: Add extra info when failed to create new instance of class

2018-05-17 Thread GitBox
nlu90 closed pull request #2870: Add extra info when failed to create new instance of class URL: https://github.com/apache/incubator-heron/pull/2870 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] nlu90 commented on issue #2900: Fix Potential Double Delete Bug

2018-05-17 Thread GitBox
nlu90 commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389960209 There's some code style problem. Please fix it before we can merge it. ``` heron/common/src/cpp/network/connection.cpp:65: Line ends in white

[GitHub] kramasamy commented on issue #2900: Fix Potential Double Delete Bug

2018-05-17 Thread GitBox
kramasamy commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389922301 We can merge it Sent from my iPhone > On May 17, 2018, at 7:54 AM, Andrew Jorgensen wrote: > > It's an improvement I thin

[GitHub] ajorgensen commented on issue #2900: Fix Potential Double Delete Bug

2018-05-17 Thread GitBox
ajorgensen commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389895629 It's an improvement I think since there is a potential for a double free bug here if packets fail to send but I haven't seen a crash in produc

[GitHub] ajorgensen commented on issue #2900: Fix Potential Double Delete Bug

2018-05-17 Thread GitBox
ajorgensen commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389895629 It's an improvement I think since there is a potential for a double free bug here if packets fail to send but I haven't seen a crash in produc

[GitHub] kramasamy closed pull request #2898: add documentation about nomad consul integration

2018-05-17 Thread GitBox
kramasamy closed pull request #2898: add documentation about nomad consul integration URL: https://github.com/apache/incubator-heron/pull/2898 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] kramasamy commented on issue #2900: Fix Potential Double Delete Bug

2018-05-17 Thread GitBox
kramasamy commented on issue #2900: Fix Potential Double Delete Bug URL: https://github.com/apache/incubator-heron/pull/2900#issuecomment-389892414 @ajorgensen - is this still an issue? This is an automated message from the Ap

[GitHub] nwangtw opened a new pull request #2902: Make MetricsManager.java a target so that it can be customized

2018-05-16 Thread GitBox
nwangtw opened a new pull request #2902: Make MetricsManager.java a target so that it can be customized URL: https://github.com/apache/incubator-heron/pull/2902 This is an automated message from the Apache Git Service. To re

[GitHub] nwangtw opened a new pull request #2901: Refactor CheckpointManager to move initialization code out of constru…

2018-05-16 Thread GitBox
nwangtw opened a new pull request #2901: Refactor CheckpointManager to move initialization code out of constru… URL: https://github.com/apache/incubator-heron/pull/2901 …ctor This is an automated message from the Apache Git S

[GitHub] ajorgensen closed issue #2897: Potential double free crash in BaseConnection destructor on 0.17.8

2018-05-16 Thread GitBox
ajorgensen closed issue #2897: Potential double free crash in BaseConnection destructor on 0.17.8 URL: https://github.com/apache/incubator-heron/issues/2897 This is an automated message from the Apache Git Service. To respon

[GitHub] ajorgensen commented on issue #2897: Potential double free crash in BaseConnection destructor on 0.17.8

2018-05-16 Thread GitBox
ajorgensen commented on issue #2897: Potential double free crash in BaseConnection destructor on 0.17.8 URL: https://github.com/apache/incubator-heron/issues/2897#issuecomment-389599966 This was my mistake. This is an automa

[GitHub] ajorgensen opened a new pull request #2900: Fix Stream Manager Crash

2018-05-16 Thread GitBox
ajorgensen opened a new pull request #2900: Fix Stream Manager Crash URL: https://github.com/apache/incubator-heron/pull/2900 This fixes https://github.com/apache/incubator-heron/issues/2897 which is a double free bug that periodically causes the stream manager to crash if other stream man

[GitHub] huijunwu commented on issue #2880: Redirect gitbox commits to commits@

2018-05-14 Thread GitBox
huijunwu commented on issue #2880: Redirect gitbox commits to commits@ URL: https://github.com/apache/incubator-heron/issues/2880#issuecomment-389036496 gitbox commits(when the PRs are merged) are to commits@ already. I think this Issue is: disable the PR/Issues comments email

[GitHub] huijunwu commented on issue #2880: Redirect gitbox commits to commits@

2018-05-14 Thread GitBox
huijunwu commented on issue #2880: Redirect gitbox commits to commits@ URL: https://github.com/apache/incubator-heron/issues/2880#issuecomment-389036496 gitbox commits(when the PRs are merged) are to commits@ already. I think this Issue is: disable the PR comments email notification

[GitHub] huijunwu closed pull request #2899: add src export target for downloader

2018-05-14 Thread GitBox
huijunwu closed pull request #2899: add src export target for downloader URL: https://github.com/apache/incubator-heron/pull/2899 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] huijunwu opened a new pull request #2899: add src export target for downloader

2018-05-14 Thread GitBox
huijunwu opened a new pull request #2899: add src export target for downloader URL: https://github.com/apache/incubator-heron/pull/2899 In some environment, the developers would like to develop their own downloaders. This PR exports the downloader src so that they can be included into the

[GitHub] huijunwu commented on issue #2274: Topology package fetcher.

2018-05-11 Thread GitBox
huijunwu commented on issue #2274: Topology package fetcher. URL: https://github.com/apache/incubator-heron/pull/2274#issuecomment-388449226 replaced by #2886. close this pr This is an automated message from the Apache Git Ser

[GitHub] huijunwu closed pull request #2274: Topology package fetcher.

2018-05-11 Thread GitBox
huijunwu closed pull request #2274: Topology package fetcher. URL: https://github.com/apache/incubator-heron/pull/2274 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] nlu90 closed pull request #2886: submit topology file by uri

2018-05-11 Thread GitBox
nlu90 closed pull request #2886: submit topology file by uri URL: https://github.com/apache/incubator-heron/pull/2886 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-11 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187686955 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Informat

[GitHub] nlu90 commented on issue #2852: first of the connectors - twitter spout

2018-05-11 Thread GitBox
nlu90 commented on issue #2852: first of the connectors - twitter spout URL: https://github.com/apache/incubator-heron/pull/2852#issuecomment-388425678 @kramasamy Ping This is an automated message from the Apache Git Service.

[GitHub] joshfischer1108 commented on issue #2898: add documentation about nomad consul integration

2018-05-11 Thread GitBox
joshfischer1108 commented on issue #2898: add documentation about nomad consul integration URL: https://github.com/apache/incubator-heron/pull/2898#issuecomment-388393978 +1 @jerrypeng . Can't wait to try it out. This is

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-11 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187630121 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Informat

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-11 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187540122 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Informat

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-11 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187539899 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,26 @@ message CleanStatefulCheckpointResponse { rep

[GitHub] srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187532107 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Inform

[GitHub] srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187531976 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,26 @@ message CleanStatefulCheckpointResponse { r

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187484567 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,26 @@ message CleanStatefulCheckpointResponse { rep

[GitHub] nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
nwangtw commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187482648 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Informat

[GitHub] srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187466926 ## File path: heron/proto/ckptmgr.proto ## @@ -195,6 +218,9 @@ message SaveInstanceStateRequest { // Inform

[GitHub] srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API

2018-05-10 Thread GitBox
srkukarni commented on a change in pull request #2891: Refactor StatefulStorage API URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r187466788 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,26 @@ message CleanStatefulCheckpointResponse { r

[GitHub] jerrypeng commented on issue #2898: add documentation about nomad consul integration

2018-05-09 Thread GitBox
jerrypeng commented on issue #2898: add documentation about nomad consul integration URL: https://github.com/apache/incubator-heron/pull/2898#issuecomment-387957319 @lucperkins @kramasamy please review This is an automated me

[GitHub] jerrypeng opened a new pull request #2898: add documentation about nomad consul integration

2018-05-09 Thread GitBox
jerrypeng opened a new pull request #2898: add documentation about nomad consul integration URL: https://github.com/apache/incubator-heron/pull/2898 - add documentation about nomad consul integration - fix formating - fix typos

[GitHub] nlu90 closed pull request #2884: move downloader registry map to yaml

2018-05-09 Thread GitBox
nlu90 closed pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ajorgensen closed issue #1253: Provide a logging bridge at runtime

2018-05-09 Thread GitBox
ajorgensen closed issue #1253: Provide a logging bridge at runtime URL: https://github.com/apache/incubator-heron/issues/1253 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] nwangtw commented on issue #2829: Update license text to apache incubator

2018-05-09 Thread GitBox
nwangtw commented on issue #2829: Update license text to apache incubator URL: https://github.com/apache/incubator-heron/issues/2829#issuecomment-387803940 i believe this is done. I have updated all texts I could find. This i

[GitHub] nwangtw closed issue #2829: Update license text to apache incubator

2018-05-09 Thread GitBox
nwangtw closed issue #2829: Update license text to apache incubator URL: https://github.com/apache/incubator-heron/issues/2829 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] huijunwu commented on issue #2884: move downloader registry map to yaml

2018-05-08 Thread GitBox
huijunwu commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387594464 @jerrypeng updated to be compatible with `downloader `. could you review it again ---

[GitHub] tomncooper commented on issue #2875: Duration reporting inconsistency

2018-05-08 Thread GitBox
tomncooper commented on issue #2875: Duration reporting inconsistency URL: https://github.com/apache/incubator-heron/issues/2875#issuecomment-387559852 Duplicate of #2874 This is an automated message from the Apache Git Serv

[GitHub] nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout

2018-05-08 Thread GitBox
nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout URL: https://github.com/apache/incubator-heron/pull/2852#discussion_r186883119 ## File path: third_party/cereal/BUILD ## @@ -0,0 +1,126 @@ +licenses(["notice"]) Review comment:

[GitHub] nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout

2018-05-08 Thread GitBox
nlu90 commented on a change in pull request #2852: first of the connectors - twitter spout URL: https://github.com/apache/incubator-heron/pull/2852#discussion_r186883787 ## File path: connectors/heron-twitter/src/java/com/twitter/heron/twitter/spout/Twitter.java ## @@ -0,

[GitHub] nlu90 closed issue #2877: Compilation error in a container

2018-05-08 Thread GitBox
nlu90 closed issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] nlu90 closed issue #2890: YAML cpp noboost deprecated

2018-05-08 Thread GitBox
nlu90 closed issue #2890: YAML cpp noboost deprecated URL: https://github.com/apache/incubator-heron/issues/2890 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and us

[GitHub] nlu90 commented on issue #2877: Compilation error in a container

2018-05-08 Thread GitBox
nlu90 commented on issue #2877: Compilation error in a container URL: https://github.com/apache/incubator-heron/issues/2877#issuecomment-387558212 @comes5 In short, Yes. You'll need to build the whole project to get the core jars for testing. But since bazel is smart enough to do the incre

[GitHub] ajorgensen opened a new issue #2897: Potential double free crash in BaseConnection destructor

2018-05-08 Thread GitBox
ajorgensen opened a new issue #2897: Potential double free crash in BaseConnection destructor URL: https://github.com/apache/incubator-heron/issues/2897 On version `0.17.8` it appears that there may be a double free error that causes a stream manager to crash sometimes in the destructor fo

[GitHub] skanjila opened a new issue #2896: Design of streaming machine learning algorithms in heron

2018-05-08 Thread GitBox
skanjila opened a new issue #2896: Design of streaming machine learning algorithms in heron URL: https://github.com/apache/incubator-heron/issues/2896 The goal of this effort is to design and document streaming real time machine learning algorithms that can fit into a storm topology and ev

[GitHub] kramasamy closed pull request #2895: Nwang/update license in other files

2018-05-08 Thread GitBox
kramasamy closed pull request #2895: Nwang/update license in other files URL: https://github.com/apache/incubator-heron/pull/2895 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] kramasamy closed pull request #2894: fixing test

2018-05-07 Thread GitBox
kramasamy closed pull request #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a f

[GitHub] nwangtw commented on issue #2894: fixing test

2018-05-07 Thread GitBox
nwangtw commented on issue #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894#issuecomment-387294614 @kramasamy I would think so. This is an automated message from the Apache Git Service. To respond to

[GitHub] nwangtw commented on a change in pull request #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
nwangtw commented on a change in pull request #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#discussion_r186623390 ## File path: heron/downloaders/src/java/org/apache/heron/downloader/DownloadRunner.java ## @@ -18,17 +

[GitHub] kramasamy closed pull request #2876: Refactoring Nomad documentation and add documentation on running heron via docker on Nomad

2018-05-07 Thread GitBox
kramasamy closed pull request #2876: Refactoring Nomad documentation and add documentation on running heron via docker on Nomad URL: https://github.com/apache/incubator-heron/pull/2876 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displaye

[GitHub] nwangtw opened a new pull request #2895: Nwang/update license in other files

2018-05-07 Thread GitBox
nwangtw opened a new pull request #2895: Nwang/update license in other files URL: https://github.com/apache/incubator-heron/pull/2895 all other files I can find This is an automated message from the Apache Git Service. To resp

[GitHub] kramasamy commented on issue #2894: fixing test

2018-05-07 Thread GitBox
kramasamy commented on issue #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894#issuecomment-387275067 @joshfischer1108 - ready to merge? This is an automated message from the Apache Git Service. To re

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387250611 @huijunwu my concern is that it will break existing code that assume the format for the downloader is ``` downloader ```

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387250611 @huijunwu my concern is that it will break existing code that assume the format for the downloader is ``` downloader ```

[GitHub] huijunwu commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
huijunwu commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387241747 @jerrypeng 1. The current Downloader hard-code the registry map, which is not extendable. 2. The Downloader should work in a similar

[GitHub] joshfischer1108 commented on issue #2894: fixing test

2018-05-07 Thread GitBox
joshfischer1108 commented on issue #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894#issuecomment-387156035 Just kicked it off again 😐 This is an automated message from the Apache Git Service. To res

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to potentially pass in a cluster mode, heron home path, c

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to pass in a cluster mode or config path because we have

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387153148 I feel the changes have made the downloader a lot more complicated. Now we have to pass in a cluster mode or config path because we have

[GitHub] jerrypeng commented on issue #2884: move downloader registry map to yaml

2018-05-07 Thread GitBox
jerrypeng commented on issue #2884: move downloader registry map to yaml URL: https://github.com/apache/incubator-heron/pull/2884#issuecomment-387148313 So the arguments are changed for the downloader right? Won't this break existing usages of the downloader. Heron standalone/nomad calls

[GitHub] nwangtw commented on issue #2894: fixing test

2018-05-07 Thread GitBox
nwangtw commented on issue #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894#issuecomment-387137205 "(15:41:38) ERROR: build interrupted". :p This is an automated message from the Apache Git Service.

[GitHub] joshfischer1108 closed pull request #2892: fixing eco parser test

2018-05-07 Thread GitBox
joshfischer1108 closed pull request #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] joshfischer1108 opened a new pull request #2894: fixing test

2018-05-07 Thread GitBox
joshfischer1108 opened a new pull request #2894: fixing test URL: https://github.com/apache/incubator-heron/pull/2894 @nwangtw Lets try this one. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] joshfischer1108 commented on issue #2892: fixing eco parser test

2018-05-07 Thread GitBox
joshfischer1108 commented on issue #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#issuecomment-387101604 @nwangtw Can you look at this CI error please? I'm not sure where this is coming from. -

[GitHub] joshfischer1108 commented on issue #2892: fixing eco parser test

2018-05-07 Thread GitBox
joshfischer1108 commented on issue #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#issuecomment-387085922 @nwangtw Didn't realize I had the permissions to restart build. I don't think I did when Heron was in Twitter repo. Just restarted it. Thanks

[GitHub] nwangtw commented on issue #2892: fixing eco parser test

2018-05-07 Thread GitBox
nwangtw commented on issue #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#issuecomment-387083443 Looks like integration test failed. Need to retrigger travis. This is an automated messag

[GitHub] nwangtw commented on issue #2890: YAML cpp noboost deprecated

2018-05-07 Thread GitBox
nwangtw commented on issue #2890: YAML cpp noboost deprecated URL: https://github.com/apache/incubator-heron/issues/2890#issuecomment-386988477 Related PR: https://github.com/apache/incubator-heron/pull/2893/files This is

[GitHub] nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage

2018-05-07 Thread GitBox
nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r186349909 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,25 @@ message CleanStatefulCheckpointResponse { r

[GitHub] kramasamy closed pull request #2893: pull yaml cpp for official release page

2018-05-06 Thread GitBox
kramasamy closed pull request #2893: pull yaml cpp for official release page URL: https://github.com/apache/incubator-heron/pull/2893 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] kramasamy opened a new pull request #2893: pull yaml cpp for official release page

2018-05-05 Thread GitBox
kramasamy opened a new pull request #2893: pull yaml cpp for official release page URL: https://github.com/apache/incubator-heron/pull/2893 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] joshfischer1108 commented on issue #2892: fixing eco parser test

2018-05-05 Thread GitBox
joshfischer1108 commented on issue #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#issuecomment-386822849 @kramasamy Once master build is fixed I will merge in those changes This is an a

[GitHub] joshfischer1108 commented on a change in pull request #2892: fixing eco parser test

2018-05-05 Thread GitBox
joshfischer1108 commented on a change in pull request #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#discussion_r186265179 ## File path: eco/tests/java/org/apache/heron/eco/parser/EcoParserTest.java ## @@ -33,17 +140,17 @@ + "

[GitHub] nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage

2018-05-05 Thread GitBox
nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r186255125 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,25 @@ message CleanStatefulCheckpointResponse { r

[GitHub] nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage

2018-05-05 Thread GitBox
nwangtw commented on a change in pull request #2891: [WIP] Refactor StatefulStorage URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r186254929 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,25 @@ message CleanStatefulCheckpointResponse { r

[GitHub] srkukarni commented on a change in pull request #2891: [WIP] Refactor StatefulStorage

2018-05-04 Thread GitBox
srkukarni commented on a change in pull request #2891: [WIP] Refactor StatefulStorage URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r186254708 ## File path: heron/proto/ckptmgr.proto ## @@ -171,7 +175,25 @@ message CleanStatefulCheckpointResponse {

[GitHub] kramasamy commented on a change in pull request #2892: fixing eco parser test

2018-05-04 Thread GitBox
kramasamy commented on a change in pull request #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#discussion_r186253428 ## File path: eco/tests/java/org/apache/heron/eco/parser/EcoParserTest.java ## @@ -33,17 +140,17 @@ + "# spout

[GitHub] kramasamy commented on a change in pull request #2892: fixing eco parser test

2018-05-04 Thread GitBox
kramasamy commented on a change in pull request #2892: fixing eco parser test URL: https://github.com/apache/incubator-heron/pull/2892#discussion_r186253432 ## File path: eco/tests/java/org/apache/heron/eco/parser/EcoParserTest.java ## @@ -33,17 +140,17 @@ + "# spout

  1   2   3   4   5   >