Re: patch review process

On Jan 20, 2011, at 10:53 PM, Namit Jain wrote: > > As good practice, also copy important review comments in the jira, so that > they are searchable and give enough context to a new contributor. The old review board instance did this automatically. Todd has an INFRA JIRA open to get this for

Re: patch review process

I was thinking about it. Let us do the following: For big patches (a big patch is one which involves changing more than 10 files - those files can be test/code changes or even generated files), reviewBoard is mandatory. For smaller patches, reviewBoard is optional. However, if any reviewer asks f

[jira] Updated: (HIVE-1872) Hive process is exiting on executing ALTER query

[ https://issues.apache.org/jira/browse/HIVE-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath R updated HIVE-1872: - Release Note: Avoiding System.exit () for killing the MR Process , instead kill the task ( which are not r

[jira] Updated: (HIVE-1872) Hive process is exiting on executing ALTER query

[ https://issues.apache.org/jira/browse/HIVE-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath R updated HIVE-1872: - Attachment: HIVE-1872.1.patch > Hive process is exiting on executing ALTER query > ---

[jira] Commented: (HIVE-1918) Add export/import facilities to the hive system

[ https://issues.apache.org/jira/browse/HIVE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984563#action_12984563 ] Krishna Kumar commented on HIVE-1918: - Why export/import needs this change: It is not th

Review Request: HIVE-1910: Provide config parameters to control cache object pinning

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/343/ --- Review request for hive. Summary --- Review for HIVE-1910 This addresses b

[jira] Updated: (HIVE-1910) Provide config parameters to control cache object pinning

[ https://issues.apache.org/jira/browse/HIVE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mac Yang updated HIVE-1910: --- Status: Patch Available (was: Open) https://reviews.apache.org/r/343/ > Provide config parameters to control

[jira] Updated: (HIVE-1910) Provide config parameters to control cache object pinning

[ https://issues.apache.org/jira/browse/HIVE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mac Yang updated HIVE-1910: --- Summary: Provide config parameters to control cache object pinning (was: Provide config parameters to control

[jira] Updated: (HIVE-1910) Provide config parameters to control cache object pining

[ https://issues.apache.org/jira/browse/HIVE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mac Yang updated HIVE-1910: --- Attachment: HIVE-1910.1.patch.txt This enhancement is more relevant to metastore running in thrift server mode

[jira] Updated: (HIVE-1920) DESCRIBE with comments is difficult to read

[ https://issues.apache.org/jira/browse/HIVE-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Yang updated HIVE-1920: Attachment: HIVE-1920.1.nocomment.patch One possible way to address this is to add a nocomment option to des

Re: patch review process

On Thu, Jan 20, 2011 at 5:56 PM, Namit Jain wrote: > I agree on the problem of comments. > For a new reviewer, it makes the process more painful. > > But, I think, the issues are not major, and we should > decide one approach or another. > > Even for option 2., we can make it mandatory for the con

Re: patch review process

I agree on the problem of comments. For a new reviewer, it makes the process more painful. But, I think, the issues are not major, and we should decide one approach or another. Even for option 2., we can make it mandatory for the contributor to submit a reviewboard request if the reviewer asks fo

Re: patch review process

I would argue that how to do the review has nothing to do with code quality. No review board has no connection with low quality code. The review board just provides a limited view of the diff's context. So if the review is familiar with the diff's context and is confident with the patch, it is his

[jira] Commented: (HIVE-1817) Remove Hive dependency on unrelease commons-cli 2.0 Snapshot

[ https://issues.apache.org/jira/browse/HIVE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984400#action_12984400 ] Edward Capriolo commented on HIVE-1817: --- Arge. This is a major buzzkill, our shims, bu

Re: patch review process

On Thu, Jan 20, 2011 at 12:12 PM, John Sichi wrote: > +1 on option 1. This is standard operating practice (for all code changes, > no exceptions) at Facebook, Google, and many other companies that care about > code quality. > > (The latest HBase wiki makes an exception for patches that only invo

Re: patch review process

+1 on option 1. This is standard operating practice (for all code changes, no exceptions) at Facebook, Google, and many other companies that care about code quality. (The latest HBase wiki makes an exception for patches that only involve one changed+unreviewed file, but I think that creates

[jira] Commented: (HIVE-1918) Add export/import facilities to the hive system

[ https://issues.apache.org/jira/browse/HIVE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984348#action_12984348 ] Edward Capriolo commented on HIVE-1918: --- I was not implying that we should definately

Re: Build failed in Hudson: Hive-trunk-h0.20 #500

I checked the console output on the failed build. The command that's used to run the tests is 'ant -Dhadoop.version=0.20.0 .'. This probably is the cause of the problem (though I haven't verified locally). Devaraj. On Jan 20, 2011, at 5:26 AM, "Carl Steinbach" wrote: > HIVE-1696 introduced a

Build failed in Hudson: Hive-trunk-h0.20 #501

See -- [...truncated 7224 lines...] create-dirs: init: compile: [echo] Compiling: anttasks [javac] :40: war

Re: Build failed in Hudson: Hive-trunk-h0.20 #500

HIVE-1696 introduced a build failure: Running org.apache.hadoop.hive.thrift.TestHadoop20SAuthBridge java.lang.NoSuchMethodError: org.apache.hadoop.security.UserGroupInformation.getCurrentUser()Lorg/apache/hadoop/security/UserGroupInformation; This looks like a straightforward classpath problem (p

Build failed in Hudson: Hive-trunk-h0.20 #500

See -- [...truncated 7224 lines...] create-dirs: init: compile: [echo] Compiling: anttasks [javac] :40: war

[jira] Created: (HIVE-1922) semantic analysis error, when using group by and order by together

semantic analysis error, when using group by and order by together -- Key: HIVE-1922 URL: https://issues.apache.org/jira/browse/HIVE-1922 Project: Hive Issue Type: Bug

[jira] Commented: (HIVE-1918) Add export/import facilities to the hive system

[ https://issues.apache.org/jira/browse/HIVE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984132#action_12984132 ] Carl Steinbach commented on HIVE-1918: -- Review request: https://reviews.apache.org/r/33

Review Request: HIVE-1918: Add export/import facilities to the hive system

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/339/ --- Review request for hive. Summary --- Review for HIVE-1918. This addresses

[jira] Commented: (HIVE-1918) Add export/import facilities to the hive system

[ https://issues.apache.org/jira/browse/HIVE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984128#action_12984128 ] Krishna Kumar commented on HIVE-1918: - Ok. Will take of this via a delegating ctor. A p

[jira] Updated: (HIVE-1636) Implement "SHOW TABLES {FROM | IN} db_name"

[ https://issues.apache.org/jira/browse/HIVE-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Steinbach updated HIVE-1636: - Status: Open (was: Patch Available) I left some comments on reviewboard. Thanks. > Implement "SH

Re: Review Request: HIVE-1636: Implement "SHOW TABLES {FROM | IN} db_name"

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/323/#review145 --- ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java