Re: Review Request 65342: HIVE-18546

2018-02-01 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65342/#review196692 --- ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java Line 5127

Re: Review Request 65342: HIVE-18546

2018-02-01 Thread Ashutosh Chauhan
> On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 1238 (patched) > > > > > > If its a MV, all metadata related t

[jira] [Created] (HIVE-18611) Avoid memory allocation of aggregation buffer during stats computation

2018-02-01 Thread Ashutosh Chauhan (JIRA)
Ashutosh Chauhan created HIVE-18611: --- Summary: Avoid memory allocation of aggregation buffer during stats computation Key: HIVE-18611 URL: https://issues.apache.org/jira/browse/HIVE-18611 Project:

[GitHub] hive pull request #304: HIVE-18581: Replication events should use lower case...

2018-02-01 Thread anishek
Github user anishek closed the pull request at: https://github.com/apache/hive/pull/304 ---

[jira] [Created] (HIVE-18610) Performance: ListKeyWrapper does not check for hashcode equals, before comparing members

2018-02-01 Thread Gopal V (JIRA)
Gopal V created HIVE-18610: -- Summary: Performance: ListKeyWrapper does not check for hashcode equals, before comparing members Key: HIVE-18610 URL: https://issues.apache.org/jira/browse/HIVE-18610 Project: H

Re: Yetus JDK version

2018-02-01 Thread Thejas Nair
+ Peter, Adam (The Yetus experts) On Thu, Feb 1, 2018 at 9:49 AM, Alan Gates wrote: > Ok, looking briefly at it, it looks like if we changed > testutils/…/TestScripts.java line 76 to set javaHome to 1.8 instead of 1.7 > that we’ll be running ptest with 1.8. I’m not familiar with ptest, but I’m

Re: Intellij + Checkstyle setup

2018-02-01 Thread Vineet Garg
Hi Vihang, I am unable to import eclipse-styles.xml. I am using IntelliJ 2017.3 with Checkstyle 8.7. May be you are using different version? Vineet > On Feb 1, 2018, at 5:58 PM, Vihang Karajgaonkar wrote: > > Thanks for sharing Vineet. How is this different than > https://github.com/apache/hi

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/#review196680 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Feb. 2, 2018,

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jesús Camacho Rodríguez
> On Jan. 29, 2018, 6:26 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java > > Lines 174 (patched) > > > > > > What happens if execution fails? Will t

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/ --- (Updated Feb. 2, 2018, 2:18 a.m.) Review request for hive, Ashutosh Chauhan, Go

[jira] [Created] (HIVE-18609) Results cache invalidation based on table updates

2018-02-01 Thread Jason Dere (JIRA)
Jason Dere created HIVE-18609: - Summary: Results cache invalidation based on table updates Key: HIVE-18609 URL: https://issues.apache.org/jira/browse/HIVE-18609 Project: Hive Issue Type: Sub-task

Re: Intellij + Checkstyle setup

2018-02-01 Thread Vihang Karajgaonkar
Thanks for sharing Vineet. How is this different than https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml I was able to import this in IntelliJ just fine. On Thu, Feb 1, 2018 at 4:42 PM, Vineet Garg wrote: > Hi, > > If you would like to use Intellij’s checkstyle plugin an

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/ --- (Updated Feb. 2, 2018, 1:55 a.m.) Review request for hive, Ashutosh Chauhan, Go

[jira] [Created] (HIVE-18608) ORC should allow selectively disabling dictionary-encoding on specified columns

2018-02-01 Thread Mithun Radhakrishnan (JIRA)
Mithun Radhakrishnan created HIVE-18608: --- Summary: ORC should allow selectively disabling dictionary-encoding on specified columns Key: HIVE-18608 URL: https://issues.apache.org/jira/browse/HIVE-18608

Re: Review Request 65342: HIVE-18546

2018-02-01 Thread Jesús Camacho Rodríguez
> On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 1238 (patched) > > > > > > If its a MV, all metadata related t

Re: Review Request 65342: HIVE-18546

2018-02-01 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65342/#review196673 --- standalone-metastore/src/main/java/org/apache/hadoop/hive/metasto

Intellij + Checkstyle setup

2018-02-01 Thread Vineet Garg
Hi, If you would like to use Intellij’s checkstyle plugin and are unable to import current checkstyle.xml under HIVE_REPO/checkstyle.xml file use a modified version located at: https://github.com/vineetgarg02/misc/blob/master/hive_tools/checkstyle.xml Current format seems to be unsupported with

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 2, 2018, 12:38 a.m.) Review request for hive, Eugene Koifman, Gop

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 2, 2018, 12:24 a.m.) Review request for hive, Eugene Koifman, Gop

[jira] [Created] (HIVE-18607) HBase HFile write does strange things

2018-02-01 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18607: --- Summary: HBase HFile write does strange things Key: HIVE-18607 URL: https://issues.apache.org/jira/browse/HIVE-18607 Project: Hive Issue Type: Bug

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196659 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVer

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jason Dere
> On Jan. 29, 2018, 6:26 p.m., Jesús Camacho Rodríguez wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3699 (patched) > > > > > > Is this the permission for each results directory? Doe

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/#review196654 --- standalone-metastore/src/main/thrift/hive_metastore.thrift Line 3

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 1, 2018, 8:49 p.m.) Review request for hive, Eugene Koifman, Gopa

Re: Review Request 65304: HIVE-18513 Query results caching

2018-02-01 Thread Jesús Camacho Rodríguez
> On Jan. 29, 2018, 6:26 p.m., Jesús Camacho Rodríguez wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 3699 (patched) > > > > > > Is this the permission for each results directory? Doe

[jira] [Created] (HIVE-18606) CTAS on empty table throws NPE from org.apache.hadoop.hive.ql.exec.MoveTask

2018-02-01 Thread Eugene Koifman (JIRA)
Eugene Koifman created HIVE-18606: - Summary: CTAS on empty table throws NPE from org.apache.hadoop.hive.ql.exec.MoveTask Key: HIVE-18606 URL: https://issues.apache.org/jira/browse/HIVE-18606 Project:

Re: Review Request 65130: HIVE-18350 : load data should rename files consistent with insert statements

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65130/ --- (Updated Feb. 1, 2018, 7:24 p.m.) Review request for hive, Eugene Koifman, Gopa

[jira] [Created] (HIVE-18605) text and int compares can produce surprising results

2018-02-01 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18605: --- Summary: text and int compares can produce surprising results Key: HIVE-18605 URL: https://issues.apache.org/jira/browse/HIVE-18605 Project: Hive Issue

Re: Review Request 65276: HIVE-18516

2018-02-01 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- (Updated Feb. 1, 2018, 7:10 p.m.) Review request for hive, Eugene Koifman and J

Re: Build bot comments in Jira

2018-02-01 Thread Eugene Koifman
This is great. Thank you! On 2/1/18, 3:18 AM, "Adam Szita" wrote: Hi, I can recommend using this Chrome extension: https://github.com/gezapeti/jira-comment-collapser. It was developed by a colleague of ours who's working on Oozie. It can also be found in the store:

Re: Yetus JDK version

2018-02-01 Thread Alan Gates
Ok, looking briefly at it, it looks like if we changed testutils/…/TestScripts.java line 76 to set javaHome to 1.8 instead of 1.7 that we’ll be running ptest with 1.8. I’m not familiar with ptest, but I’m guessing that someone would need to make this change and then re-deploy ptest in our test inf

Re: Review Request 65271: JDBC: Provide a way for JDBC users to pass cookie info via connection string

2018-02-01 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65271/#review196636 --- jdbc/src/java/org/apache/hive/jdbc/HttpRequestInterceptorBase.jav

[jira] [Created] (HIVE-18604) DropDatabase cascade fails when there is an index in the DB

2018-02-01 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18604: - Summary: DropDatabase cascade fails when there is an index in the DB Key: HIVE-18604 URL: https://issues.apache.org/jira/browse/HIVE-18604 Project: Hive Issue Typ

[jira] [Created] (HIVE-18603) Use Hash For Partition HDFS File Path

2018-02-01 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18603: -- Summary: Use Hash For Partition HDFS File Path Key: HIVE-18603 URL: https://issues.apache.org/jira/browse/HIVE-18603 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-18602) Implement Partition By Hash Index

2018-02-01 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18602: -- Summary: Implement Partition By Hash Index Key: HIVE-18602 URL: https://issues.apache.org/jira/browse/HIVE-18602 Project: Hive Issue Type: New Feature

IMetaStoreClient.getPartitionsByNames is not case insensitive on names

2018-02-01 Thread Adam Szita
Hi all, While testing the HMS API, we've found that the col name part of partition names provided to IMetaStoreClient.getPartitionsByNames method are not handled in a case insensitive matter. See related test here: https://github.com/apache/hive/blob/master/standalone-metastore/src/test/java/org/

Re: Build bot comments in Jira

2018-02-01 Thread Adam Szita
Hi, I can recommend using this Chrome extension: https://github.com/gezapeti/jira-comment-collapser. It was developed by a colleague of ours who's working on Oozie. It can also be found in the store: https://chrome.google.com/webstore/search/jira%20comment%20collapser%20gezapeti?hl=en-GB&utm_sourc

[jira] [Created] (HIVE-18601) Support Power platform by updating protoc-jar-maven-plugin version

2018-02-01 Thread Pravin Dsilva (JIRA)
Pravin Dsilva created HIVE-18601: Summary: Support Power platform by updating protoc-jar-maven-plugin version Key: HIVE-18601 URL: https://issues.apache.org/jira/browse/HIVE-18601 Project: Hive

[jira] [Created] (HIVE-18600) Vectorization: Top-Level Vector Expression Scratch Column Deallocation

2018-02-01 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18600: --- Summary: Vectorization: Top-Level Vector Expression Scratch Column Deallocation Key: HIVE-18600 URL: https://issues.apache.org/jira/browse/HIVE-18600 Project: Hive

[GitHub] hive pull request #304: HIVE-18581: Replication events should use lower case...

2018-02-01 Thread anishek
GitHub user anishek opened a pull request: https://github.com/apache/hive/pull/304 HIVE-18581: Replication events should use lower case db object names You can merge this pull request into a Git repository by running: $ git pull https://github.com/anishek/hive HIVE-18581 Alte