[GitHub] hive pull request #350: HIVE-19485 : dump directory for non native tables sh...

GitHub user anishek opened a pull request: https://github.com/apache/hive/pull/350 HIVE-19485 : dump directory for non native tables should not be created You can merge this pull request into a Git repository by running: $ git pull https://github.com/anishek/hive HIVE-19485

[jira] [Created] (HIVE-19569) alter table db1.t1 rename db2.t2 generates MetaStoreEventListener.onDropTable()

Eugene Koifman created HIVE-19569: - Summary: alter table db1.t1 rename db2.t2 generates MetaStoreEventListener.onDropTable() Key: HIVE-19569 URL: https://issues.apache.org/jira/browse/HIVE-19569

Re: [DISCUSS] Unsustainable situation with ptests

Very nice. There was an effort to get fast and green builds back in 2016. There wasn't any strict "must be a green build" before commit at the time though. Instead jiras were filed and the expectation was that they'd be cited / new ones created pre commit(looking at the jiras now - this was likely

Re: [VOTE] Stricter commit guidelines

+1 On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez < jcama...@apache.org> wrote: > After work has been done to ignore most of the tests that were failing > consistently/intermittently [1], I wanted to start this vote to gather > support from the community to be stricter wrt committing

[jira] [Created] (HIVE-19568) Active/Passive HS2 HA: Disallow direct connection to passive HS2 instance

Prasanth Jayachandran created HIVE-19568: Summary: Active/Passive HS2 HA: Disallow direct connection to passive HS2 instance Key: HIVE-19568 URL: https://issues.apache.org/jira/browse/HIVE-19568

Publishing Hive RC artifacts

Hello, I am unable to publish Hive 3.0 RC artifacts to maven. Following wiki page (https://cwiki.apache.org/confluence/display/Hive/HowToRelease#HowToRelease-Voting) I am running following command: mvn deploy -DskipTests -Papache-release -Dmaven.javadoc.skip=true But doing so result in

[jira] [Created] (HIVE-19567) Fix flakiness in TestTriggers

Prasanth Jayachandran created HIVE-19567: Summary: Fix flakiness in TestTriggers Key: HIVE-19567 URL: https://issues.apache.org/jira/browse/HIVE-19567 Project: Hive Issue Type: Bug

[VOTE] Apache Hive 3.0.0 Release Candidate 0

Apache Hive 3.0.0 Release Candidate 0 is available here: http://people.apache.org/~vgarg/apache-hive-3.0.0-rc-0 Tag: https://github.com/apache/hive/tree/release-3.0.0-rc0 Voting will conclude in 72 hours. Hive PMC Members: Please test and vote. Thanks.

Re: [DISCUSS] Unsustainable situation with ptests

Wow! Awesome. This is the 3rd time I remember seeing green run in >4yrs. :) Thanks Prasanth > On May 15, 2018, at 5:28 PM, Jesus Camacho Rodriguez > wrote: > > We have just had the first clean run in a while: >

Re: [DISCUSS] Unsustainable situation with ptests

We have just had the first clean run in a while: https://builds.apache.org/job/PreCommit-HIVE-Build/10971/testReport/ I will continue monitoring follow-up runs. Thanks, -Jesús On 5/14/18, 11:28 PM, "Prasanth Jayachandran" wrote: Wondering if we can add a

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 10, 2018, noon, Sahil Takiar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > > Lines 674 (patched) > > > > > > is this necessary since you set the cluster type to

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/ --- (Updated May 15, 2018, 11:18 p.m.) Review request for hive, Peter Vary, Sahil

Re: [VOTE] Stricter commit guidelines

+1 Default retry on failing test should help. Another way to identify test issues is to run them in the same batch as being run in the precommit job. On Tue, May 15, 2018 at 4:11 PM, Deepak Jaiswal wrote: > +1 > > On 5/15/18, 4:06 PM, "Jesus Camacho Rodriguez"

Re: [VOTE] Stricter commit guidelines

+1 On 5/15/18, 4:06 PM, "Jesus Camacho Rodriguez" wrote: That is already part of the policy although it apparently remained unnoticed: *If a commit introduces new test failures, the preferred process is to revert the patch, rather than opening a new JIRA to

Re: [VOTE] Stricter commit guidelines

That is already part of the policy although it apparently remained unnoticed: *If a commit introduces new test failures, the preferred process is to revert the patch, rather than opening a new JIRA to fix the new failures.* It can be reworded to be stricter... But in any case, we should all

Re: [VOTE] Stricter commit guidelines

+1. Can we also add something about revert-first policy if some patch breaks tests? So that it’s ok to revert if the tests aren’t fixed quickly with a follow-up. On 18/5/15, 13:08, "Jesus Camacho Rodriguez" wrote: >I was hoping that by being stricter, we are going to make

[jira] [Created] (HIVE-19566) Vectorization: Fix NULL / Wrong Results issues in Complex Type Functions

Matt McCline created HIVE-19566: --- Summary: Vectorization: Fix NULL / Wrong Results issues in Complex Type Functions Key: HIVE-19566 URL: https://issues.apache.org/jira/browse/HIVE-19566 Project: Hive

[jira] [Created] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

Matt McCline created HIVE-19565: --- Summary: Vectorization: Fix NULL / Wrong Results issues in STRING Functions Key: HIVE-19565 URL: https://issues.apache.org/jira/browse/HIVE-19565 Project: Hive

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 10, 2018, noon, Sahil Takiar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > > Lines 674 (patched) > > > > > > is this necessary since you set the cluster type to

[jira] [Created] (HIVE-19564) Vectorization: Fix NULL / Wrong Results issues in Functions

Matt McCline created HIVE-19564: --- Summary: Vectorization: Fix NULL / Wrong Results issues in Functions Key: HIVE-19564 URL: https://issues.apache.org/jira/browse/HIVE-19564 Project: Hive

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 14, 2018, 4:57 p.m., Sahil Takiar wrote: > > itests/src/test/resources/testconfiguration.properties > > Line 1693 (original), 1693 (patched) > > > > > > why would we want the ec commands to work outside

Re: Review Request 66862: HIVE-19258 add originals support to MM tables (and make the conversion a metadata only operation)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66862/ --- (Updated May 15, 2018, 9:34 p.m.) Review request for hive and Thejas Nair.

[jira] [Created] (HIVE-19563) Flaky test: TestMiniLlapLocalCliDriver.tez_vector_dynpart_hashjoin_1

Jason Dere created HIVE-19563: - Summary: Flaky test: TestMiniLlapLocalCliDriver.tez_vector_dynpart_hashjoin_1 Key: HIVE-19563 URL: https://issues.apache.org/jira/browse/HIVE-19563 Project: Hive

Re: Review Request 67102: HIVE-19440: Make StorageBasedAuthorizer work with information schema

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67102/ --- (Updated May 15, 2018, 9:04 p.m.) Review request for hive. Repository:

[jira] [Created] (HIVE-19562) Flaky test: TestMiniSparkOnYarn FileNotFoundException in spark-submit

Sahil Takiar created HIVE-19562: --- Summary: Flaky test: TestMiniSparkOnYarn FileNotFoundException in spark-submit Key: HIVE-19562 URL: https://issues.apache.org/jira/browse/HIVE-19562 Project: Hive

[jira] [Created] (HIVE-19561) Update README.md to update requirements for Hadoop

Vineet Garg created HIVE-19561: -- Summary: Update README.md to update requirements for Hadoop Key: HIVE-19561 URL: https://issues.apache.org/jira/browse/HIVE-19561 Project: Hive Issue Type: Task

Review Request 67140: HIVE-19560: Retry test runner and retry rule for flaky tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67140/ --- Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-19560

[jira] [Created] (HIVE-19560) Retry test runner and retry rule for flaky tests

Prasanth Jayachandran created HIVE-19560: Summary: Retry test runner and retry rule for flaky tests Key: HIVE-19560 URL: https://issues.apache.org/jira/browse/HIVE-19560 Project: Hive

[jira] [Created] (HIVE-19559) SparkClientImpl shouldn't name redirector thread "RemoteDriver"

Sahil Takiar created HIVE-19559: --- Summary: SparkClientImpl shouldn't name redirector thread "RemoteDriver" Key: HIVE-19559 URL: https://issues.apache.org/jira/browse/HIVE-19559 Project: Hive

Re: [VOTE] Stricter commit guidelines

I was hoping that by being stricter, we are going to make an effort to fix the flaky tests. The reason is precisely what you mention: if you cannot commit, you need to fix this situation. That is what I meant with providing an additional incentive to make testing more robust: currently there is

Re: [VOTE] Stricter commit guidelines

Can we also define a standard process to identify a flaky test and thereby making it eligible to be disabled? I am worried that the intermittent the flaky ones will stall the patches when we restart allowing the commits. On Tue, May 15, 2018 at 10:50 AM, Vineet Garg wrote:

Re: [VOTE] Stricter commit guidelines

+1 > On May 15, 2018, at 9:13 AM, Alan Gates wrote: > > +1. > > Alan. > > On Tue, May 15, 2018 at 9:12 AM, Sergio Pena > wrote: > >> +1 >> >> On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < >> ghagleit...@hortonworks.com> wrote: >>

Review Request 67138: HIVE-4367 enhance TRUNCATE syntex to drop data of external table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67138/ --- Review request for hive and Teddy Choi. Bugs: HIVE-4367

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 14, 2018, 4:57 p.m., Sahil Takiar wrote: > > itests/src/test/resources/testconfiguration.properties > > Line 1693 (original), 1693 (patched) > > > > > > why would we want the ec commands to work outside

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 10, 2018, noon, Sahil Takiar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > > Lines 674 (patched) > > > > > > is this necessary since you set the cluster type to

[jira] [Created] (HIVE-19558) HiveAuthorizationProviderBase gets catalog name from config rather than db object

Alan Gates created HIVE-19558: - Summary: HiveAuthorizationProviderBase gets catalog name from config rather than db object Key: HIVE-19558 URL: https://issues.apache.org/jira/browse/HIVE-19558 Project:

Re: [VOTE] Stricter commit guidelines

+1. Alan. On Tue, May 15, 2018 at 9:12 AM, Sergio Pena wrote: > +1 > > On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < > ghagleit...@hortonworks.com> wrote: > > > +1 > > > > From: Sankar Hariappan

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 11:05 AM, Gunther Hagleitner < ghagleit...@hortonworks.com> wrote: > +1 > > From: Sankar Hariappan > Sent: Tuesday, May 15, 2018 9:03 AM > To: dev@hive.apache.org > Subject: Re: [VOTE] Stricter

Re: [VOTE] Stricter commit guidelines

+1 From: Sankar Hariappan Sent: Tuesday, May 15, 2018 9:03 AM To: dev@hive.apache.org Subject: Re: [VOTE] Stricter commit guidelines +1 On 15/05/18, 9:30 PM, "Sahil Takiar" wrote: >+1 > >On Tue, May

Re: [VOTE] Stricter commit guidelines

+1 On 15/05/18, 9:30 PM, "Sahil Takiar" wrote: >+1 > >On Tue, May 15, 2018 at 10:56 AM, Owen O'Malley >wrote: > >> +1 >> >> On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: >> >> > +1 - Hoping for something like this for a

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 10:56 AM, Owen O'Malley wrote: > +1 > > On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: > > > +1 - Hoping for something like this for a long while! Thanks for taking > > this up all! > > > > > On May 15, 2018, at 5:44

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 8:55 AM, Peter Vary wrote: > +1 - Hoping for something like this for a long while! Thanks for taking > this up all! > > > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez < > jcama...@apache.org> wrote: > > > > Forgot to mention the length of

Re: [VOTE] Stricter commit guidelines

+1 - Hoping for something like this for a long while! Thanks for taking this up all! > On May 15, 2018, at 5:44 PM, Jesus Camacho Rodriguez > wrote: > > Forgot to mention the length of the vote in original message. > > Let's leave the vote open for a shorter period than

Re: [VOTE] Stricter commit guidelines

Forgot to mention the length of the vote in original message. Let's leave the vote open for a shorter period than usual, for instance 48 hours, i.e., till Wednesday 10pm PST. Situation can only get worse than it is now if we do not take action for a longer period. As Alan suggested, vote

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 2:34 AM Rui Li wrote: > +1 > > On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > > > +1 > > > > > > > > Thanks > > Prasanth > > > > > > > > On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho

[jira] [Created] (HIVE-19557) stats: filters for dates are taking advantage of min/max values

Zoltan Haindrich created HIVE-19557: --- Summary: stats: filters for dates are taking advantage of min/max values Key: HIVE-19557 URL: https://issues.apache.org/jira/browse/HIVE-19557 Project: Hive

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 10, 2018, noon, Sahil Takiar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > > Lines 674 (patched) > > > > > > is this necessary since you set the cluster type to

Re: Review Request 67023: HIVE-18117: Add a new Test Driver "TestErasureCodingHDFSCliDriver" that can be used to run tests over hdfs directories that employ Erasure Coding.

> On May 14, 2018, 4:57 p.m., Sahil Takiar wrote: > > itests/src/test/resources/testconfiguration.properties > > Line 1693 (original), 1693 (patched) > > > > > > why would we want the ec commands to work outside

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review203121 --- Ship it! +1 pending tests - Peter Vary On May 14, 2018,

Re: Review Request 67126: HIVE-19326: stats auto gather: incorrect aggregation during UNION queries (may lead to incorrect results)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67126/#review203111 ---

Review Request 67126: HIVE-19326: stats auto gather: incorrect aggregation during UNION queries (may lead to incorrect results)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67126/ --- Review request for hive, Ashutosh Chauhan and Sergey Shelukhin. Bugs:

Re: [VOTE] Stricter commit guidelines

+1 On Tue, May 15, 2018 at 2:24 PM, Prasanth Jayachandran < pjayachand...@hortonworks.com> wrote: > +1 > > > > Thanks > Prasanth > > > > On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" < > jcama...@apache.org> wrote: > > > After work has been done to

[jira] [Created] (HIVE-19556) Ability to alter mapreduce job's name using hive config

Kartik Bhatia created HIVE-19556: Summary: Ability to alter mapreduce job's name using hive config Key: HIVE-19556 URL: https://issues.apache.org/jira/browse/HIVE-19556 Project: Hive Issue

Re: [DISCUSS] Unsustainable situation with ptests

Wondering if we can add a state transition from “Patch Available” to “Ready To Commit” which can only be triggered by ptest bot on green test run. Thanks Prasanth On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" > wrote: I

Re: [VOTE] Stricter commit guidelines

+1 Thanks Prasanth On Mon, May 14, 2018 at 10:44 PM -0700, "Jesus Camacho Rodriguez" > wrote: After work has been done to ignore most of the tests that were failing consistently/intermittently [1], I wanted to start this vote to gather

Re: [VOTE] Stricter commit guidelines

+1 On Mon, May 14, 2018 at 10:44 PM, Jesus Camacho Rodriguez wrote: > After work has been done to ignore most of the tests that were failing > consistently/intermittently [1], I wanted to start this vote to gather > support from the community to be stricter wrt committing