Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

2020-05-18 Thread Karen Coppage via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/ --- (Updated May 19, 2020, 5:58 a.m.) Review request for hive, Laszlo Pinter and

Re: Review Request 72511: HIVE-23491

2020-05-18 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/ --- (Updated May 19, 2020, 4:42 a.m.) Review request for hive, Jesús Camacho

[jira] [Created] (HIVE-23499) REPL: repl load should honor "hive.repl.dump.metadata.only=true"

2020-05-18 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-23499: --- Summary: REPL: repl load should honor "hive.repl.dump.metadata.only=true" Key: HIVE-23499 URL: https://issues.apache.org/jira/browse/HIVE-23499 Project: Hive

[jira] [Created] (HIVE-23498) Disable HTTP Trace method on ThriftServer

2020-05-18 Thread Rajkumar Singh (Jira)
Rajkumar Singh created HIVE-23498: - Summary: Disable HTTP Trace method on ThriftServer Key: HIVE-23498 URL: https://issues.apache.org/jira/browse/HIVE-23498 Project: Hive Issue Type: Bug

Re: Review Request 72526: HIVE-23493

2020-05-18 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72526/#review220811 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines

[jira] [Created] (HIVE-23497) Change RexNodeExprFactory so it doesn't instantiate a factory every call

2020-05-18 Thread Steve Carlin (Jira)
Steve Carlin created HIVE-23497: --- Summary: Change RexNodeExprFactory so it doesn't instantiate a factory every call Key: HIVE-23497 URL: https://issues.apache.org/jira/browse/HIVE-23497 Project: Hive

[jira] [Created] (HIVE-23496) Add a flag to disable DB scan during Hive Server startup

2020-05-18 Thread David Rabinowitz (Jira)
David Rabinowitz created HIVE-23496: --- Summary: Add a flag to disable DB scan during Hive Server startup Key: HIVE-23496 URL: https://issues.apache.org/jira/browse/HIVE-23496 Project: Hive

[jira] [Created] (HIVE-23495) AcidUtils.getAcidState cleanup

2020-05-18 Thread Peter Varga (Jira)
Peter Varga created HIVE-23495: -- Summary: AcidUtils.getAcidState cleanup Key: HIVE-23495 URL: https://issues.apache.org/jira/browse/HIVE-23495 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-23494) Upgrade Apache parent POM to version 23

2020-05-18 Thread David Mollitor (Jira)
David Mollitor created HIVE-23494: - Summary: Upgrade Apache parent POM to version 23 Key: HIVE-23494 URL: https://issues.apache.org/jira/browse/HIVE-23494 Project: Hive Issue Type:

Review Request 72526: HIVE-23493

2020-05-18 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72526/ --- Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-23493

[jira] [Created] (HIVE-23493) Rewrite plan to join back tables with many projected columns joined multiple times

2020-05-18 Thread Krisztian Kasa (Jira)
Krisztian Kasa created HIVE-23493: - Summary: Rewrite plan to join back tables with many projected columns joined multiple times Key: HIVE-23493 URL: https://issues.apache.org/jira/browse/HIVE-23493

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

2020-05-18 Thread Karen Coppage via Review Board
> On May 18, 2020, 12:51 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 305 (patched) > > > > > > Migth want to add asserts here to check non-null argument

Re: Review Request 72112: HIVE-22869 - Add locking benchmark to metastore-tools/metastore-benchmarks

2020-05-18 Thread Zoltan Chovan via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/ --- (Updated May 18, 2020, 4:59 p.m.) Review request for hive, Denys Kuzmenko,

Re: Review Request 72112: HIVE-22869 - Add locking benchmark to metastore-tools/metastore-benchmarks

2020-05-18 Thread Zoltan Chovan via Review Board
> On May 18, 2020, 7:58 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkTool.java > > Lines 308 (patched) > > > > >

[jira] [Created] (HIVE-23492) Remove unnecessary FileSystem#exists calls from ql module

2020-05-18 Thread Karen Coppage (Jira)
Karen Coppage created HIVE-23492: Summary: Remove unnecessary FileSystem#exists calls from ql module Key: HIVE-23492 URL: https://issues.apache.org/jira/browse/HIVE-23492 Project: Hive Issue

Re: Review Request 72511: HIVE-23491

2020-05-18 Thread Krisztian Kasa
> On May 18, 2020, 2:01 p.m., Zoltan Haindrich wrote: > > parser/src/java/org/apache/hadoop/hive/ql/parse/ParseDriverContext.java > > Lines 23 (patched) > > > > > > I think if the "parse" method would return with an

Re: Review Request 72511: HIVE-23491

2020-05-18 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/ --- (Updated May 18, 2020, 3:32 p.m.) Review request for hive, Jesús Camacho

Re: Review Request 72511: HIVE-23491

2020-05-18 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/#review220807 ---

Review Request 72511: HIVE-23491

2020-05-18 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/ --- Review request for hive, Jesús Camacho Rodríguez and Zoltan Haindrich.

Re: Review Request 72511: HIVE-23491

2020-05-18 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72511/ --- (Updated May 18, 2020, 1:11 p.m.) Review request for hive, Jesús Camacho

[jira] [Created] (HIVE-23491) Move ParseDriver to parser module

2020-05-18 Thread Krisztian Kasa (Jira)
Krisztian Kasa created HIVE-23491: - Summary: Move ParseDriver to parser module Key: HIVE-23491 URL: https://issues.apache.org/jira/browse/HIVE-23491 Project: Hive Issue Type: Improvement

Re: Review Request 72281: HIVE-22971: Eliminate file rename in insert-only compactor

2020-05-18 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72281/#review220805 --- Minor comments only. Thanks for the patch!

Re: [DISCUSS] Replace ptest with hive-test-kube

2020-05-18 Thread Zoltan Haindrich
Hey! On 5/18/20 11:51 AM, Zoltan Chovan wrote: Thank you for all of your efforts, this looks really promising. With moving to github PRs, would that also mean that we move away from the reviewboard for code review? I didn't thinked about that. I think using github's review interface will remain

Re: Review Request 72462: MSCK REPAIR cannot discover partitions with upper case directory names

2020-05-18 Thread Adesh Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72462/ --- (Updated May 18, 2020, 10:43 a.m.) Review request for hive and Sankar

Re: [DISCUSS] Replace ptest with hive-test-kube

2020-05-18 Thread Zoltan Chovan
Hi Zoltan! Thank you for all of your efforts, this looks really promising. With moving to github PRs, would that also mean that we move away from the reviewboard for code review? Also, what happens if a PR is updated? Will the tests run for both or just for the latest version? Regards, Zoltan

Re: Review Request 72462: MSCK REPAIR cannot discover partitions with upper case directory names

2020-05-18 Thread Adesh Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72462/ --- (Updated May 18, 2020, 8:40 a.m.) Review request for hive and Sankar

Re: Review Request 72112: HIVE-22869 - Add locking benchmark to metastore-tools/metastore-benchmarks

2020-05-18 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/#review220804 --- LGTM, some minor comments.

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-18 Thread Denys Kuzmenko via Review Board
> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-18 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/#review220802 --- Thank you for the patch, Peter! LGTM 1 comment on static import

[jira] [Created] (HIVE-23490) REPL LOAD config to bootstrap external tables with purge

2020-05-18 Thread David Lavati (Jira)
David Lavati created HIVE-23490: --- Summary: REPL LOAD config to bootstrap external tables with purge Key: HIVE-23490 URL: https://issues.apache.org/jira/browse/HIVE-23490 Project: Hive Issue