Re: Review Request 36942: HIVE-11401: Predicate push down does not work with Parquet when partitions are in the expression

2015-07-31 Thread Dong Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36942/#review93711 --- Looks good to me. - Dong Chen On July 30, 2015, 9:22 p.m

Re: Review Request 36540: HIVE-8128: Improve Parquet Vectorization

2015-07-21 Thread Dong Chen
/clientpositive/vectorized_parquet_data_types.q PRE-CREATION ql/src/test/results/clientpositive/vectorized_parquet_data_types.q.out PRE-CREATION Diff: https://reviews.apache.org/r/36540/diff/ Testing --- unit test passed Thanks, Dong Chen

Re: Review Request 35950: HIVE-11131: Get row information on DataWritableWriter once for better writing performance

2015-06-29 Thread Dong Chen
/DataWritableWriter.java (line 63) https://reviews.apache.org/r/35950/#comment142719 shall we keep this as 'final'? Nice refactor. The change looks good. Thanks - Dong Chen On June 28, 2015, 12:29 a.m., Sergio Pena wrote

[jira] [Created] (HIVE-10666) Improvement for Parquet Predicate Push down on Hive

2015-05-11 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10666: Summary: Improvement for Parquet Predicate Push down on Hive Key: HIVE-10666 URL: https://issues.apache.org/jira/browse/HIVE-10666 Project: Hive Issue Type

[jira] [Created] (HIVE-10642) Update Timestamp type mapping to Parquet

2015-05-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10642: Summary: Update Timestamp type mapping to Parquet Key: HIVE-10642 URL: https://issues.apache.org/jira/browse/HIVE-10642 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-10252) Make PPD work for Parquet in row group level

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10252: Summary: Make PPD work for Parquet in row group level Key: HIVE-10252 URL: https://issues.apache.org/jira/browse/HIVE-10252 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-10254) Parquet PPD support DECIMAL

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10254: Summary: Parquet PPD support DECIMAL Key: HIVE-10254 URL: https://issues.apache.org/jira/browse/HIVE-10254 Project: Hive Issue Type: Sub-task Reporter

[jira] [Created] (HIVE-10253) Parquet PPD support DATE

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10253: Summary: Parquet PPD support DATE Key: HIVE-10253 URL: https://issues.apache.org/jira/browse/HIVE-10253 Project: Hive Issue Type: Sub-task Reporter

[jira] [Created] (HIVE-10255) Parquet PPD support TIMESTAMP

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10255: Summary: Parquet PPD support TIMESTAMP Key: HIVE-10255 URL: https://issues.apache.org/jira/browse/HIVE-10255 Project: Hive Issue Type: Sub-task Reporter

[jira] [Created] (HIVE-10256) Eliminate row groups based on the block statistics in Parquet

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10256: Summary: Eliminate row groups based on the block statistics in Parquet Key: HIVE-10256 URL: https://issues.apache.org/jira/browse/HIVE-10256 Project: Hive Issue

[jira] [Created] (HIVE-10257) Ensure Parquet Hive has null optimization

2015-04-07 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10257: Summary: Ensure Parquet Hive has null optimization Key: HIVE-10257 URL: https://issues.apache.org/jira/browse/HIVE-10257 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-10016) Remove duplicated Hive table schema parsing in DataWritableReadSupport

2015-03-19 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10016: Summary: Remove duplicated Hive table schema parsing in DataWritableReadSupport Key: HIVE-10016 URL: https://issues.apache.org/jira/browse/HIVE-10016 Project: Hive

[jira] [Created] (HIVE-10031) Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor

2015-03-19 Thread Dong Chen (JIRA)
Dong Chen created HIVE-10031: Summary: Modify the using of jobConf variable in ParquetRecordReaderWrapper constructor Key: HIVE-10031 URL: https://issues.apache.org/jira/browse/HIVE-10031 Project: Hive

[jira] [Created] (HIVE-9906) Add timeout mechanism in RawStoreProxy

2015-03-10 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9906: --- Summary: Add timeout mechanism in RawStoreProxy Key: HIVE-9906 URL: https://issues.apache.org/jira/browse/HIVE-9906 Project: Hive Issue Type: Sub-task

Re: Review Request 31800: HIVE-9658 Reduce parquet memory use by bypassing java primitive objects on ETypeConverter

2015-03-09 Thread Dong Chen
https://reviews.apache.org/r/31800/#comment122889 Delete ((IntWritable) o).get(); in comment. - Dong Chen On March 6, 2015, 5:18 p.m., Sergio Pena wrote: --- This is an automatically generated e-mail. To reply, visit: https

[jira] [Created] (HIVE-9894) Use new parquet Types API builder to construct DATE data type

2015-03-08 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9894: --- Summary: Use new parquet Types API builder to construct DATE data type Key: HIVE-9894 URL: https://issues.apache.org/jira/browse/HIVE-9894 Project: Hive Issue Type

Review Request 31794: HIVE-9819: Add timeout check inside the HMS server

2015-03-06 Thread Dong Chen
/MetaStoreDirectSql.java d404789 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f700353 Diff: https://reviews.apache.org/r/31794/diff/ Testing --- UT in metastore passed Thanks, Dong Chen

[jira] [Created] (HIVE-9868) Turn on Parquet vectorization in parquet branch

2015-03-04 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9868: --- Summary: Turn on Parquet vectorization in parquet branch Key: HIVE-9868 URL: https://issues.apache.org/jira/browse/HIVE-9868 Project: Hive Issue Type: Sub-task

Review Request 31671: HIVE-8128: Improve Parquet Vectorization

2015-03-03 Thread Dong Chen
/vectorized_parquet_data_types.q PRE-CREATION ql/src/test/results/clientpositive/vectorized_parquet_data_types.q.out PRE-CREATION Diff: https://reviews.apache.org/r/31671/diff/ Testing --- add one test, and UT pass locally. Thanks, Dong Chen

[jira] [Created] (HIVE-9819) Add timeout check inside the HMS server

2015-02-27 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9819: --- Summary: Add timeout check inside the HMS server Key: HIVE-9819 URL: https://issues.apache.org/jira/browse/HIVE-9819 Project: Hive Issue Type: Sub-task

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-02-26 Thread Dong Chen
/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-02-26 Thread Dong Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review72119 --- On Jan. 28, 2015, 8:58 a.m., Dong Chen wrote

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-02-26 Thread Dong Chen
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

[jira] [Commented] (HIVE-8128) Improve Parquet Vectorization

2015-02-13 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319723#comment-14319723 ] Dong Chen commented on HIVE-8128: - Will start from a POC based on the new vectorized

[jira] [Work started] (HIVE-8128) Improve Parquet Vectorization

2015-02-13 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-8128 started by Dong Chen. --- Improve Parquet Vectorization - Key: HIVE

[jira] [Assigned] (HIVE-9332) Warn user when parquet mm kicks in

2015-02-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen reassigned HIVE-9332: --- Assignee: Dong Chen Warn user when parquet mm kicks

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-02-12 Thread Dong Chen
generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review72119 --- On Jan. 28, 2015, 8:58 a.m., Dong Chen wrote: --- This is an automatically generated e-mail

[jira] [Commented] (HIVE-9332) Warn user when parquet mm kicks in

2015-02-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14319683#comment-14319683 ] Dong Chen commented on HIVE-9332: - PARQUET-164 is on-going. Will start this after warning

Re: Review Request 30717: HIVE-8119: Implement Date in ParquetSerde

2015-02-12 Thread Dong Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30717/#review71844 --- On Feb. 6, 2015, 7:51 a.m., Dong Chen wrote

Re: Review Request 30750: HIVE-9605 Remove parquet nested objects from wrapper writable objects

2015-02-08 Thread Dong Chen
think we should return an empty map instead of null. ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/AbstractParquetMapInspector.java https://reviews.apache.org/r/30750/#comment117427 how about just check null? Length being 0 might be a normal case. - Dong Chen On Feb. 8

[jira] [Updated] (HIVE-8119) Implement Date in ParquetSerde

2015-02-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-8119: Attachment: HIVE-8119.1.patch Patch v1. A slight change to import class DateWritable. Implement Date

[jira] [Updated] (HIVE-8119) Implement Date in ParquetSerde

2015-02-05 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-8119: Status: Patch Available (was: Open) Implement Date in ParquetSerde

[jira] [Updated] (HIVE-8119) Implement Date in ParquetSerde

2015-02-05 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-8119: Attachment: HIVE-8119.patch Hi [~mohitsabharwal], I am working on HIVE-9442 to check all data types

[jira] [Commented] (HIVE-8119) Implement Date in ParquetSerde

2015-02-05 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308800#comment-14308800 ] Dong Chen commented on HIVE-8119: - RB: https://reviews.apache.org/r/30717/ Implement Date

Review Request 30717: HIVE-8119: Implement Date in ParquetSerde

2015-02-05 Thread Dong Chen
/test/queries/clientpositive/parquet_types.q 806db24 ql/src/test/results/clientnegative/parquet_date.q.out d1c38d6 ql/src/test/results/clientpositive/parquet_types.q.out dc5ceb0 Diff: https://reviews.apache.org/r/30717/diff/ Testing --- UT passed. 2 tests are added Thanks, Dong Chen

[jira] [Updated] (HIVE-9558) [Parquet] support HiveDecimalWritable, HiveCharWritable, HiveVarcharWritable in vectorized mode

2015-02-03 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9558: Attachment: HIVE-9558.1.patch Thanks for figuring out that! Yes, the failed related case is caused

[jira] [Updated] (HIVE-9558) [Parquet] support HiveDecimalWritable, HiveCharWritable, HiveVarcharWritable in vectorized mode

2015-02-02 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9558: Status: Patch Available (was: Open) [Parquet] support HiveDecimalWritable, HiveCharWritable

[jira] [Updated] (HIVE-9558) [Parquet] support HiveDecimalWritable, HiveCharWritable, HiveVarcharWritable in vectorized mode

2015-02-02 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9558: Attachment: HIVE-9558.patch Upload a patch to add a test case verifying parquet data types in vectorized

[jira] [Created] (HIVE-9558) [Parquet] support HiveDecimalWritable, HiveCharWritable, HiveVarcharWritable in vectorized mode

2015-02-02 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9558: --- Summary: [Parquet] support HiveDecimalWritable, HiveCharWritable, HiveVarcharWritable in vectorized mode Key: HIVE-9558 URL: https://issues.apache.org/jira/browse/HIVE-9558

Re: Review Request 30281: Move parquet serialize implementation to DataWritableWriter to improve write speeds

2015-02-01 Thread Dong Chen
(...) - Dong Chen On Jan. 29, 2015, 5:12 p.m., Sergio Pena wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30281/ --- (Updated

[jira] [Updated] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-28 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Attachment: HIVE-9253.4.patch Update V4 to address RB comments. Thank you [~leftylev], [~brocknoland

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-01-28 Thread Dong Chen
/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-01-28 Thread Dong Chen
. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review68878 --- On Jan. 22, 2015, 8:22 a.m., Dong Chen wrote

[jira] [Commented] (HIVE-9450) [Parquet] Check all data types work for Parquet in Group By operator

2015-01-28 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295300#comment-14295300 ] Dong Chen commented on HIVE-9450: - Thank you [~brocknoland], [~Ferd] for your review

[jira] [Created] (HIVE-9491) [Parquet] Support Analyze Table with partial scan

2015-01-27 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9491: --- Summary: [Parquet] Support Analyze Table with partial scan Key: HIVE-9491 URL: https://issues.apache.org/jira/browse/HIVE-9491 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-9490) [Parquet] Support Alter Table/Partition Concatenate

2015-01-27 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9490: --- Summary: [Parquet] Support Alter Table/Partition Concatenate Key: HIVE-9490 URL: https://issues.apache.org/jira/browse/HIVE-9490 Project: Hive Issue Type: Sub-task

[jira] [Commented] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-27 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294628#comment-14294628 ] Dong Chen commented on HIVE-9442: - some sub-tasks are found by testing but not related

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-01-27 Thread Dong Chen
--- On Jan. 22, 2015, 8:22 a.m., Dong Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807

[jira] [Updated] (HIVE-9490) [Parquet] Support Alter Table/Partition Concatenate

2015-01-27 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9490: Attachment: HIVE-9490.patch-testcase Add a test for parquet alter table/partition merge. Will update patch

[jira] [Commented] (HIVE-9470) Use a generic writable object to run ColumnaStorageBench write/read tests

2015-01-26 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292872#comment-14292872 ] Dong Chen commented on HIVE-9470: - LGTM. +1 pending test. Use a generic writable object

[jira] [Updated] (HIVE-9450) [Parquet] Check all data types work for Parquet in Group By operator

2015-01-25 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9450: Attachment: HIVE-9450.patch Reattach the patch to see the test result [Parquet] Check all data types work

[jira] [Updated] (HIVE-9450) [Parquet] Check all data types work for Parquet in Group By operator

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9450: Status: Patch Available (was: Open) [Parquet] Check all data types work for Parquet in Group By operator

[jira] [Updated] (HIVE-9450) [Parquet] Check all data types work for Parquet in Group By operator

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9450: Attachment: HIVE-9450.patch Upload a patch to add tests for data types used in group by operator, and fix

[jira] [Updated] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9442: Issue Type: Improvement (was: Sub-task) Parent: (was: HIVE-8120) Make sure all data types work

[jira] [Commented] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289424#comment-14289424 ] Dong Chen commented on HIVE-9442: - Work procedure is: 1. run existed file format(ORC, etc

[jira] [Created] (HIVE-9450) [Parquet] Check all data types work for Parquet in Group By operator

2015-01-23 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9450: --- Summary: [Parquet] Check all data types work for Parquet in Group By operator Key: HIVE-9450 URL: https://issues.apache.org/jira/browse/HIVE-9450 Project: Hive Issue

[jira] [Work started] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HIVE-9442 started by Dong Chen. --- Make sure all data types work for PARQUET

[jira] [Updated] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-23 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9442: Description: In HIVE-9235 (Turn off Parquet Vectorization until all data types work: DECIMAL, DATE

[jira] [Commented] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-22 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14287083#comment-14287083 ] Dong Chen commented on HIVE-9253: - Thanks for your review! [~leftylev]. Adding the word

[jira] [Updated] (HIVE-9434) Shim the method Path.getPathWithoutSchemeAndAuthority

2015-01-22 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9434: Attachment: HIVE-9434.patch Upload a patch to shim the method {{Path.getPathWithoutSchemeAndAuthority

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-01-22 Thread Dong Chen
PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestRuntimeTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

[jira] [Updated] (HIVE-9434) Shim the method Path.getPathWithoutSchemeAndAuthority

2015-01-22 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9434: Status: Patch Available (was: Open) Shim the method Path.getPathWithoutSchemeAndAuthority

[jira] [Commented] (HIVE-9434) Shim the method Path.getPathWithoutSchemeAndAuthority

2015-01-22 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288918#comment-14288918 ] Dong Chen commented on HIVE-9434: - Failed tests seem not related. Shim the method

[jira] [Assigned] (HIVE-9434) Shim the method Path.getPathWithoutSchemeAndAuthority

2015-01-21 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen reassigned HIVE-9434: --- Assignee: Dong Chen Shim the method Path.getPathWithoutSchemeAndAuthority

[jira] [Updated] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-21 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Attachment: HIVE-9253.3.patch Update v3 MetaStore server should support timeout for long running requests

[jira] [Created] (HIVE-9442) Make sure all data types work for PARQUET

2015-01-21 Thread Dong Chen (JIRA)
Dong Chen created HIVE-9442: --- Summary: Make sure all data types work for PARQUET Key: HIVE-9442 URL: https://issues.apache.org/jira/browse/HIVE-9442 Project: Hive Issue Type: Sub-task

Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests

2015-01-20 Thread Dong Chen
/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestRuntimeTimeout.java PRE-CREATION Diff: https://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

Re: Review Request 29807: MetaStore server should support timeout for long running requests

2015-01-20 Thread Dong Chen
://reviews.apache.org/r/29807/diff/ Testing --- UT passed Thanks, Dong Chen

[jira] [Updated] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-20 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Attachment: HIVE-9253.2.patch Thanks very much for your help! [~brocknoland] I updated the patch V2

[jira] [Commented] (HIVE-9264) Merge encryption branch to trunk

2015-01-18 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282223#comment-14282223 ] Dong Chen commented on HIVE-9264: - +1 Recent change also looks good!! Thanks

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-14 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Attachment: HIVE-9356.2-encryption.patch Right! I missed the HiveCommand only for testing. Thank your

Re: Review Request 28964: HIVE-8121 Create micro-benchmarks for ParquetSerde and evaluate performance

2015-01-14 Thread Dong Chen
benchmark helps a lot! Thanks! - Dong Chen On Jan. 14, 2015, 11:48 p.m., Sergio Pena wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28964

Re: Review Request 28964: HIVE-8121 Create micro-benchmarks for ParquetSerde and evaluate performance

2015-01-14 Thread Dong Chen
/ColumnarStorageBench.java https://reviews.apache.org/r/28964/#comment112361 Same as above comments. Can we change the read method to only test reader.next(), and remove the getRecordReader part? - Dong Chen On Jan. 14, 2015, 11:48 p.m., Sergio Pena wrote

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon in the annotation

2015-01-13 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Attachment: HIVE-9356.1-encryption.patch Thanks for your review! Sergio, Brock. I found we have to handle

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon

2015-01-13 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Attachment: HIVE-9356-encryption.patch Rename patch Fail to handle the case that a qfile contains

[jira] [Commented] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273722#comment-14273722 ] Dong Chen commented on HIVE-9253: - Thank you [~brocknoland] for your great idea! I updated

[jira] [Updated] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Attachment: HIVE-9253.1.patch MetaStore server should support timeout for long running requests

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Description: Currently, we split the qfile by the semicolon. It should be able to handle the comment

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Status: Patch Available (was: Open) Fail to handle the case that a qfile contains a semicolon

[jira] [Updated] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9356: Attachment: HIVE-9356.patch Fail to handle the case that a qfile contains a semicolon

[jira] [Commented] (HIVE-9356) Fail to handle the case that a qfile contains a semicolon

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274647#comment-14274647 ] Dong Chen commented on HIVE-9356: - A small fix for the failed case

[jira] [Commented] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-12 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273737#comment-14273737 ] Dong Chen commented on HIVE-9253: - When unit testing the changes in {{RetryingHMSHandler

Review Request 29807: MetaStore server should support timeout for long running requests

2015-01-12 Thread Dong Chen
Thanks, Dong Chen

[jira] [Commented] (HIVE-9307) Use metastore warehouse dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270398#comment-14270398 ] Dong Chen commented on HIVE-9307: - Update patch V1. The variable is used in 3 statement

[jira] [Updated] (HIVE-9307) Use metastore warehouse dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9307: Attachment: HIVE-9307.1.patch Use metastore warehouse dir variable from conf instead of hard coded dir

[jira] [Updated] (HIVE-9307) Use metastore warehouse dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9307: Fix Version/s: encryption-branch Status: Patch Available (was: Open) Use metastore warehouse

[jira] [Commented] (HIVE-9307) Use metastore warehouse dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270486#comment-14270486 ] Dong Chen commented on HIVE-9307: - Not necessary. Other .q files result keep same

[jira] [Commented] (HIVE-9297) HS2 should be able to write query logs to HDFS or at least copy them there

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269295#comment-14269295 ] Dong Chen commented on HIVE-9297: - A good idea! It would be great I could help

[jira] [Commented] (HIVE-9307) Use MetaStore dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269310#comment-14269310 ] Dong Chen commented on HIVE-9307: - Patch attached for review. Still not good enough. When

[jira] [Updated] (HIVE-9307) Use MetaStore dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9307: Description: NO PRECOMMIT TESTS Use the following variable to get the metastore directory

[jira] [Updated] (HIVE-9307) Use MetaStore dir variable from conf instead of hard coded dir in encryption test

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9307: Attachment: HIVE-9307.patch Use MetaStore dir variable from conf instead of hard coded dir in encryption

[jira] [Updated] (HIVE-9253) MetaStore server should detect client timeout

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Description: In the description of HIVE-7195, one issue is that MetaStore client timeout is quite dumb

[jira] [Updated] (HIVE-9253) MetaStore server should support timeout for long running requests

2015-01-08 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9253: Summary: MetaStore server should support timeout for long running requests (was: MetaStore server should

[jira] [Commented] (HIVE-9283) Improve encryption related test cases

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267500#comment-14267500 ] Dong Chen commented on HIVE-9283: - Since HIVE-9261 has already been created for updating

[jira] [Updated] (HIVE-9286) Add clean up code in some encryption related test cases

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9286: Fix Version/s: encryption-branch Status: Patch Available (was: Open) Add clean up code in some

[jira] [Updated] (HIVE-9286) Add clean up code in some encryption related test cases

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9286: Description: NO PRECOMMIT TESTS Add cleanup at the end of .q files: drop table and delete key. Otherwise

[jira] [Updated] (HIVE-9286) Add clean up code in some encryption related test cases

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9286: Attachment: HIVE-9286.patch Patch uploaded. Drop table and delete key at the end in the .q files. Add

[jira] [Updated] (HIVE-9261) Update the output files for the encryption qtests since the output format changed

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9261: Description: NO PRECOMMIT TESTS Should update the output files due to the output format changes in HIVE

[jira] [Updated] (HIVE-9261) Update the output files for the encryption qtests since the output format changed

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9261: Fix Version/s: encryption-branch Status: Patch Available (was: Open) Update the output files

[jira] [Updated] (HIVE-9261) Update the output files for the encryption qtests since the output format changed

2015-01-07 Thread Dong Chen (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Chen updated HIVE-9261: Attachment: HIVE-9261.patch This patch updated the output result of encryption test cases. It covers HIVE

  1   2   3   >