Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

> On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > LGTM, a few minor suggestions. > > (Non-binding) Thanks for the review. > On June 5, 2020, 2:04 p.m., Karen Coppage wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Line 1411 (original) > >

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- (Updated June 8, 2020, 10:58 a.m.) Review request for hive, Karen Coppage, Mart

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

> On May 20, 2020, 3:16 p.m., Peter Varga wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 686 (patched) > > > > > > I have concerns here, but I am not sure if they are well founded or > > not.

Re: Review Request 72488: HIVE-23413: New config to skip all locks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72488/ --- (Updated June 3, 2020, 9:20 a.m.) Review request for hive, Denys Kuzmenko and P

Re: Review Request 72488: HIVE-23413: New config to skip all locks

> On June 3, 2020, 6:53 a.m., Denys Kuzmenko wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2737 (patched) > > > > > > I would name config property - HIVE_TXN_DISABLE_LOCKS, to give m

Re: Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- (Updated May 21, 2020, 1:23 p.m.) Review request for hive, Karen Coppage and Pe

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

> On May 20, 2020, 3:16 p.m., Peter Varga wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 686 (patched) > > > > > > I have concerns here, but I am not sure if they are well founded or > > not.

Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- Review request for hive, Karen Coppage and Peter Vary. Repository: hive-git D

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72528/#review220838 --- The patch looks great, but I have concers. See below. ql/src/jav

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/ --- (Updated May 20, 2020, 2:03 p.m.) Review request for hive, Miklos Gergely and P

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

> On May 19, 2020, 7:54 a.m., Peter Vary wrote: > > Thank you for the review, fixed the issues + removed some parameters from the HMS.startMetaStore, since they were just implementation details unneccessary exposed. - Peter --- This i

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 20, 2020, 12:24 p.m.) Review request for hive and Denys Kuzmenko.

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please refac

Review Request 72488: HIVE-23413: New config to skip all locks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72488/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/ --- (Updated May 8, 2020, 9:46 a.m.) Review request for hive, Miklos Gergely and Pe

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

> On May 4, 2020, 3 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java > > Line 107 (original), 110 (patched) > > > > > >

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 7, 2020, 11:58 a.m.) Review request for hive and Denys Kuzmenko.

Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/ --- Review request for hive, Miklos Gergely and Peter Vary. Repository: hive-git

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/#review220631 --- Ship it! Ship It! - Peter Varga On May 5, 2020, 8:33 a.m., D

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

> On May 4, 2020, 3 p.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java > > Lines 400 (patched) > > > > > > Is is a generic txn objec

Re: Review Request 72470: ACID: Concurrent MERGE INSERT operations produce duplicates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72470/#review220620 --- Looks good, just one question. ql/src/java/org/apache/hadoop/hiv

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 4, 2020, 1:22 p.m.) Review request for hive and Denys Kuzmenko.

Review Request 72465: HIVE-23340 TxnHandler cleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- Review request for hive and Denys Kuzmenko. Repository: hive-git Description

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 28, 2020, 3:38 p.m.) Review request for hive and Peter Vary. R

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 27, 2020, 3:04 p.m., Peter Vary wrote: > > Fix it and ship it Thank you for the reviews, fixed the issues and got a green run. > On April 27, 2020, 3:04 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql > > Lines

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 24, 2020, 3:14 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1453 (patched) > > > > > > Why is this change?

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 24, 2020, 2:16 p.m., Denys Kuzmenko wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestDbTxnManager2.java > > Lines 1068 (patched) > > > > > > Is it important? I thought TXNS table is cleaned be

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 24, 2020, 3:40 p.m.) Review request for hive and Peter Vary. R

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 23, 2020, 2:48 p.m.) Review request for hive and Peter Vary. C

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 699 (patched) > > > > > > openTxns(dbConn, stm

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 12:51 p.m.) Review request for hive and Peter Vary.

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

> On April 17, 2020, 7:03 p.m., Peter Vary wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMetaStoreHandler.java > > Lines 67 (patched) > > > > > > Why is this needed? These remained here because

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 902 (patched) > > > > > > Can it be null?

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/ --- (Updated April 21, 2020, 10:22 a.m.) Review request for hive, Denys Kuzmenko an

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- (Updated April 21, 2020, 7:53 a.m.) Review request for hive and Peter Vary. R

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > This is a really big/scary change. I am really interested in the > > performance results! :) > > Thanks for all the effort! Some questions below Thank you for the review, i fixed most of them, but have a few questions. > On April 20, 2020

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

> On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > LGTM, just a few comments Thank you for the review, I fixed most of the issues, but have a few question. > On April 20, 2020, 10:40 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/h

Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

> On April 17, 2020, 7:03 p.m., Peter Vary wrote: > > Thanks Peter for the patch! > > This fix is long overdue! > > > > I do not understand one thing, see below. > > > > Also I would like to ask Denys to confirm, that running the init sqls again > > and again will not cause too much overhead i

Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72380/ --- Review request for hive, Denys Kuzmenko and Zoltan Chovan. Repository: hive-git

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/ --- (Updated April 6, 2020, 10:04 a.m.) Review request for hive and Adam Szita. R

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

> On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithServiceDiscovery.java > > Lines 94 (patched) > > > > > > Can be private if not used elsewhere I re

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

> On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > Looking pretty good overall, I just have a few questions/comments. I fixed the issues, added a little more logging and fixed the weird annotation formatting. > On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > service/src/java/org/apache

Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/ --- Review request for hive and Adam Szita. Repository: hive-git Description

Review Request 72246: HIVE-23045: Zookeeper SSL/TLS support

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72246/ --- Review request for hive, Denys Kuzmenko and Peter Vary. Repository: hive-git