[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419996#comment-13419996
]
Mahsa Mofidpoor commented on HIVE-1644:
---
Can the same approach be applied to
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027559#comment-13027559
]
John Sichi commented on HIVE-1644:
--
+1. Will commit when tests pass.
use filter
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027489#comment-13027489
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027298#comment-13027298
]
John Sichi commented on HIVE-1644:
--
Seems to me we should get your patch committed without
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027141#comment-13027141
]
John Sichi commented on HIVE-1644:
--
Oh, I see...the reason it didn't work for you is that
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027283#comment-13027283
]
Russell Melick commented on HIVE-1644:
--
I can send it back out of the index handler,
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13027294#comment-13027294
]
Russell Melick commented on HIVE-1644:
--
Unfortunately, having an empty array gives out
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13026789#comment-13026789
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13025388#comment-13025388
]
John Sichi commented on HIVE-1644:
--
Yeah, when I look in build/ql/tmp/hive.log after
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023513#comment-13023513
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023514#comment-13023514
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023362#comment-13023362
]
John Sichi commented on HIVE-1644:
--
Looks good, I added a few minor comments and requests
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023365#comment-13023365
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023096#comment-13023096
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023098#comment-13023098
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021184#comment-13021184
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021191#comment-13021191
]
John Sichi commented on HIVE-1644:
--
Responses added in review board.
use filter
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021190#comment-13021190
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020560#comment-13020560
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020562#comment-13020562
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020233#comment-13020233
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020423#comment-13020423
]
John Sichi commented on HIVE-1644:
--
Responses added in review board.
use filter
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020422#comment-13020422
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017164#comment-13017164
]
jirapos...@reviews.apache.org commented on HIVE-1644:
-
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014799#comment-13014799
]
John Sichi commented on HIVE-1644:
--
@Russell: index.getIndexTableName(), and then do
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014394#comment-13014394
]
Russell Melick commented on HIVE-1644:
--
I'm having trouble getting the partitions from
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13014398#comment-13014398
]
He Yongqiang commented on HIVE-1644:
You have the list of partitions for the original
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010285#comment-13010285
]
He Yongqiang commented on HIVE-1644:
Hi Russell,
FIL%SEL% maybe not not good enough,
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13010401#comment-13010401
]
Namit Jain commented on HIVE-1644:
--
Also, can you add another check - only use the index
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13009261#comment-13009261
]
He Yongqiang commented on HIVE-1644:
a few comments:
rename work.getInputFormatFile to
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008323#comment-13008323
]
John Sichi commented on HIVE-1644:
--
Russell, the plan still looks wrong. It shows two
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004887#comment-13004887
]
John Sichi commented on HIVE-1644:
--
The test is failing because you forgot to add
SET
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003645#comment-13003645
]
John Sichi commented on HIVE-1644:
--
I'm not sure about those task dependencies...the
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003081#comment-13003081
]
John Sichi commented on HIVE-1644:
--
@Russell: that would be because of this line in
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001584#comment-13001584
]
He Yongqiang commented on HIVE-1644:
Take SkewJoinResolver as an example, in its
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001618#comment-13001618
]
John Sichi commented on HIVE-1644:
--
Yongqiang, thanks for the pointer. Guys, give that a
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001565#comment-13001565
]
He Yongqiang commented on HIVE-1644:
take a look at one physical optimizer, it is
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001208#comment-13001208
]
He Yongqiang commented on HIVE-1644:
did a quick look at the HIVE-1644.4.patch itself.
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13001218#comment-13001218
]
John Sichi commented on HIVE-1644:
--
Yongqiang, could you reference where exactly in
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999206#comment-12999206
]
Russell Melick commented on HIVE-1644:
--
Make sure we update the admin configuration
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12999254#comment-12999254
]
John Sichi commented on HIVE-1644:
--
I got a boatload of conflicts trying to apply
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998155#comment-12998155
]
Russell Melick commented on HIVE-1644:
--
We also spoke about changing the re-entrant
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12998211#comment-12998211
]
John Sichi commented on HIVE-1644:
--
For loading index handlers, see
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996042#comment-12996042
]
John Sichi commented on HIVE-1644:
--
You're pretty close with the first method; if I
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996182#comment-12996182
]
John Sichi commented on HIVE-1644:
--
After looking into this some more, it seems like there
[
https://issues.apache.org/jira/browse/HIVE-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996227#comment-12996227
]
John Sichi commented on HIVE-1644:
--
Stop the press; ignore that last comment. I hacked
46 matches
Mail list logo
