[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472986#comment-13472986
]
Navis commented on HIVE-3562:
-
without pushdown,
Map output bytes 9312
Map output records 5
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500118#comment-13500118
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
I'm interested in this
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500165#comment-13500165
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
Apologies, you can use
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511402#comment-13511402
]
Namit Jain commented on HIVE-3562:
--
I think it would be simple to keep it a hive only chan
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511418#comment-13511418
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
Hive-only change is fi
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511434#comment-13511434
]
Namit Jain commented on HIVE-3562:
--
Cool, can you also review ?
I will start reviewing too
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511442#comment-13511442
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511477#comment-13511477
]
Phabricator commented on HIVE-3562:
---
tarball has requested changes to the revision "HIVE-
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511482#comment-13511482
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
Added my comments to P
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527685#comment-13527685
]
Navis commented on HIVE-3562:
-
I just wanted to start small not affecting flow over operators b
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527803#comment-13527803
]
Phabricator commented on HIVE-3562:
---
tarball has requested changes to the revision "HIVE-
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528572#comment-13528572
]
Phabricator commented on HIVE-3562:
---
navis has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533638#comment-13533638
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542690#comment-13542690
]
Phabricator commented on HIVE-3562:
---
tarball has commented on the revision "HIVE-3562 [ji
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542689#comment-13542689
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
Looks good to me. +1
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546643#comment-13546643
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546649#comment-13546649
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546661#comment-13546661
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546703#comment-13546703
]
Phabricator commented on HIVE-3562:
---
njain has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546822#comment-13546822
]
Phabricator commented on HIVE-3562:
---
navis has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563464#comment-13563464
]
Phabricator commented on HIVE-3562:
---
navis has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668536#comment-13668536
]
Gopal V commented on HIVE-3562:
---
I have implemented a similar fix as a Combiner in MR (LimitN
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738847#comment-13738847
]
Ashutosh Chauhan commented on HIVE-3562:
[~gopalv] Your approach sounds interesting
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739324#comment-13739324
]
Hive QA commented on HIVE-3562:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740269#comment-13740269
]
Gopal V commented on HIVE-3562:
---
I have created HIVE-5093 to hold my limit combiner patch (re
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744728#comment-13744728
]
Hive QA commented on HIVE-3562:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747625#comment-13747625
]
Ashutosh Chauhan commented on HIVE-3562:
As always, high quality work, Navis!
Left
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747626#comment-13747626
]
Phabricator commented on HIVE-3562:
---
ashutoshc has requested changes to the revision "HIV
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747635#comment-13747635
]
Edward Capriolo commented on HIVE-3562:
---
{quote}1. Is it possible to use one DataStru
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747643#comment-13747643
]
Ashutosh Chauhan commented on HIVE-3562:
[~navis] Can you also add a test case for
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747647#comment-13747647
]
Ashutosh Chauhan commented on HIVE-3562:
[~appodictic] I dont care which DS you pic
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747649#comment-13747649
]
Edward Capriolo commented on HIVE-3562:
---
Makes sense.
> Some limit c
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748676#comment-13748676
]
Ashutosh Chauhan commented on HIVE-3562:
[~navis] It occurred to me that this optim
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748683#comment-13748683
]
Yin Huai commented on HIVE-3562:
Implementing RSHash as an operator sounds good. We can als
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749290#comment-13749290
]
Phabricator commented on HIVE-3562:
---
navis has commented on the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749292#comment-13749292
]
Navis commented on HIVE-3562:
-
I think RSHash should be a entity that can be used in various op
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749296#comment-13749296
]
Ashutosh Chauhan commented on HIVE-3562:
I agree that will be quite a bit of work a
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749302#comment-13749302
]
Navis commented on HIVE-3562:
-
Then, FS will be needed for context of limiting rows(limit, key
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749303#comment-13749303
]
Ashutosh Chauhan commented on HIVE-3562:
Correct. Thanks a lot for considering. I a
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749306#comment-13749306
]
Phabricator commented on HIVE-3562:
---
ashutoshc has commented on the revision "HIVE-3562 [
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750398#comment-13750398
]
Phabricator commented on HIVE-3562:
---
ashutoshc has commented on the revision "HIVE-3562 [
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750955#comment-13750955
]
Phabricator commented on HIVE-3562:
---
ashutoshc has accepted the revision "HIVE-3562 [jira
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751276#comment-13751276
]
Navis commented on HIVE-3562:
-
I'm on vacation till next tuesday. Feel free to modify this patc
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752490#comment-13752490
]
Gopal V commented on HIVE-3562:
---
Good work Navis.
Let me mark HIVE-5093 as obsoleted by this
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752529#comment-13752529
]
Hudson commented on HIVE-3562:
--
FAILURE: Integrated in Hive-trunk-hadoop2-ptest #74 (See
[htt
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752543#comment-13752543
]
Sivaramakrishnan Narayanan commented on HIVE-3562:
--
Good stuff, Navis!
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752552#comment-13752552
]
Hudson commented on HIVE-3562:
--
FAILURE: Integrated in Hive-trunk-hadoop1-ptest #142 (See
[ht
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753307#comment-13753307
]
Hudson commented on HIVE-3562:
--
SUCCESS: Integrated in Hive-trunk-h0.21 #2295 (See
[https://b
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753365#comment-13753365
]
Hudson commented on HIVE-3562:
--
ABORTED: Integrated in Hive-trunk-hadoop2 #387 (See
[https://
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805523#comment-13805523
]
Sergey Shelukhin commented on HIVE-3562:
Quick question - is it intended that exclu
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808846#comment-13808846
]
Navis commented on HIVE-3562:
-
[~sershe] Sorry for late reply. I thought the cost of top-n hash
[
https://issues.apache.org/jira/browse/HIVE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809865#comment-13809865
]
Sergey Shelukhin commented on HIVE-3562:
Let me file a jira...
> Some limit can be
52 matches
Mail list logo