[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832805#comment-13832805
]
Eric Hanson commented on HIVE-5581:
---
+1
Implement vectorized year/month/day... etc. for
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832807#comment-13832807
]
Eric Hanson commented on HIVE-5581:
---
Hey Teddy, I'd love your help on more vectorized
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832318#comment-13832318
]
Teddy Choi commented on HIVE-5581:
--
I wrote vectorized versions of UDFYear, UDFMonth,
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829051#comment-13829051
]
Teddy Choi commented on HIVE-5581:
--
I uploaded a new patch. The last patch missed an
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829620#comment-13829620
]
Hive QA commented on HIVE-5581:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827027#comment-13827027
]
Eric Hanson commented on HIVE-5581:
---
Teddy, Is the patch ready, or is this a test
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821587#comment-13821587
]
Eric Hanson commented on HIVE-5581:
---
+1
Thanks Teddy. I like how you implemented this
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821590#comment-13821590
]
Brock Noland commented on HIVE-5581:
Should we really be catching Exception below (and
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821596#comment-13821596
]
Teddy Choi commented on HIVE-5581:
--
[~brocknoland] Sounds reasonable. I'll update the
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822137#comment-13822137
]
Hive QA commented on HIVE-5581:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820788#comment-13820788
]
Eric Hanson commented on HIVE-5581:
---
Teddy, when do you think you can update the patch?
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820952#comment-13820952
]
Teddy Choi commented on HIVE-5581:
--
The review request is also updated. Thank you, Eric.
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817130#comment-13817130
]
Hive QA commented on HIVE-5581:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817499#comment-13817499
]
Eric Hanson commented on HIVE-5581:
---
I think there is still a possibility in a
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817006#comment-13817006
]
Teddy Choi commented on HIVE-5581:
--
Eric,
The new patch is on
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815153#comment-13815153
]
Eric Hanson commented on HIVE-5581:
---
Teddy,
This sounds good. Can you please upload the
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815172#comment-13815172
]
Teddy Choi commented on HIVE-5581:
--
[~ehans], I uploaded my latest patch. :)
Implement
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815464#comment-13815464
]
Eric Hanson commented on HIVE-5581:
---
Please see my review comments. It still needs a bit
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815472#comment-13815472
]
Hive QA commented on HIVE-5581:
---
{color:green}Overall{color}: +1 all checks pass
Here are
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811134#comment-13811134
]
Teddy Choi commented on HIVE-5581:
--
Eric,
I will separate classes, and also make
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811381#comment-13811381
]
Eric Hanson commented on HIVE-5581:
---
Okay, thanks Teddy!
Implement vectorized
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809287#comment-13809287
]
Eric Hanson commented on HIVE-5581:
---
Teddy,
Thanks for the patch. I think there is in
[
https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806591#comment-13806591
]
Hive QA commented on HIVE-5581:
---
{color:green}Overall{color}: +1 all checks pass
Here are
23 matches
Mail list logo