[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-26 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832805#comment-13832805 ] Eric Hanson commented on HIVE-5581: --- +1 Implement vectorized year/month/day... etc. for

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-26 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832807#comment-13832807 ] Eric Hanson commented on HIVE-5581: --- Hey Teddy, I'd love your help on more vectorized

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-25 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832318#comment-13832318 ] Teddy Choi commented on HIVE-5581: -- I wrote vectorized versions of UDFYear, UDFMonth,

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-21 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829051#comment-13829051 ] Teddy Choi commented on HIVE-5581: -- I uploaded a new patch. The last patch missed an

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-21 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829620#comment-13829620 ] Hive QA commented on HIVE-5581: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-19 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827027#comment-13827027 ] Eric Hanson commented on HIVE-5581: --- Teddy, Is the patch ready, or is this a test

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-13 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821587#comment-13821587 ] Eric Hanson commented on HIVE-5581: --- +1 Thanks Teddy. I like how you implemented this

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-13 Thread Brock Noland (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821590#comment-13821590 ] Brock Noland commented on HIVE-5581: Should we really be catching Exception below (and

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-13 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13821596#comment-13821596 ] Teddy Choi commented on HIVE-5581: -- [~brocknoland] Sounds reasonable. I'll update the

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-13 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13822137#comment-13822137 ] Hive QA commented on HIVE-5581: --- {color:red}Overall{color}: -1 no tests executed Here are

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-12 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820788#comment-13820788 ] Eric Hanson commented on HIVE-5581: --- Teddy, when do you think you can update the patch?

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-12 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13820952#comment-13820952 ] Teddy Choi commented on HIVE-5581: -- The review request is also updated. Thank you, Eric.

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-08 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817130#comment-13817130 ] Hive QA commented on HIVE-5581: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-08 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817499#comment-13817499 ] Eric Hanson commented on HIVE-5581: --- I think there is still a possibility in a

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-07 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13817006#comment-13817006 ] Teddy Choi commented on HIVE-5581: -- Eric, The new patch is on

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-06 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815153#comment-13815153 ] Eric Hanson commented on HIVE-5581: --- Teddy, This sounds good. Can you please upload the

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-06 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815172#comment-13815172 ] Teddy Choi commented on HIVE-5581: -- [~ehans], I uploaded my latest patch. :) Implement

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-06 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815464#comment-13815464 ] Eric Hanson commented on HIVE-5581: --- Please see my review comments. It still needs a bit

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-06 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13815472#comment-13815472 ] Hive QA commented on HIVE-5581: --- {color:green}Overall{color}: +1 all checks pass Here are

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-01 Thread Teddy Choi (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811134#comment-13811134 ] Teddy Choi commented on HIVE-5581: -- Eric, I will separate classes, and also make

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-11-01 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811381#comment-13811381 ] Eric Hanson commented on HIVE-5581: --- Okay, thanks Teddy! Implement vectorized

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-10-30 Thread Eric Hanson (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809287#comment-13809287 ] Eric Hanson commented on HIVE-5581: --- Teddy, Thanks for the patch. I think there is in

[jira] [Commented] (HIVE-5581) Implement vectorized year/month/day... etc. for string arguments

2013-10-28 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-5581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13806591#comment-13806591 ] Hive QA commented on HIVE-5581: --- {color:green}Overall{color}: +1 all checks pass Here are