[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296201#comment-14296201
]
Ferdinand Xu commented on HIVE-9470:
Thank you for your update. +1
Use a generic
[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294283#comment-14294283
]
Hive QA commented on HIVE-9470:
---
{color:red}Overall{color}: -1 at least one tests failed
[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292507#comment-14292507
]
Hive QA commented on HIVE-9470:
---
{color:red}Overall{color}: -1 no tests executed
Here are
[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292872#comment-14292872
]
Dong Chen commented on HIVE-9470:
-
LGTM. +1 pending test.
Use a generic writable object
[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292772#comment-14292772
]
Ferdinand Xu commented on HIVE-9470:
LGTM with some minor suggestions.
{noformat}
131
[
https://issues.apache.org/jira/browse/HIVE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14292372#comment-14292372
]
Sergio Peña commented on HIVE-9470:
---
[~Ferd] [~dongc]
Could you review this?
Thanks