Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-04 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review117816 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 12

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-04 Thread Chaoyu Tang
> On Feb. 4, 2016, 2:51 p.m., Xuefu Zhang wrote: > > Thanks Xuefu for review. I answered all the questions and please let me know if they make sense. > On Feb. 4, 2016, 2:51 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java, line 152 > >

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118398 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 13

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/ --- (Updated Feb. 9, 2016, 6:54 p.m.) Review request for hive, Ashutosh Chauhan, Sz

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118442 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java (line 12

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/ --- (Updated Feb. 9, 2016, 8:55 p.m.) Review request for hive, Ashutosh Chauhan, Sz

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-09 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118462 --- Ship it! Ship It! - Xuefu Zhang On Feb. 9, 2016, 8:55 p.m.,

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-11 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/ --- (Updated Feb. 11, 2016, 9:54 p.m.) Review request for hive, Ashutosh Chauhan, S

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-11 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118939 --- ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-11 Thread Chaoyu Tang
> On Feb. 11, 2016, 10:17 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java, line 110 > > > > > > qq: So closing the file systems gave the issues seen in the test > > failures?

Re: Review Request 43176: HIVE-12965: Insert overwrite local directory should perserve the overwritten directory permission

2016-02-11 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43176/#review118941 --- Ship it! Ship It! - Xuefu Zhang On Feb. 11, 2016, 9:54 p.m.,