Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/#review58777 --- Ship it! Ship It! - Vaibhav Gumashta On Oct. 28, 2014, 3:12

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/ --- (Updated Oct. 28, 2014, 1:58 a.m.) Review request for hive and Vaibhav

Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/ --- Review request for hive. Bugs: HIVE-8615

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/#review58756 --- Thank Thejas for your patch. LGTM besides some minor issues.

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread Thejas Nair
On Oct. 28, 2014, 2:13 a.m., cheng xu wrote: itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java, line 379 https://reviews.apache.org/r/27263/diff/1/?file=734834#file734834line379 String variable TEST_NAME should be testDSVOutput Thanks for pointing

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/ --- (Updated Oct. 28, 2014, 3:12 a.m.) Review request for hive and Vaibhav

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread cheng xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/#review58760 --- Ship it! Thanks for clean up the test class. LGTM! - cheng xu