Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review61777 --- Ship it! LICENSE

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 13, 2014, 4:29 p.m.) Review request for hive. Changes ---

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 13, 2014, 3:44 a.m.) Review request for hive. Repository: hive-

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 13, 2014, 3:35 a.m.) Review request for hive. Changes ---

Re: Review Request 27566: HIVE-8609: move beeline to jline2

> On Nov. 13, 2014, 2:06 a.m., Mohit Sabharwal wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLineCommandCompleter.java, line > > 35 > > > > > > nit: add @Override The override keyword is not applicable here s

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review60811 --- Few requests to improve docs, otherwise LGTM! beeline/src/java/org

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 12, 2014, 2:43 a.m.) Review request for hive. Changes ---

Re: Review Request 27566: HIVE-8609: move beeline to jline2

> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote: > > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 1 > > > > > > I see, this class is being copied from JLine source. We'll need special > > han

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 12, 2014, 2:30 a.m.) Review request for hive. Changes ---

Re: Review Request 27566: HIVE-8609: move beeline to jline2

> On Nov. 11, 2014, 4:38 p.m., Brock Noland wrote: > > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 1 > > > > > > I see, this class is being copied from JLine source. We'll need special > > han

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review60788 --- Thank you very much! I have made some more comments below! Lets see

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- (Updated Nov. 11, 2014, 11:45 a.m.) Review request for hive. Changes ---

Re: Review Request 27566: HIVE-8609: move beeline to jline2

> On Nov. 10, 2014, 9:13 p.m., Brock Noland wrote: > > beeline/src/java/org/apache/hive/beeline/ClassNameCompleter.java, line 32 > > > > > > Is this new functionality? In the previous code, it tried to use the ClassNam

Re: Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/#review60674 --- Thank you! I have a few comments below... beeline/src/java/org/apa

Review Request 27566: HIVE-8609: move beeline to jline2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27566/ --- Review request for hive. Repository: hive-git Description --- HIVE-8609: