Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-06 Thread Suhas Satish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/ --- (Updated Nov. 6, 2014, 11:43 p.m.) Review request for hive, Chao Sun, Jimmy

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-06 Thread Suhas Satish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/#review60278 --- Few comments about the patch: It is triggered only when RS-MJ is

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Suhas Satish
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/ --- (Updated Nov. 5, 2014, 8:29 p.m.) Review request for hive, Chao Sun, Jimmy

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/#review60031 --- Hi, I know this is a combination of patches from Suhas and Chao,

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Chao Sun
On Nov. 5, 2014, 9:23 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 188 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line188 Can you elaborate why we need this assumption? This may not be true

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Suhas Satish
On Nov. 5, 2014, 9:23 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 201 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line201 We need to handle the case of where parent is the mapwork of

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Szehon Ho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/#review60052 ---

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Suhas Satish
On Nov. 5, 2014, 10:41 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 201 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line201 Hi Suhas, I was taking a look through the code, I dont think its

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Szehon Ho
On Nov. 5, 2014, 10:41 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 201 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line201 Hi Suhas, I was taking a look through the code, I dont think its

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Suhas Satish
On Nov. 5, 2014, 10:41 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 201 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line201 Hi Suhas, I was taking a look through the code, I dont think its

Re: Review Request 27640: HIVE-8700 Replace ReduceSink to HashTableSink (or equi.) for small tables [Spark Branch]

2014-11-05 Thread Suhas Satish
On Nov. 5, 2014, 9:23 p.m., Szehon Ho wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 254 https://reviews.apache.org/r/27640/diff/1/?file=750693#file750693line254 Are you sure we dont need to initialize the HTSOperator's values like