Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-13 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 13, 2014, 7:17 p.m.) Review request for hive, Chao Sun, Szehon

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-13 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61300 ---

Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- Review request for hive, Chao Sun and Xuefu Zhang. Bugs: HIVE-8810

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 12, 2014, 10:35 p.m.) Review request for hive, Chao Sun, Szehon

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61102 ---

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 12, 2014, 11:58 p.m.) Review request for hive, Chao Sun, Szehon

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/plan/SparkHashTableSinkDesc.java, line 34 https://reviews.apache.org/r/27933/diff/1/?file=760617#file760617line34 This class seems to be identiccal to HashTableSinkDesc. Could we extend from

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61150 ---

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 274 https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line274 Don't need this check anymore. That's right. No need for this check

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Chao Sun
On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 326 https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line326 Can we use SPARKHASHTABLESINK, or something similar? Jimmy Xiang wrote:

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Suhas Satish
On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 326 https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line326 Can we use SPARKHASHTABLESINK, or something similar? Jimmy Xiang wrote:

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 57 https://reviews.apache.org/r/27933/diff/1/?file=760615#file760615line57 Could we extend from HashTableSinkOperator instead? Jimmy Xiang wrote:

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 326 https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line326 Can we use SPARKHASHTABLESINK, or something similar? Jimmy Xiang wrote:

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Xuefu Zhang
On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 57 https://reviews.apache.org/r/27933/diff/1/?file=760615#file760615line57 Could we extend from HashTableSinkOperator instead? Jimmy Xiang wrote:

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

2014-11-12 Thread Jimmy Xiang
On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, line 326 https://reviews.apache.org/r/27933/diff/2/?file=760734#file760734line326 Can we use SPARKHASHTABLESINK, or something similar? Jimmy Xiang wrote: