Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61300 --- ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperat

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 13, 2014, 7:17 p.m.) Review request for hive, Chao Sun, Szehon Ho

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 326 > > > > > > Can we use "SPARKHASHTABLESINK", or something similar? > > Jimm

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 57 > > > > > > Could we extend from HashTableSinkOperator instead? > > Jimmy

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 326 > > > > > > Can we use "SPARKHASHTABLESINK", or something similar? > > Jimm

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 57 > > > > > > Could we extend from HashTableSinkOperator instead? > > Jimmy

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 326 > > > > > > Can we use "SPARKHASHTABLESINK", or something similar? > > Jimm

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 326 > > > > > > Can we use "SPARKHASHTABLESINK", or something similar? > > Jimm

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 13, 2014, 12:34 a.m., Chao Sun wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperator.java, > > line 274 > > > > > > Don't need this check anymore. That's right. No need for this c

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61150 --- ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperat

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

> On Nov. 12, 2014, 11:47 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/SparkHashTableSinkDesc.java, > > line 34 > > > > > > This class seems to be identiccal to HashTableSinkDesc. Could we ex

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 12, 2014, 11:58 p.m.) Review request for hive, Chao Sun, Szehon H

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/#review61102 --- ql/src/java/org/apache/hadoop/hive/ql/exec/SparkHashTableSinkOperat

Re: Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- (Updated Nov. 12, 2014, 10:35 p.m.) Review request for hive, Chao Sun, Szehon H

Review Request 27933: HIVE-8810 Make HashTableSinkOperator works for Spark Branch [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27933/ --- Review request for hive, Chao Sun and Xuefu Zhang. Bugs: HIVE-8810 https://