Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-06 Thread Jimmy Xiang
On Dec. 5, 2014, 10:40 p.m., Xuefu Zhang wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java, line 121 https://reviews.apache.org/r/28727/diff/1/?file=782892#file782892line121 Be aware of different hadoop versions. I checked. Both hadoop

Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-05 Thread Jimmy Xiang
On Dec. 5, 2014, 2:27 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 96 https://reviews.apache.org/r/28727/diff/1/?file=782893#file782893line96 I'm wondering if we can get rid of containsOp, and replace with this

Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-05 Thread Chao Sun
On Dec. 5, 2014, 2:27 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java, line 111 https://reviews.apache.org/r/28727/diff/1/?file=782895#file782895line111 why check twice here? Jimmy Xiang wrote: estimatedBuckets could

Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-05 Thread Chao Sun
On Dec. 5, 2014, 2:27 a.m., Chao Sun wrote: ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java, line 96 https://reviews.apache.org/r/28727/diff/1/?file=782893#file782893line96 I'm wondering if we can get rid of containsOp, and replace with this

Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-05 Thread Xuefu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28727/#review64093 ---

Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-04 Thread Jimmy Xiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28727/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-8638

Re: Review Request 28727: HIVE-8638 Implement bucket map join optimization [Spark Branch]

2014-12-04 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28727/#review63952 ---