Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Ted Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/ --- (Updated 十二月 10, 2014, 6:09 p.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64582 ---

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Chao Sun
On Dec. 10, 2014, 6:16 p.m., Chao Sun wrote: I don't think optimize_nullscan and vector_decimal_aggregate are related. Ashutosh can correct me if I'm wrong. - Chao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64632 --- Ship it! ya.. those two tests have failed in other runs also. You

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Ted Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/ --- (Updated 十二月 11, 2014, 1:36 a.m.) Review request for hive, Ashutosh Chauhan

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-10 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64666 --- Ship it! Ship It! - Chao Sun On Dec. 11, 2014, 1:36 a.m., Ted

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-09 Thread Ted Xu
On 十二月 8, 2014, 5:27 p.m., Chao Sun wrote: Hi, [~tedxu], thanks for the quick work! I just have one minor question: do you think it would be good to have a new test case for this? Maybe someone that just like join38.q, but uses common join and set number of reducers to be a number

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-09 Thread Ashutosh Chauhan
On Dec. 8, 2014, 5:27 p.m., Chao Sun wrote: Hi, [~tedxu], thanks for the quick work! I just have one minor question: do you think it would be good to have a new test case for this? Maybe someone that just like join38.q, but uses common join and set number of reducers to be a number

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-08 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64242 --- Hi, [~tedxu], thanks for the quick work! I just have one minor

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-08 Thread Chao Sun
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/#review64244 --- Also, some golden files for tez branch need to be updated. - Chao

Re: Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-08 Thread Ashutosh Chauhan
On Dec. 8, 2014, 5:27 p.m., Chao Sun wrote: Hi, [~tedxu], thanks for the quick work! I just have one minor question: do you think it would be good to have a new test case for this? Maybe someone that just like join38.q, but uses common join and set number of reducers to be a number

Review Request 28791: HIVE-9025 join38.q (without map join) produces incorrect result when testing with multiple reducers

2014-12-07 Thread Ted Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28791/ --- Review request for hive, Ashutosh Chauhan and Chao Sun. Bugs: HIVE-9025