Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-07-06 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/#review90459 --- Ship it! Ship It! - Vaibhav Gumashta On June 30, 2015, 1:39

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-30 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/ --- (Updated June 30, 2015, 1:39 p.m.) Review request for hive. Repository:

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-29 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/#review89749 ---

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-29 Thread Aihua Xu
On June 29, 2015, 4:55 p.m., Chaoyu Tang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 3477 https://reviews.apache.org/r/35803/diff/3/?file=993090#file993090line3477 Do we have to use a list of queryWrappers with each wrapper for a different

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-29 Thread Aihua Xu
On June 29, 2015, 4:55 p.m., Chaoyu Tang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 3485 https://reviews.apache.org/r/35803/diff/3/?file=993090#file993090line3485 Should listPrincipalGlobalGrants be passed in a queryWrapper as well? Aihua

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-29 Thread Chaoyu Tang
On June 29, 2015, 4:55 p.m., Chaoyu Tang wrote: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java, line 3477 https://reviews.apache.org/r/35803/diff/3/?file=993090#file993090line3477 Do we have to use a list of queryWrappers with each wrapper for a different

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-26 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/ --- (Updated June 26, 2015, 5:23 p.m.) Review request for hive. Repository:

Re: Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-24 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/ --- (Updated June 24, 2015, 3:13 p.m.) Review request for hive. Repository:

Review Request 35803: HIVE-10895 ObjectStore does not close Query objects in some calls, causing a potential leak in some metastore db resources

2015-06-23 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35803/ --- Review request for hive. Repository: hive-git Description ---