Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

> On Sept. 12, 2015, 1:23 a.m., Szehon Ho wrote: > > I dont know if you saw in the earlier comments, please add a test to the > > file 'FolderPermissionBase' to verify permission inheritance works with the > > feature. Sorry, overlooked the comments. I added a test to cover this. The fix resp

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/ --- (Updated Sept. 12, 2015, 4:07 a.m.) Review request for hive, Chao Sun, Szehon H

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/#review98723 --- I dont know if you saw in the earlier comments, please add a test to

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

> On Sept. 10, 2015, 6:02 p.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 2552 > > > > > > I think this whole method can be moved to FileUtils for organiz

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/ --- (Updated Sept. 11, 2015, 1:02 p.m.) Review request for hive, Chao Sun, Szehon H

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/#review98547 --- Publishing again as it did not send the email, I added some more com

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

> On Sept. 10, 2015, 6:02 p.m., Szehon Ho wrote: > > Please make sure that file permission inheritance works for this feature > > (see HadoopShims.getFullFileStatus and HadoopShims.setFullFileStatus). And > > please add a test to FolderPermissionBase after you verified it? Please make sure to

Re: Review Request 38216: HIVE-11745: Alter table Exchange partition with multiple partition_spec is not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38216/ --- (Updated Sept. 10, 2015, 7:36 p.m.) Review request for hive, Chao Sun, Szehon H