Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-30 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/#review101149 --- Ship it! Ship It! - Prasanth_J On Sept. 30, 2015, 8:29 p.m., Se

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/ --- (Updated Sept. 30, 2015, 8:29 p.m.) Review request for hive and Prasanth_J. R

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-30 Thread j . prasanth . j
> On Sept. 30, 2015, 5:16 p.m., Prasanth_J wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 5750 > > > > > > MB copy is insanely fast (~12x) when compared to reflect. Foll

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-30 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/#review101132 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-29 Thread Sergey Shelukhin
> On Sept. 30, 2015, 12:27 a.m., Gopal V wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 5751 > > > > > > Wrap this with a ByteBuffer impl of your own instead of doing >

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-29 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/#review101051 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-29 Thread Sergey Shelukhin
> On Sept. 24, 2015, 6:57 a.m., Prasanth_J wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 5750 > > > > > > This is very hacky. > > I think reflection will be slower

Re: Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-23 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/#review100363 --- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.

Review Request 38702: HIVE-11553 use basic file metadata cache in ETLSplitStrategy-related paths

2015-09-23 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38702/ --- Review request for hive and Prasanth_J. Repository: hive-git Description