Re: Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40785/#review108573 --- Looks ok to me. Just some questions.

Re: Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40785/#review108582 --- Ship it! Ship It! - Jimmy Xiang On Nov. 29, 2015, 5:47 p.m.,

Re: Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format

> On Dec. 1, 2015, 10:45 p.m., Jimmy Xiang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 2128 > > > > > > If this is the only statement in the block, can we merge two if > > statements

Re: Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format

> On Dec. 1, 2015, 10:45 p.m., Jimmy Xiang wrote: > > ql/src/test/results/clientpositive/show_create_table_delimited.q.out, line > > 36 > > > > > > Now we expose those serde properties names. This is ok, right? I

Review Request 40785: HIVE-12506: SHOW CREATE TABLE command creates a table that does not work for RCFile format

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40785/ --- Review request for hive. Repository: hive-git Description --- More than