Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-06 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/ --- (Updated March 7, 2016, 12:19 p.m.) Review request for hive and Alan Gates. B

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-03 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121822 --- Ship it! Make sure all occurrences of HiveConf.ConfVars.HIVEQUE

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-03 Thread Rajat Khandelwal
> On March 3, 2016, noon, Amareshwari Sriramadasu wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 142 > > > > > > Required any more? Removed. - Rajat --

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-03 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/ --- (Updated March 3, 2016, 1:29 p.m.) Review request for hive and Alan Gates. Bu

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-02 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121807 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-01 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/ --- (Updated March 2, 2016, 11:31 a.m.) Review request for hive and Alan Gates. B

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-01 Thread Rajat Khandelwal
> On March 1, 2016, 1:58 p.m., Amareshwari Sriramadasu wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 141 > > > > > > I see adding a factory is giving the flexibility of using encoder for

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-03-01 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/#review121409 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1

Re: Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-02-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/ --- (Updated March 1, 2016, 1:09 p.m.) Review request for hive and Alan Gates. Bu

Review Request 44172: HIVE-11483: Add encoding and decoding for query string config

2016-02-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44172/ --- Review request for hive. Bugs: HIVE-11483 https://issues.apache.org/jira/br