Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-04-27 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/ --- Review request for hive and Siddharth Seth. Repository: hive-git Description

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-04-27 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review130862 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-04-30 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review131247 --- llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Task

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
> On April 30, 2016, 7:06 a.m., Siddharth Seth wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java, > > line 192 > > > > > > If we're using a common UGI across all tasks -

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/ --- (Updated May 2, 2016, 9:44 p.m.) Review request for hive and Siddharth Seth.

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review131384 --- ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-03 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review131507 --- Fix it, then Ship it! Looks good in terms of functionality. (Sh

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-03 Thread Sergey Shelukhin
> On May 3, 2016, 3:14 p.m., Siddharth Seth wrote: > > Looks good in terms of functionality. (Ship it if you think the reflection > > is not super brittle :)) > > I think we should get rid of the reflection to access private methods ASAP > > though - it can be really brittle and cause difficult

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-03 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/ --- (Updated May 3, 2016, 9:07 p.m.) Review request for hive and Siddharth Seth.

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-19 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/ --- (Updated May 20, 2016, 1:49 a.m.) Review request for hive and Siddharth Seth.

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-23 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review134432 --- Any possibility of simple unit tests ? llap-server/src/java/org/

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-27 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/ --- (Updated May 28, 2016, 2:04 a.m.) Review request for hive and Siddharth Seth.

Re: Review Request 46754: HIVE-13391 add an option to LLAP to use keytab to authenticate to read data

2016-05-31 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46754/#review135722 --- Ship it! Ship It! - Siddharth Seth On May 28, 2016, 2:04 a.m