Re: Review Request 48771: HIVE-13590: Kerberized HS2 with LDAP auth enabled fails in multi-domain LDAP case

2016-06-20 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48771/#review138670 --- Ship it! Ship It! - Sergio Pena On June 16, 2016, 2:33

Re: Review Request 48771: HIVE-13590: Kerberized HS2 with LDAP auth enabled fails in multi-domain LDAP case

2016-06-16 Thread Chaoyu Tang
> On June 16, 2016, 3:01 p.m., Sergio Pena wrote: > > The code looks good for me. > > > > What other tests did you do to validate this code? > > - HS2 with KERBEROS + LDAP? > > - HS2 with KERBEROS only? > > - HS2 with LDAP only? The unit tests cover the cases: 1. HS2 with kerberos + SASL

Re: Review Request 48771: HIVE-13590: Kerberized HS2 with LDAP auth enabled fails in multi-domain LDAP case

2016-06-16 Thread Sergio Pena
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48771/#review137988 --- Fix it, then Ship it! The code looks good for me. What other

Review Request 48771: HIVE-13590: Kerberized HS2 with LDAP auth enabled fails in multi-domain LDAP case

2016-06-15 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48771/ --- Review request for hive. Bugs: HIVE-13590