Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156738 --- The patch looks good to me. We probably want to add a integration

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156659 --- The latest patch solved all the issues Illya Yalovyy pointed out,

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/ --- (Updated Nov. 22, 2016, 10:35 p.m.) Review request for hive. Changes ---

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

> On Nov. 22, 2016, 9:30 p.m., Illya Yalovyy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2789 > > > > > > Scalability concern: > > > > On some real datasets, it could be

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

> On Nov. 22, 2016, 9:30 p.m., Illya Yalovyy wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2953 > > > > > > is "copy" part of the file name misleading? It is not actually a copy > > of

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156644 --- Ship it! Ship It! - Yongzhi Chen On Nov. 21, 2016, 11:54

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156629 --- common/src/java/org/apache/hadoop/hive/common/FileUtils.java

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

> On Nov. 22, 2016, 9:27 p.m., Yongzhi Chen wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2983 > > > > > > if (isBlobStoragePath && !destFs.exists(destFilePath) > > then the second

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156639 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/ --- (Updated Nov. 21, 2016, 11:54 p.m.) Review request for hive. Changes ---

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

> On Nov. 21, 2016, 10:48 p.m., Aihua Xu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2789 > > > > > > Do you think that will be a performance impact for HDFS if there are > > many

Re: Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156517 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line

Review Request 53966: HIVE-15199: INSERT INTO data on S3 is replacing the old rows with the new ones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/ --- Review request for hive. Bugs: HIVE-15199