Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Matt McCline
> On Feb. 7, 2017, 2:31 a.m., Owen O'Malley wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 360 > > > > > > You need braces around your control block for break. > > > >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Feb. 8, 2017, 1:10 a.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Owen O'Malley
> On Feb. 7, 2017, 2:31 a.m., Owen O'Malley wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 360 > > > > > > You need braces around your control block for break. > > > >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Sergey Shelukhin
> On Feb. 7, 2017, 2:31 a.m., Owen O'Malley wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 360 > > > > > > You need braces around your control block for break. > > > >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Owen O'Malley
> On Feb. 7, 2017, 2:31 a.m., Owen O'Malley wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 360 > > > > > > You need braces around your control block for break. > > > >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Feb. 7, 2017, 6:35 p.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-07 Thread Sergey Shelukhin
> On Feb. 7, 2017, 2:31 a.m., Owen O'Malley wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java, line 360 > > > > > > You need braces around your control block for break. > > > >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-06 Thread Owen O'Malley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/#review164437 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Feb. 7, 2017, 12:03 a.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-02 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Feb. 3, 2017, 2:52 a.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-02 Thread Sergey Shelukhin
> On Feb. 3, 2017, 1:16 a.m., Prasanth_J wrote: > > orc/src/java/org/apache/orc/impl/WriterImpl.java, line 2323 > > > > > > seems not required. where is the dereference happening? > > Sergey Shelukhin wrote: >

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-02 Thread Sergey Shelukhin
> On Feb. 3, 2017, 1:16 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java, > > line 175 > > > > > > nit: typo VertorDeserializeOrcWriter > > Is

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-02-02 Thread j . prasanth . j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/#review163695 ---

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-01-31 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Feb. 1, 2017, 3:34 a.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-01-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Jan. 31, 2017, 1:17 a.m.) Review request for hive, Gopal V and

Re: Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-01-26 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- (Updated Jan. 27, 2017, 3:17 a.m.) Review request for hive, Gopal V and

Review Request 55977: HIVE-15672 LLAP text cache: improve first query perf II

2017-01-25 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/ --- Review request for hive, Gopal V and Prasanth_J. Repository: hive-git