Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-20 Thread Yongzhi Chen
> On April 19, 2017, 5:50 p.m., Chaoyu Tang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java > > Lines 46 (patched) > > > > > > To be honest, I am not very comfortable to import the Driv

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-19 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58456/#review172374 --- ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.j

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-18 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58456/#review172209 --- Ship it! Ship It! - Aihua Xu On April 14, 2017, 1:14 p.m., Y

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-18 Thread Aihua Xu
> On April 14, 2017, 5:43 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > > Lines 399 (patched) > > > > > > I'm not exactly following what we are doing here. Not s

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-14 Thread Yongzhi Chen
> On April 14, 2017, 5:43 p.m., Aihua Xu wrote: > > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > > Lines 399 (patched) > > > > > > I'm not exactly following what we are doing here. Not s

Re: Review Request 58456: Query cancel: improve the way to handle files

2017-04-14 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58456/#review172009 --- service/src/java/org/apache/hive/service/cli/operation/SQLOperati

Review Request 58456: Query cancel: improve the way to handle files

2017-04-14 Thread Yongzhi Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58456/ --- Review request for hive, Aihua Xu, Chaoyu Tang, and Sergio Pena. Bugs: HIVE-164