Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-14 Thread Adam Szita via Review Board
> On April 9, 2020, 9:09 a.m., Adam Szita wrote: > > Ship It! Committed. This can be closed. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220266 ---

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-09 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220266 --- Ship it! Ship It! - Adam Szita On April 6, 2020, 10:04 a.m.,

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-06 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/ --- (Updated April 6, 2020, 10:04 a.m.) Review request for hive and Adam Szita. R

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-04-01 Thread Peter Varga via Review Board
> On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithServiceDiscovery.java > > Lines 94 (patched) > > > > > > Can be private if not used elsewhere I re

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-30 Thread Peter Varga via Review Board
> On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > Looking pretty good overall, I just have a few questions/comments. I fixed the issues, added a little more logging and fixed the weird annotation formatting. > On March 30, 2020, 9:38 a.m., Adam Szita wrote: > > service/src/java/org/apache

Re: Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-30 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/#review220102 --- Looking pretty good overall, I just have a few questions/comments.

Review Request 72276: HIVE-23084: Implement kill query in multiple HS2 environment

2020-03-27 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72276/ --- Review request for hive and Adam Szita. Repository: hive-git Description