Review requests & JIRA process

2014-08-05 Thread Lars Francke
Hi everyone, I have a couple of review requests that I'd love for someone to look at. I'll list them below. I have however two more questions. Two of my issues are clean ups of existing code (HIVE-7622 & HIVE-7543). I realize that they don't bring immediate benefit and I had planned to fix some m

Re: Review requests & JIRA process

2014-08-07 Thread Lars Francke
Hey, just wanted to bump this in case anyone has any opinions as well as what the procedure is for patches that don't get a review for a longer period of time. I'd like to avoid a lot of unnecessary work on my end :) Cheers, Lars On Wed, Aug 6, 2014 at 1:15 AM, Lars Francke wrote: > Hi everyo

Re: Review requests & JIRA process

2014-08-07 Thread Sergey Shelukhin
I think the process that works best for getting patches reviewed is adding specific people to RB/JIRA and asking, usually the people who are active in a related area of code. And nagging them until they either review or refuse to review :) On Thu, Aug 7, 2014 at 4:31 AM, Lars Francke wrote: > H

Re: Review requests & JIRA process

2014-08-17 Thread Lars Francke
Thanks Sergey, unfortunately it's often not easy to figure that out but I'll try. So, anyone willing to do reviews on these: These are the issues in need of reviews: * (huge but I'd appreciate an answer fast to avoid having to rebase it often) *