Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-18 Thread Lars Francke
Hi everyone, could a few more PMC members please head over to the user@ mailing list and vote? Thank you! On Thu, Apr 14, 2016 at 9:14 AM, Lars Francke wrote: > Okay I have started a VOTE thread on the user@ mailing list (as per the > bylaws). I would appreciate it if you could head over there

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-14 Thread Lars Francke
Okay I have started a VOTE thread on the user@ mailing list (as per the bylaws). I would appreciate it if you could head over there and vote :) Thank you! On Thu, Apr 14, 2016 at 12:41 AM, Lars Francke wrote: > Thanks for the +1 Alan. > > I agree that we're leaving potential contributions on th

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-13 Thread Lars Francke
Thanks for the +1 Alan. I agree that we're leaving potential contributions on the floor. Doing more reviews is definitely a very good step in the right direction. Thank you! I see this Bylaws change as another (small) step in the right direction. I'm sure we can come up with more ideas. I'll star

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-12 Thread Alan Gates
I’m +1 on this change of allowing simple cleanup changes without requiring a full review. But jumping to this fix obscures a bigger problem we have as a community. This fix only works for committers, not for non-committers who may also contribute such patches. And it doesn’t solve the situa

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Lars Francke
Thanks Thejas for the suggestion & others for jumping in. That seems fine for me. 2 days also seems good. Holidays are different in almost every country so I wouldn't exclude those. I have followed the procedure used for the last Bylaws change and created a new Wiki page here: < https://cwiki.apac

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Sergey Shelukhin
2 days may be too short… One can submit all the patches on Friday night and commit on Sunday ;) On 16/4/11, 17:43, "Prasanth Jayachandran" wrote: >Also, it will be good to add “NO PRECOMMIT TESTS” in the description of >the jira >if the patches are really small and does not affect any tests >(ch

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Prasanth Jayachandran
Also, it will be good to add “NO PRECOMMIT TESTS” in the description of the jira if the patches are really small and does not affect any tests (checkstyles, typos etc.) to avoid occupying a slot in the precommit queue which could be overloaded sometimes. +1 for 2 days no response on dev-list. T

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Lefty Leverenz
> > Maybe the process can be to solicit reviews for such minor patches by > sending an email to dev@ list and if no response is seen in 2 days, go > ahead and commit it ? > Two days seems reasonable, perhaps excluding weekends and major holidays. -- Lefty On Mon, Apr 11, 2016 at 1:26 PM, Thejas

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Thejas Nair
I agree we have a problem here. At least patches as small as this shouldn't take too long to get reviewed. Knox seems to consider a very large set of patches as being under CTR process. I think hive is very large and mature project that I would lean towards RTC process for most issues. I think we

Re: Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Jörn Franke
Hi Lars, I think this is a valid concern and your proposal sounds good to me. Best regards > On 11 Apr 2016, at 15:38, Lars Francke wrote: > > Hi, > > I've been a long-time contributor to Hive (5 or so years) and have been > voted in as a committer and I'm very grateful for that. I also unde

Reviews & commits (RTC/CTR), contributions, bylaws

2016-04-11 Thread Lars Francke
Hi, I've been a long-time contributor to Hive (5 or so years) and have been voted in as a committer and I'm very grateful for that. I also understand that my situation is different than most or lots of committers as I'm not working for one of the big companies (Facebook, Cloudera, Hortonworks etc.