[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635591#comment-13635591
]
Eric Hanson commented on HIVE-4284:
---
New diff available for review at
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635597#comment-13635597
]
Carl Steinbach commented on HIVE-4284:
--
+1
Implement class for
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634300#comment-13634300
]
Eric Hanson commented on HIVE-4284:
---
Code review link:
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634431#comment-13634431
]
Eric Hanson commented on HIVE-4284:
---
Disregard above code review link. Instead please use
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634484#comment-13634484
]
Carl Steinbach commented on HIVE-4284:
--
I left some comments on reviewboard.
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13634742#comment-13634742
]
Eric Hanson commented on HIVE-4284:
---
Uploaded new diff to review tool at
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13633605#comment-13633605
]
Carl Steinbach commented on HIVE-4284:
--
Hive's coding conventions are described here:
[
https://issues.apache.org/jira/browse/HIVE-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631971#comment-13631971
]
Jitendra Nath Pandey commented on HIVE-4284:
A few comments on the patch.
-