Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Cliff Woolley
On Tue, 9 Dec 2003, Greg Stein wrote: > This is where process gets in the way of just doing the right thing. > Backport it for chrissakes. amen.

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Greg Stein
This is where process gets in the way of just doing the right thing. Backport it for chrissakes. -g On Tue, Dec 09, 2003 at 06:39:58PM -0800, Stas Bekman wrote: > Stas Bekman wrote: > > > Here is an adjusted patch, I've s/include/INCLUDES/ in your suggestion. > > Now committed. please +1 to bac

Re: cvs commit: httpd-2.0/modules/experimental cache_cache.c mod_mem_cache.c

2003-12-09 Thread Cliff Woolley
On Tue, 10 Dec 2003 [EMAIL PROTECTED] wrote: > --- mod_mem_cache.c 4 Dec 2003 00:16:13 - 1.98 > +++ mod_mem_cache.c 10 Dec 2003 03:22:32 - 1.99 > @@ -240,7 +240,7 @@ >cache_object_t *obj = (cache_object_t *)a; >mem_cache_object_t *mobj = obj->vobj; >

Re: mod_mem_cache & pools

2003-12-09 Thread Bill Stoddard
Ian Holsman wrote: hi. I was wondering if the queue/hash routines in mod-mem-cache could be reverted to using the pool based ones, instead of the malloc-based ones. and possibly change some of the object creation to pool based as well. this would leave the headers/content as malloc'd 2 reason

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Stas Bekman
Stas Bekman wrote: Here is an adjusted patch, I've s/include/INCLUDES/ in your suggestion. Now committed. please +1 to backport in STATUS so we can move on... Index: modules/filters/mod_include.c === RCS file: /home/cvs/httpd-2.0/mod

mod_mem_cache & pools

2003-12-09 Thread Ian Holsman
hi. I was wondering if the queue/hash routines in mod-mem-cache could be reverted to using the pool based ones, instead of the malloc-based ones. and possibly change some of the object creation to pool based as well. this would leave the headers/content as malloc'd 2 reasons I can see for this

RE: Mem Leak when reverse proxying HTTP post requests (slightly o ff-topic)

2003-12-09 Thread Conti, Chris
Any chance you could take a peek at the patch I submitted for bug 19954 (HTTP tunneling through reverse proxy does not always work) as long as you are looking at that source file? BTW when I submitted the patch I bone-headedly swapped the params to diff so the changes show as '-' instead of '+'

Re: [PATCH] catching malformed container directives

2003-12-09 Thread Geoffrey Young
William A. Rowe, Jr. wrote: > At 09:36 AM 12/9/2003, Geoffrey Young wrote: > >>>André Malo wrote: >>> I'd like to keep possible. Simply because it's a very efficient way to comment a whole part out (reliably, since one cannot specify an empty -D argument). And it's in use out there.

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Stas Bekman
William A. Rowe, Jr. wrote: At 12:37 PM 12/9/2003, Stas Bekman wrote: Does this look good? ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, "mod_include: Options +Includes (or IncludesNoExec) " - "wasn't set, passing data unmodified"); +

Apache2.0.48: Bug in sdbm on Alpha?

2003-12-09 Thread Marc Giger
Hi Developers! I'm not sure but I think there is a bug in the sdbm module. The same code runs fine on intel hardware but not on my alpha. I found this by running subversion which calls apr_dbm_* and like functions. Every time subversion calls apr_dbm_exists(dbm, key) this funtion returns false (

RE: Mem Leak when reverse proxying HTTP post requests

2003-12-09 Thread Cliff Woolley
On Tue, 9 Dec 2003, Larry Toppi wrote: > I found the culprit. The EOS bucket was being removed from the brigade but > not destroyed. I'm going to submit the following patch to fix this bug. > > *** proxy_http_old.c Tue Dec 9 16:19:52 2003 > --- proxy_http.c Tue Dec 9 16:22:14 2003 > **

RE: Mem Leak when reverse proxying HTTP post requests

2003-12-09 Thread Larry Toppi
I found the culprit.  The EOS bucket was being removed from the brigade but not destroyed.  I'm going to submit the following patch to fix this bug.   *** proxy_http_old.c Tue Dec  9 16:19:52 2003 --- proxy_http.c Tue Dec  9 16:22:14 2003 *** *** 665,671  

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread William A. Rowe, Jr.
At 12:37 PM 12/9/2003, Stas Bekman wrote: >Does this look good? > > ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, > "mod_include: Options +Includes (or IncludesNoExec) " >- "wasn't set, passing data unmodified"); >+ "wasn't s

Re: [PATCH 25137] atomics in worker mpm

2003-12-09 Thread Brian Akins
Jeff Trawick wrote: Brian Akins wrote: Backported from 2.1. Stable for me in various loads. without the non-portable atomic code available and enabled in APR, this is going to hurt performance, right? (more mutex operations performed in mainline path for the unlucky who use the non-portable

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Jeff Trawick
Stas Bekman wrote: Does this look good? Index: modules/filters/mod_include.c === RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v retrieving revision 1.291 diff -u -r1.291 mod_include.c --- modules/filters/mod_include.c

Re: [PATCH 25137] atomics in worker mpm

2003-12-09 Thread Jeff Trawick
Brian Akins wrote: Backported from 2.1. Stable for me in various loads. without the non-portable atomic code available and enabled in APR, this is going to hurt performance, right? (more mutex operations performed in mainline path for the unlucky who use the non-portable atomics???) is it not

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Stas Bekman
Stas Bekman wrote: Jeff Trawick wrote: [...] &include_module); if (!(ap_allow_options(r) & OPT_INCLUDES)) { +ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, + "mod_include: Options +Includes (or IncludesNoExec) " + "wasn't set, passi

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Stas Bekman
Jeff Trawick wrote: [EMAIL PROTECTED] wrote: complain via error_log when mod_include's INCLUDES filter is enabled, but the relevant Options flag allowing the filter to run for the specific resource wasn't set, so that the filter won't silently get skipped. Index: mo

Re: [PATCH] catching malformed container directives

2003-12-09 Thread William A. Rowe, Jr.
At 09:36 AM 12/9/2003, Geoffrey Young wrote: >> >> André Malo wrote: >>> >>>I'd like to keep possible. Simply because it's a very efficient >>>way to comment a whole part out (reliably, since one cannot specify an >>>empty -D argument). And it's in use out there. > >ok, here is a new patch that e

Re: Apache MPMs comparing new fds with FD_SETSIZE, APR's ability to wait for i/o on socket

2003-12-09 Thread David Reid
> Currently when Apache httpd accepts a new connection via APR, it compares the > fd with FD_SETSIZE and bombs if fd >= FD_SETSIZE. > > The limited value of this check is on platforms such as OS X < 10.3 with no > poll(), where APR has to use select(). Unfortunately, use 1K threads with > worker M

Re: [PATCH] catching malformed container directives

2003-12-09 Thread Geoffrey Young
Geoffrey Young wrote: > > André Malo wrote: > >>* Geoffrey Young <[EMAIL PROTECTED]> wrote: >> >> >> >>>anyway, attached is a patch that makes , , >> >> >>I'd like to keep possible. Simply because it's a very efficient >>way to comment a whole part out (reliably, since one cannot specify an >>

Apache MPMs comparing new fds with FD_SETSIZE, APR's ability to wait for i/o on socket

2003-12-09 Thread Jeff Trawick
Currently when Apache httpd accepts a new connection via APR, it compares the fd with FD_SETSIZE and bombs if fd >= FD_SETSIZE. The limited value of this check is on platforms such as OS X < 10.3 with no poll(), where APR has to use select(). Unfortunately, use 1K threads with worker MPM on So

Re: completing 2.0 scoreboard data set

2003-12-09 Thread Jeff Trawick
Stas Bekman wrote: - httpd 2.0 doesn't maintain start/stop times in the extended status mode add it - while vhost info was added, it doesn't contain the port info, rendering the vhost record useless for the non named vhosts. any objections to adding it? none from me Should it be in a separate

Re: cvs commit: httpd-2.0 CHANGES

2003-12-09 Thread Jeff Trawick
[EMAIL PROTECTED] wrote: complain via error_log when mod_include's INCLUDES filter is enabled, but the relevant Options flag allowing the filter to run for the specific resource wasn't set, so that the filter won't silently get skipped. Index: mod_include.c ===