Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Graham Leggett
Brad Nicholes wrote: It appears to me that if it doesn't handle low memory situations or it is giving false positives, those are separate issues from pools vs. calloc/free. I still think we need to implement some better monitoring or logging code in the cache_mgr and enhance the cache-status pa

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread William A. Rowe, Jr.
The proper logic to add to a cache is wrlock test if exists again add element unlock because there is a race condition in the logic below rdlock test if the element exists >> race is here, prior to wrlocking, another thread may wrlock->insert promote to wrlock insert unlock

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Greg Marr
At 12:33 PM 6/11/2004, William A. Rowe, Jr. wrote: The proper logic to add to a cache is wrlock test if exists again add element unlock because there is a race condition in the logic below rdlock test if the element exists >> race is here, prior to wrlocking, another thread may wrlock->inser

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Matthieu Estrade
Hi, I am not sure about what i will say, but i think all these mutex are broken. when i did that, i think i used apr_thread_mutex_create which use a pool (st->pool) which is the server pool. This function is to use in a child, not between all forked child. When it create the mutex, it do a apr_pc

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Jim Jagielski
I could be completely confused here, but isn't this (a shared cache) already something we have a framework for in mod_ssl? Not that what's *in* mod_ssl (well, the *scache* files) is the solution for ldap, but the particulars design and logic flow certainly should work, right?

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Matthieu Estrade
mod_ssl mutex are totally different. global mutex are used. Actually, the mutex is in the module_conf, so i think when apache fork childs, this mutex is no more valid, and each child will have a value for it. There is also in util_ldap.c, apr_thread_mutex_create(&st->mutex, APR_THREAD_MUTEX_DEFA

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Brad Nicholes
>After speaking many times about this problem on #apache-modules, Paul >Querna said that it would be better to port mod_auth_ldap to >mod_authn_ldap, and do module caching auth, for all authentication >method. I am sure this way is really better and i agree with him. I know >he started this cac

Re: cvs commit: httpd-2.0/support rotatelogs.c

2004-06-11 Thread Jeff Trawick
[EMAIL PROTECTED] wrote: coar2004/06/11 14:43:58 Modified:support rotatelogs.c Log: add "-l" option to indicate interval is based on localtime not gmt a CHANGES entry would be good also, I guess this is exactly the feature requested/implemented in PR 24417? http://issues.apache.o

Re: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread William A. Rowe, Jr.
At 04:41 PM 6/11/2004, Brad Nicholes wrote: >I am sure that we can take advantage of what has been done in mod_ssl and >other places that have to mutex protect shared memory. It is actually working >great on NetWare at the moment but then we don't use shared memory and >we are multi-threaded only

FW: util_ldap [Bug 29217] - Remove references to calloc()and free()

2004-06-11 Thread Mathihalli, Madhusudan
I'm forwarding on behalf of my collegue (as his mails are not reaching the list) -Madhu >-Original Message- >From: CHOU,TAIR-SHIAN (HP-Cupertino,ex1) >[mailto:[EMAIL PROTECTED] >Sent: Friday, June 11, 2004 7:04 PM >To: Mathihalli, Madhusudan >Subject: FW: util_ldap [Bug 29217] - Remove

FW: util_ldap [Bug 29217] - Remove references to calloc() and free()

2004-06-11 Thread Mathihalli, Madhusudan
Another mail.. -Madhu >-Original Message- >From: CHOU,TAIR-SHIAN (HP-Cupertino,ex1) >[mailto:[EMAIL PROTECTED] >Sent: Friday, June 11, 2004 7:05 PM >To: Mathihalli, Madhusudan >Subject: FW: util_ldap [Bug 29217] - Remove references to >calloc() and free() > > > >-Original Message-