PATCH: various mod_proxy issues

I've rolled a fairly extensive mod_proxy patch, which seems rather big to commit without review. Comments please: (1) Bug #10722 - cookie paths and domains in reverse proxy Following my patch to 2.0.49, I've adapted it for 2.1, taking into account Jim's patch. In doing so, I made some organisa

Re: URI lossage with ProxyPass

On Thu, 17 Jun 2004, Francois-Rene Rideau wrote: [ message quoted in full and crossposted to [EMAIL PROTECTED] ] > I have experienced quite some trouble due to design bugs in ProxyPass, > and have proposed a patch for apache 1.3. > The very same bugs are present in apache 2.0, and a similar fix c

Re: Proxy Cookie Support (Bug #10722)

On Fri, 25 Jun 2004, Jim Jagielski wrote: >So the > > apr_table_do(addit_dammit, save_table, r->err_headers_out, > "Set-Cookie", NULL); > > line should be removed. OK, that's what I needed to know. I'll still have to modify my patch slightly to work

Re: Apache HTTP Server 2.0.50-rc2 tarballs available for testing

William A. Rowe, Jr. wrote: Refer to http://www.apache.org/dev/apply-license.html --- especially; To apply the ALv2 to a new software distribution, include one copy of the license text by copying the file: http://www.apache.org/licenses/LIC

Re: Apache HTTP Server 2.0.50-rc2 tarballs available for testing

On Thu, Jun 24, 2004 at 05:13:45PM +0200, Sander Striker wrote: > > From: Andre Schild [mailto:[EMAIL PROTECTED] > > As there are no other problem reportts, it's time to tag RC3 ? > > Correct. Can you pull in the latest apr_file_info.h from the 0.9 branch when you retag to pick up the setuid/set

Re: Proxy Cookie Support (Bug #10722)

Joe Schaefer wrote: > > Just to be sure we're on the same page- you agree here that HEAD > will erroneously produce duplicates of any "Set-Cookie" headers > in the proxy server's r->err_headers_out table. > Sure looks like that :) It does not appear that err_headers_out is cleared in the proxy l

Re: Proxy Cookie Support (Bug #10722)

Jim Jagielski <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: > > > > But is the err_headers_out logic in proxy_http.c HEAD really ok? > > It appears to put a copy of r->err_headers_out into r->headers_out, > > so I'm wondering why this doesn't produce duplicates in the final > > response (ie.

Re: Proxy Cookie Support (Bug #10722)

On Jun 25, 2004, at 9:36 AM, Nick Kew wrote: OK, on further consideration after posting, I've reached the view that the 2.0.49 patch should be modified. I'd propose to run the same transformations on Set-Cookie headers from the backend, but move the rewriting - along with the rewriting of Date and

Re: Proxy Cookie Support (Bug #10722)

Joe Schaefer wrote: > > But is the err_headers_out logic in proxy_http.c HEAD really ok? > It appears to put a copy of r->err_headers_out into r->headers_out, > so I'm wondering why this doesn't produce duplicates in the final > response (ie. doesn't httpd add r->err_headers_out itself, in > ap_ht

Re: Proxy Cookie Support (Bug #10722)

On 25 Jun 2004, Joe Schaefer wrote: > Jim Jagielski <[EMAIL PROTECTED]> writes: > > > Nick Kew wrote: > > [...] > > > > It appears just to merge Set-Cookie headers in r->err_headers_out with > > > those in r->headers_out. The latter have just come from the backend > > > (the server proxied). But

Re: Antw: query regarding Apache bandwidth requirements

My test-bed is 100Mbps links, so you're reasoning sounds correct. And you're right - I don't want to regulate the spike. I just wanted to understand why it was happening. Thanks for the explanation. Cheers, Jesse --- Graham Leggett <[EMAIL PROTECTED]> wrote: > Jesse Kielthy wrote: > > > Do you

Re: [1.3 PATCH] restore failing errno for Win32 spawn errors

+1 Looks like an oversite that this patch wasn't applied long ago. The pattern of saving the errno of an earlier operation then restoring it on error exit is repeated all over alloc.c. Bill eff Trawick wrote: When COMSPEC is unset or set to something bogus, trying to start Apache with a piped lo

Re: Proxy Cookie Support (Bug #10722)

Jim Jagielski <[EMAIL PROTECTED]> writes: > Nick Kew wrote: [...] > > It appears just to merge Set-Cookie headers in r->err_headers_out with > > those in r->headers_out. The latter have just come from the backend > > (the server proxied). But how/why should there be (any) cookies in > > r->err

Re: Antw: query regarding Apache bandwidth requirements

Jesse Kielthy wrote: Do you know a reason why there is a 3MB peak at the start? Is it something to do with Server set-up connection requirements? The 3MB peak is probably caused by your test running over a fast network. Apache will send as much data as your client is willing to receive, and in thi

Re: [PROPOSAL] cgi_exec_info_t: detached & addrspace fieldscombined

> To replace the addrspace field that was added in the cgi_exec_info_t > struct in mod_cgi.h I will like to propose extending the use of the > detached (apr_int32_t) field in cgi_exec_info_t and apr_procattr_t > structs. > Currently that field is set to 0 by default and 1 if the process to be >

Re: Antw: query regarding Apache bandwidth requirements

Hi André, I had thought that, but I just wanted to be sue. Do you know a reason why there is a 3MB peak at the start? Is it something to do with Server set-up connection requirements? Rgds, Jesse --- Andre Schild <[EMAIL PROTECTED]> wrote: > Don't you think, > > that the client is filling up

Re: Proxy Cookie Support (Bug #10722)

Nick Kew wrote: > > > I recently patched bug 10722. My patch was against 2.0.49, for a Client > who needed it in a hurry. > > I'm just porting it to 2.1-HEAD. In doing so, I find there's an existing > patch that saves and restores cookies without rewriting the Domain and > Path components. AF

[1.3 PATCH] restore failing errno for Win32 spawn errors

When COMSPEC is unset or set to something bogus, trying to start Apache with a piped logger configured results in the messages ap_spawn_child: Bad file descriptor Couldn't fork child for piped log process The "Bad file descriptor" issue may indicate a problem in the cleanup logic, but it hides t

Antw: query regarding Apache bandwidth requirements

Don't you think, that the client is filling up it's buffer, and the after it's full just stream what it has played ? André aarboard ag internet - networks - screen&print design - multimedia Egliweg 10 - Postfach 214 - CH-2560 Nidau (Switzerland) Phone +41 32 332 9714 - Fax +41 32 332 9715 www.aa

query regarding Apache bandwidth requirements

Hi, I have an Apache2 server that streams video to a VLC client. I have used NeTraMet to capture the traffic and used this data to draw the traffic profile. There is no other traffic on the test-bed (except for RIP). This profile shows a peak of about 3MB at the very beginning. After that, the st

Proxy Cookie Support (Bug #10722)

I recently patched bug 10722. My patch was against 2.0.49, for a Client who needed it in a hurry. I'm just porting it to 2.1-HEAD. In doing so, I find there's an existing patch that saves and restores cookies without rewriting the Domain and Path components. AFAICS my patch would/should supers