Re: svn commit: r646582 - /httpd/httpd/trunk/modules/ldap/util_ldap.c

2008-04-09 Thread Ruediger Pluem
On 10.04.2008 00:49, [EMAIL PROTECTED] wrote: Author: bnicholes Date: Wed Apr 9 15:49:31 2008 New Revision: 646582 URL: http://svn.apache.org/viewvc?rev=646582&view=rev Log: Move the initialization of rebind to the post_config handler so that it is done during the actual module load stage rathe

Re: Solaris sed based apache filtering module (mod_sed)

2008-04-09 Thread Basant Kukreja
> just that, too. Any performance comparisons with its competitors? Some quick performance comparison results between mod_sed, mod_line_edit and mod_substitute. Search/Replace string : s/hello/hi/ test0.html : No matches, so no substitute. test.html : 1 comparision/substitute test2.html : 500 c

Re: Solaris sed based apache filtering module (mod_sed)

2008-04-09 Thread Basant Kukreja
On Wed, Apr 09, 2008 at 04:32:09AM +0100, Nick Kew wrote: > On 9 Apr 2008, at 03:40, [EMAIL PROTECTED] wrote: >> Hi, >> mod_sed is a sed[1] based Apache filtering module, with the sed code based >> on >> opensolaris sed. sed scripting offers a more familiar interface to build >> powerful filters.

Re: svn commit: r646445 - in /httpd/httpd/trunk/modules/aaa: mod_auth_basic.c mod_auth_digest.c

2008-04-09 Thread Graham Leggett
Chris Darroch wrote: Can you check if mod_auth_form also needs this? Yes, it does -- looks like you're doing your own ap_lookup_provider() calls on the authn provider group. This was based originally on the mod_auth_basic code. I didn't want to make a change that I didn't fully understand

Re: svn commit: r646445 - in /httpd/httpd/trunk/modules/aaa: mod_auth_basic.c mod_auth_digest.c

2008-04-09 Thread Chris Darroch
Graham Leggett wrote: Let each consumer of authn providers redefine the list_provider_names callback in case they are loaded individually without mod_authn_core. Can you check if mod_auth_form also needs this? Yes, it does -- looks like you're doing your own ap_lookup_provider() calls on

Re: svn commit: r646445 - in /httpd/httpd/trunk/modules/aaa: mod_auth_basic.c mod_auth_digest.c

2008-04-09 Thread Graham Leggett
[EMAIL PROTECTED] wrote: URL: http://svn.apache.org/viewvc?rev=646445&view=rev Log: Let each consumer of authn providers redefine the list_provider_names callback in case they are loaded individually without mod_authn_core. Modified: httpd/httpd/trunk/modules/aaa/mod_auth_basic.c httpd/

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Paul Querna
Graham Leggett wrote: Joe Orton wrote: The entire request body passes through the input filter stack when it is being discarded. So an input filter inserted by a module can capture and buffer it somewhere very easily; and can provide access to that buffered copy however it likes, without nee

Re: AuthzMergeRules directive

2008-04-09 Thread Chris Darroch
Chris Darroch wrote: Here's another thought: for people doing mass virtual hosting, and who let their customers put authn/z directives into .htaccess files with "AllowOverride AuthConfig", I would think it may be important to ensure that these rules still merge together in the way they used t

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Graham Leggett
Joe Orton wrote: The entire request body passes through the input filter stack when it is being discarded. So an input filter inserted by a module can capture and buffer it somewhere very easily; and can provide access to that buffered copy however it likes, without needing to modify request_

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Joe Orton
On Wed, Apr 09, 2008 at 05:07:33PM +0200, Graham Leggett wrote: > Joe Orton wrote: > >> I don't understand why *that* stuff needed to be in the core. It is >> certainly possible to consume then reinject the request body, without >> changing one line of core filters; it's done in mod_ssl, see >>

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Graham Leggett
Joe Orton wrote: I don't understand why *that* stuff needed to be in the core. It is certainly possible to consume then reinject the request body, without changing one line of core filters; it's done in mod_ssl, see ssl_io_filter_buffer/ssl_io_buffer_fill. What about modules that call ap_di

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Joe Orton
On Wed, Apr 09, 2008 at 03:10:25PM +0200, Graham Leggett wrote: > Roy T. Fielding wrote: > >> -1. Bloat like this belongs in a module. > > This piece of code depends on the KeptBodySize directive, which is part of > the http_filter, and sits alongside ap_discard_request_body(). I don't understan

Re: svn commit: r646285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_auth_form.xml modules/aaa/config.m4 modules/aaa/mod_auth_form.c

2008-04-09 Thread Graham Leggett
Takashi Sato wrote: Please use svn:keywords = LastChangedRevision . Done. Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Graham Leggett
Roy T. Fielding wrote: -1. Bloat like this belongs in a module. This piece of code depends on the KeptBodySize directive, which is part of the http_filter, and sits alongside ap_discard_request_body(). I can move it into another module, but then that just gives the administrator one extra

Re: svn commit: r646285 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_auth_form.xml modules/aaa/config.m4 modules/aaa/mod_auth_form.c

2008-04-09 Thread Takashi Sato
On Wed, 09 Apr 2008 11:46:48 - [EMAIL PROTECTED] wrote: > Added: httpd/httpd/trunk/docs/manual/mod/mod_auth_form.xml > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_auth_form.xml?rev=646285&view=auto > ===

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-09 Thread Roy T. Fielding
-1. Bloat like this belongs in a module. Roy

Re: Apache support for form authentication

2008-04-09 Thread Guenter Knauf
Hi Graham, >> maybe you can already commit mod_auth_form for the un-patient even though >> docu might not be ready yet? I've just now a little bit time to look into >> building the whole session stuff properly on NetWare... > I just did :) and even with docu!! Thanks very much! Guenter.

Re: Apache support for form authentication

2008-04-09 Thread Graham Leggett
Guenter Knauf wrote: maybe you can already commit mod_auth_form for the un-patient even though docu might not be ready yet? I've just now a little bit time to look into building the whole session stuff properly on NetWare... I just did :) Regards, Graham -- smime.p7s Description: S/MIME Cry

Re: Apache support for form authentication

2008-04-09 Thread Guenter Knauf
Hi Graham, > The mod_session_dbd module is written but not yet completely tested, and > the mod_auth_form module is written, tested, but not yet documented. > This should be completed over the next few days. maybe you can already commit mod_auth_form for the un-patient even though docu might not be

Re: svn commit: r646126 - in /httpd/httpd/trunk/modules/session:mod_session.c mod_session_cookie.c mod_session_crypto.c mod_session_dbd.c

2008-04-09 Thread Guenter Knauf
Hi Ruediger, > 1. Why using AP_DECLARE for functions that seem to be clearly used as > functions > local to this file. IMHO static int would be better. > 2. Why using an ap_ prefix for a local function? IMHO only exported > function > should get this prefix. Otherwise you might get confused

Re: Functions run when configuration file is read

2008-04-09 Thread Dirk-Willem van Gulik
On Apr 8, 2008, at 8:44 PM, Andy Grant wrote: I am writing a module that runs certain functions depending on the configuration directives in the conf files. The functions are run twice when the server is started and again when the server shuts down. Is there a way to make the functions r

Re: svn commit: r646206 - in /httpd/sandbox/amsterdam/d: build/build-modules-c.awk include/http_core.h server/Makefile.in server/serf_filters.c

2008-04-09 Thread Ruediger Pluem
On 09.04.2008 09:21, [EMAIL PROTECTED] wrote: Author: pquerna Date: Wed Apr 9 00:21:01 2008 New Revision: 646206 URL: http://svn.apache.org/viewvc?rev=646206&view=rev Log: Move the core serf filters to the core. Added: httpd/sandbox/amsterdam/d/server/serf_filters.c Modified: httpd/san

Re: svn commit: r646126 - in /httpd/httpd/trunk/modules/session: mod_session.c mod_session_cookie.c mod_session_crypto.c mod_session_dbd.c

2008-04-09 Thread Ruediger Pluem
On 09.04.2008 01:12, [EMAIL PROTECTED] wrote: Author: minfrin Date: Tue Apr 8 16:12:12 2008 New Revision: 646126 URL: http://svn.apache.org/viewvc?rev=646126&view=rev Log: Insert prototypes to remove compiler warnings. [Joe Orton] Modified: httpd/httpd/trunk/modules/session/mod_session.c

Re: Solaris sed based apache filtering module (mod_sed)

2008-04-09 Thread Nick Kew
On 9 Apr 2008, at 03:40, [EMAIL PROTECTED] wrote: Hi, mod_sed is a sed[1] based Apache filtering module, with the sed code based on opensolaris sed. sed scripting offers a more familiar interface to build powerful filters. This mod_sed is designed to work with Apache HTTP server version 2.