Re: GCC 4, NULL and missing sentinel warnings

2009-05-12 Thread William A. Rowe, Jr.
Rainer Jung wrote: > > Should I prepare a patch along those lines? Maybe bring this up on the d...@apr.apache.org list?

GCC 4, NULL and missing sentinel warnings

2009-05-12 Thread Rainer Jung
In revision 683278 Joe introduced a sentinel attribute mark to some APR functions (trunk and 1.4). When compiling httpd trunk I noticed, that on Solaris 8 and 10 using GCC 4 I get warnings about missing sentinels in function calls. I also get it on some apr files, like e.g. apr_tables.c. It turns

Re: svn commit: r773929 - in /httpd/httpd/trunk/modules/proxy: ./ balancers/ examples/

2009-05-12 Thread Jim Jagielski
On May 12, 2009, at 2:53 PM, Ruediger Pluem wrote: On 05/12/2009 05:10 PM, jfcl...@apache.org wrote: Author: jfclere Date: Tue May 12 15:10:56 2009 New Revision: 773929 URL: http://svn.apache.org/viewvc?rev=773929&view=rev Log: Arrange the proxy_balancer_method: - Put context back after the

Re: svn commit: r773929 - in /httpd/httpd/trunk/modules/proxy: ./ balancers/ examples/

2009-05-12 Thread Ruediger Pluem
On 05/12/2009 05:10 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Tue May 12 15:10:56 2009 > New Revision: 773929 > > URL: http://svn.apache.org/viewvc?rev=773929&view=rev > Log: > Arrange the proxy_balancer_method: > - Put context back after the finder(). > - Use server_rec as second

Re: Why does SetHandler have ForceHandler semantics?

2009-05-12 Thread William A. Rowe, Jr.
Nick Kew wrote: > Inspired by Rich's feature request in PR#47184, I wondered why > > > SetHandler FooDefault > AddHandler my-handler .foo .bar > > > doesn't have "specificity" semantics, wherein the AddHandler > overrides the SetHandler. The SetFoo -override- is designed to override al

Re: proxy_balancer_method

2009-05-12 Thread Jim Jagielski
Ahh... I *did* miss it :) +1. PS: I should have added age and reset to the end of the struct instead of the middle, so you can fold that in as well. On May 12, 2009, at 8:57 AM, jean-frederic clere wrote: Jim Jagielski wrote: I must be missing it, but I don't see the diff between the below a

Re: proxy_balancer_method

2009-05-12 Thread jean-frederic clere
Jim Jagielski wrote: I must be missing it, but I don't see the diff between the below and what is in mod_proxy.h in trunk... server_rec *r instead request_rec *r for reset() and age(). Cheers Jean-Frederic

Re: proxy_balancer_method

2009-05-12 Thread Jim Jagielski
I must be missing it, but I don't see the diff between the below and what is in mod_proxy.h in trunk... On May 12, 2009, at 5:47 AM, jean-frederic clere wrote: Hi, I would like to change the proxy_balancer_method to the following: +++ struct proxy_balancer_method { const char *name;

proxy_balancer_method

2009-05-12 Thread jean-frederic clere
Hi, I would like to change the proxy_balancer_method to the following: +++ struct proxy_balancer_method { const char *name;/* name of the load balancer method*/ proxy_worker *(*finder)(proxy_balancer *balancer, request_rec *r); apr_status_t (*re

Re: svn commit: r771998

2009-05-12 Thread Jeff Trawick
On Mon, May 11, 2009 at 11:18 PM, William A. Rowe, Jr. wrote: > William A. Rowe, Jr. wrote: > > Roy T. Fielding wrote: > >> On May 7, 2009, at 10:57 PM, William A. Rowe, Jr. wrote: > >>> In any case, I have a better solution. mod_so is not a URI mapper, nor > >>> is mod_watchdog. I created a mod

Why does SetHandler have ForceHandler semantics?

2009-05-12 Thread Nick Kew
Inspired by Rich's feature request in PR#47184, I wondered why SetHandler FooDefault AddHandler my-handler .foo .bar doesn't have "specificity" semantics, wherein the AddHandler overrides the SetHandler. Turns out the latter gets set in core_override_type(), which is a fixups